From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20556 invoked by alias); 12 Mar 2014 12:34:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20544 invoked by uid 89); 12 Mar 2014 12:34:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mga09.intel.com Received: from mga09.intel.com (HELO mga09.intel.com) (134.134.136.24) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Mar 2014 12:33:59 +0000 Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 12 Mar 2014 05:28:36 -0700 X-ExtLoop1: 1 Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga002.jf.intel.com with ESMTP; 12 Mar 2014 05:33:04 -0700 Received: from irsmsx106.ger.corp.intel.com (163.33.3.31) by IRSMSX102.ger.corp.intel.com (163.33.3.155) with Microsoft SMTP Server (TLS) id 14.3.123.3; Wed, 12 Mar 2014 12:32:56 +0000 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.62]) by IRSMSX106.ger.corp.intel.com ([169.254.8.177]) with mapi id 14.03.0123.003; Wed, 12 Mar 2014 12:32:57 +0000 From: "Agovic, Sanimir" To: 'Pedro Alves' CC: "gdb-patches@sourceware.org" Subject: RE: [PUSHED] inf-child.c: Update comments. Date: Wed, 12 Mar 2014 12:34:00 -0000 Message-ID: <0377C58828D86C4588AEEC42FC3B85A717734076@IRSMSX105.ger.corp.intel.com> References: <1394625117-10939-1-git-send-email-palves@redhat.com> In-Reply-To: <1394625117-10939-1-git-send-email-palves@redhat.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-03/txt/msg00283.txt.bz2 Hello Pedro, $ grep -Hni unix inf-child.c inf-child.c:115: error (_("Use the \"run\" command to start a Unix child p= rocess.")); inf-child.c:401: t->to_longname =3D "Unix child process"; inf-child.c:402: t->to_doc =3D "Unix child process (started by the \"run\"= command)."; "child process" would match the target name/doc better with your committed = changes. -Sanimir > -----Original Message----- > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-owner@sourcewa= re.org] On Behalf > Of Pedro Alves > Sent: Wednesday, March 12, 2014 12:52 PM > To: gdb-patches@sourceware.org > Subject: [PUSHED] inf-child.c: Update comments. >=20 > This file is no longer used exclusively by Unix targets anymore. >=20 > gdb/ > 2014-03-12 Pedro Alves >=20 > * inf-child.c: Update top comment to not mention Unix. Add > generic comment describing how this target is meant to be used. > (inf_child_post_attach, inf_child_post_startup_inferior) > (inf_child_follow_fork, inf_child_pid_to_exec_file): Don't mention > Unix in comment. > --- > gdb/ChangeLog | 8 ++++++++ > gdb/inf-child.c | 23 +++++++++++++---------- > 2 files changed, 21 insertions(+), 10 deletions(-) >=20 > diff --git a/gdb/ChangeLog b/gdb/ChangeLog > index abfbfd7..f8d9d05 100644 > --- a/gdb/ChangeLog > +++ b/gdb/ChangeLog > @@ -1,5 +1,13 @@ > 2014-03-12 Pedro Alves >=20 > + * inf-child.c: Update top comment to not mention Unix. Add > + generic comment describing how this target is meant to be used. > + (inf_child_post_attach, inf_child_post_startup_inferior) > + (inf_child_follow_fork, inf_child_pid_to_exec_file): Don't mention > + Unix in comment. > + > +2014-03-12 Pedro Alves > + > * nto-procfs.c: Include inf-child.h. > (procfs_ops): Delete global. > (procfs_can_run): Delete method. > diff --git a/gdb/inf-child.c b/gdb/inf-child.c > index fd03a9f..ee63dd1 100644 > --- a/gdb/inf-child.c > +++ b/gdb/inf-child.c > @@ -1,5 +1,4 @@ > -/* Default child (native) target interface, for GDB when running under > - Unix. > +/* Base/prototype target for default child (native) targets. >=20 > Copyright (C) 1988-2014 Free Software Foundation, Inc. >=20 > @@ -18,6 +17,11 @@ > You should have received a copy of the GNU General Public License > along with this program. If not, see .= */ >=20 > +/* This file provides a common base class/target that all native > + target implementations extend, by calling inf_child_target to get a > + new prototype target and then overriding target methods as > + necessary. */ > + > #include "defs.h" > #include "regcache.h" > #include "memattr.h" > @@ -89,8 +93,8 @@ inf_child_store_inferior_registers (struct target_ops *= ops, > static void > inf_child_post_attach (struct target_ops *self, int pid) > { > - /* This version of Unix doesn't require a meaningful "post attach" > - operation by a debugger. */ > + /* This target doesn't require a meaningful "post attach" operation > + by a debugger. */ > } >=20 > /* Get ready to modify the registers array. On machines which store > @@ -114,16 +118,15 @@ inf_child_open (char *arg, int from_tty) > static void > inf_child_post_startup_inferior (struct target_ops *self, ptid_t ptid) > { > - /* This version of Unix doesn't require a meaningful "post startup > - inferior" operation by a debugger. */ > + /* This target doesn't require a meaningful "post startup inferior" > + operation by a debugger. */ > } >=20 > static int > inf_child_follow_fork (struct target_ops *ops, int follow_child, > int detach_fork) > { > - /* This version of Unix doesn't support following fork or vfork > - events. */ > + /* This target doesn't support following fork or vfork events. */ > return 0; > } >=20 > @@ -136,8 +139,8 @@ inf_child_can_run (struct target_ops *self) > static char * > inf_child_pid_to_exec_file (struct target_ops *self, int pid) > { > - /* This version of Unix doesn't support translation of a process ID > - to the filename of the executable file. */ > + /* This target doesn't support translation of a process ID to the > + filename of the executable file. */ > return NULL; > } >=20 > -- > 1.7.11.7 Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052