From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4292 invoked by alias); 28 Feb 2014 11:02:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4276 invoked by uid 89); 28 Feb 2014 11:02:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mga09.intel.com Received: from mga09.intel.com (HELO mga09.intel.com) (134.134.136.24) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Feb 2014 11:02:29 +0000 Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 28 Feb 2014 02:58:02 -0800 X-ExtLoop1: 1 Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by orsmga002.jf.intel.com with ESMTP; 28 Feb 2014 03:02:23 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.146]) by IRSMSX104.ger.corp.intel.com ([169.254.5.244]) with mapi id 14.03.0123.003; Fri, 28 Feb 2014 11:00:30 +0000 From: "Agovic, Sanimir" To: 'Joel Brobecker' CC: "tromey@redhat.com" , "Boell, Keven" , "gdb-patches@sourceware.org" Subject: RE: [PATCH v5 01/15] refactoring: rename create_range_type to create_static_range_type Date: Fri, 28 Feb 2014 11:02:00 -0000 Message-ID: <0377C58828D86C4588AEEC42FC3B85A71771211A@IRSMSX105.ger.corp.intel.com> References: <1391704056-25246-1-git-send-email-sanimir.agovic@intel.com> <1391704056-25246-2-git-send-email-sanimir.agovic@intel.com> <20140227220316.GA10536@adacore.com> In-Reply-To: <20140227220316.GA10536@adacore.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-02/txt/msg00856.txt.bz2 Thanks for your review. > I have a few minor formatting nits highighted below, but this patch > is pre-approved with those changes. Addressed mentioned ChangeLog and coding style issues below. Thanks again. -Sanimir > -----Original Message----- > From: Joel Brobecker [mailto:brobecker@adacore.com] > Sent: Thursday, February 27, 2014 11:03 PM > To: Agovic, Sanimir > Cc: tromey@redhat.com; Boell, Keven; gdb-patches@sourceware.org > Subject: Re: [PATCH v5 01/15] refactoring: rename create_range_type to > create_static_range_type >=20 > On Thu, Feb 06, 2014 at 05:27:22PM +0100, Sanimir Agovic wrote: > > 2013-12-19 Sanimir Agovic > > Keven Boell > > > > * gdbtypes.c (create_static_range_type): Renamed from create_range_typ= e. > > * gdbtypes.h (create_static_range_type): Renamed from create_range_typ= e. > > * ada-lang.c (*): All uses of create_range_type updated. > > * coffread.c (*): All uses of create_range_type updated. > > * dwarf2read.c (*): All uses of create_range_type updated. > > * f-exp.y (*): All uses of create_range_type updated. > > * m2-valprint.c (*): All uses of create_range_type updated. > > * mdebugread.c (*): All uses of create_range_type updated. > > * stabsread.c (*): All uses of create_range_type updated. > > * valops.c (*): All uses of create_range_type updated. > > * valprint.c (*): All uses of create_range_type updated. >=20 > Can you remove the " (*)" from the ChangeLog entries? These are not > needed. Thus, for instance: >=20 > * ada-lang.c: All uses of create_range_type updated. >=20 > I have a few minor formatting nits highighted below, but this patch > is pre-approved with those changes. >=20 > Thank you! >=20 > > diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c > > index 786ca7a..0d93267 100644 > > --- a/gdb/ada-lang.c > > +++ b/gdb/ada-lang.c > > @@ -1875,8 +1875,8 @@ ada_type_of_array (struct value *arr, int bounds) > > struct value *high =3D desc_one_bound (descriptor, arity, 1); > > > > arity -=3D 1; > > - create_range_type (range_type, value_type (low), > > - longest_to_int (value_as_long (low)), > > + create_static_range_type (range_type, value_type (low), > > + longest_to_int (value_as_long (low)), > > longest_to_int (value_as_long (high))); >=20 > The indentation of the 3 line (longest_to_int) needs to be adjusted. >=20 > > struct type *index_type =3D > > - create_range_type (NULL, TYPE_TARGET_TYPE (TYPE_INDEX_TYPE (type0)= ), > > - low, high); > > + create_static_range_type (NULL, TYPE_TARGET_TYPE (TYPE_INDEX_TYPE = (type0)), > > + low, high); >=20 > I know that you've been following the style in this file, but > the assignment operator should be at the start of the next line. > We don't need or even want to fix all incorrect forms in this patch, > but can we fix the ones we touch? >=20 > > struct type *index_type =3D > > - create_range_type (NULL, TYPE_INDEX_TYPE (type), low, high); > > + create_static_range_type (NULL, TYPE_INDEX_TYPE (type), low, high); >=20 > Same here, please. >=20 > > struct type *index_type =3D > > - create_range_type (NULL, TYPE_TARGET_TYPE (TYPE_INDEX_TYPE (arr_ty= pe0)), > > - low, low - 1); > > + create_static_range_type > > + (NULL, TYPE_TARGET_TYPE (TYPE_INDEX_TYPE (arr_type0)), low, low - = 1); >=20 > Same as above. Also, can you indent the '(' for the start of the > function parameters 2 characters past the funtion's indentation? > Something like the following: >=20 > struct type *index_type > =3D create_static_range_type > (NULL, TYPE_TARGET_TYPE (TYPE_INDEX_TYPE (arr_type0)), low, low -= 1); >=20 > -- > Joel Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052