From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5746 invoked by alias); 16 Jan 2014 17:03:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5737 invoked by uid 89); 16 Jan 2014 17:03:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mga02.intel.com Received: from mga02.intel.com (HELO mga02.intel.com) (134.134.136.20) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 16 Jan 2014 17:03:08 +0000 Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 16 Jan 2014 09:02:47 -0800 X-ExtLoop1: 1 Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by orsmga002.jf.intel.com with ESMTP; 16 Jan 2014 09:02:39 -0800 Received: from irsmsx153.ger.corp.intel.com (163.33.192.75) by IRSMSX104.ger.corp.intel.com (163.33.3.159) with Microsoft SMTP Server (TLS) id 14.3.123.3; Thu, 16 Jan 2014 17:02:36 +0000 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.215]) by IRSMSX153.ger.corp.intel.com ([169.254.9.156]) with mapi id 14.03.0123.003; Thu, 16 Jan 2014 17:02:36 +0000 From: "Agovic, Sanimir" To: 'Tom Tromey' , 'Joel Brobecker' CC: "palves@redhat.com" , "xdje42@gmail.com" , "gdb-patches@sourceware.org" , "Boell, Keven" Subject: RE: [PATCH v4 01/13] vla: introduce new bound type abstraction adapt uses Date: Thu, 16 Jan 2014 17:03:00 -0000 Message-ID: <0377C58828D86C4588AEEC42FC3B85A7176D3683@IRSMSX105.ger.corp.intel.com> References: <1387282678-3847-1-git-send-email-sanimir.agovic@intel.com> <1387282678-3847-2-git-send-email-sanimir.agovic@intel.com> <20131218032427.GD3493@adacore.com> <0377C58828D86C4588AEEC42FC3B85A7176CB92F@IRSMSX105.ger.corp.intel.com> <87zjmworgf.fsf@fleche.redhat.com> In-Reply-To: <87zjmworgf.fsf@fleche.redhat.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-01/txt/msg00621.txt.bz2 Thanks for your review. > -----Original Message----- > From: Tom Tromey [mailto:tromey@redhat.com] > Sent: Wednesday, January 15, 2014 10:39 PM > To: Agovic, Sanimir > Cc: 'Joel Brobecker'; palves@redhat.com; xdje42@gmail.com; gdb-patches@so= urceware.org; > Boell, Keven > Subject: Re: [PATCH v4 01/13] vla: introduce new bound type abstraction a= dapt uses >=20 > Joel> I think that the _1 suffix is usually used when the function perfor= ms > Joel> the private portion of a more public routine. But in this case, > Joel> create_range_type_1 is meant to be a public routine, and the _1 > Joel> suffix is not very explicit. IMO, what would be ideal would be to > Joel> rename the current create_range_type into "create_static_range_type= ", > Joel> and then make create_range_type_1 the new create_range_type. I chec= ked > Joel> the GDB tree, and there aren't that many calls to update. If people > Joel> prefer, I can even take care of that myself once the patche series > Joel> has gone in. Otherwise, another compromise solution is to rename > Joel> create_range_type_1 to create_range_type_full (for instance). >=20 > Sanimir> Sounds good to me. I will prepend a patch doing the > Sanimir> create_range_type -> create_static_range_type thingy and use > Sanimir> create_range_type in this patch instead of create_range_type_1. >=20 > I guess this is one of the remaining blockers for this series now. > Though since Joel was agreeable I think it would be fine if you'd prefer > to do it as a follow-up. >=20 I had already prepared a patch doing the necessary renaming upfront. If it = is OK to you and/or Joel I like to keep it as the first patch in my series. -Sanimir Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052