From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1606 invoked by alias); 16 Jan 2014 17:00:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1587 invoked by uid 89); 16 Jan 2014 17:00:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mga09.intel.com Received: from mga09.intel.com (HELO mga09.intel.com) (134.134.136.24) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 16 Jan 2014 17:00:28 +0000 Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 16 Jan 2014 08:56:23 -0800 X-ExtLoop1: 1 Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga002.jf.intel.com with ESMTP; 16 Jan 2014 09:00:10 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.215]) by IRSMSX102.ger.corp.intel.com ([169.254.2.114]) with mapi id 14.03.0123.003; Thu, 16 Jan 2014 17:00:06 +0000 From: "Agovic, Sanimir" To: 'Joel Brobecker' CC: "tromey@redhat.com" , "palves@redhat.com" , "xdje42@gmail.com" , "gdb-patches@sourceware.org" , "Boell, Keven" Subject: RE: [PATCH v3 00/13] C99 variable length array support Date: Thu, 16 Jan 2014 17:00:00 -0000 Message-ID: <0377C58828D86C4588AEEC42FC3B85A7176D363F@IRSMSX105.ger.corp.intel.com> References: <1386166785-28037-1-git-send-email-sanimir.agovic@intel.com> <20140115114133.GA26593@adacore.com> In-Reply-To: <20140115114133.GA26593@adacore.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-01/txt/msg00616.txt.bz2 Thanks for your review. > -----Original Message----- > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-owner@sourcewa= re.org] On Behalf > Of Joel Brobecker > Sent: Wednesday, January 15, 2014 12:42 PM > To: Agovic, Sanimir > Cc: tromey@redhat.com; palves@redhat.com; xdje42@gmail.com; gdb-patches@s= ourceware.org; > Boell, Keven > Subject: Re: [PATCH v3 00/13] C99 variable length array support >=20 > Hello, >=20 > > this patch series (v3) add C99 variable length support to gdb. > > > > It allows the user to evaluate a vla like an ordinary static array e.g.= print > > its elements instead of printing the pointer to the array. In addition > > the size of a vla can be retrieved with gdbs builtin sizeof operator. >=20 > We've started working internally at AdaCore on getting rid of some > of the "GNAT encodings", with the goal of replacing them with pure > dwarf constructs. One of the issues we've noticed is precisely > the lack of support for dynamically-sized arrays, and I think > this patch series would be a very good stepping stone towards that. >=20 It would be great if gnat could benefit from c99 and the upcoming fortran v= la support. I hacked on the D and go-lang compiler and could get variable leng= th arrays working without additional changes to gdb, simply by changing what t= he compiler emits for ranges.=20 > I remember I had one patch that made me a little nervous (patch #5/13, > adding type re-fecthing after some value_* calls), but I also said > that I would be OK if the patch went in as is. Apart from that, > it seems to me that most/all? comments have been addressed? > Perhaps, all we're missing is just v4 of the patch series? >=20 If it is OK for you I`d like to keep #5 as-is. AFAIK struct value is opaque outside of its definition so any knowledge about how it works (e.g. how values are constructed) means we leak implementation details. > Any chance we could make progress on those? If there is anything > I can do to assist, please let me know as well! >=20 Sure, I`m back and willing to address the missing parts =3DD -Sanimir Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052