From: "Agovic, Sanimir" <sanimir.agovic@intel.com>
To: 'Tom Tromey' <tromey@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: [PATCH 05/10] vla: allow side effects for sizeof argument
Date: Wed, 20 Nov 2013 12:18:00 -0000 [thread overview]
Message-ID: <0377C58828D86C4588AEEC42FC3B85A7176B8257@IRSMSX105.ger.corp.intel.com> (raw)
In-Reply-To: <87vbzppuz5.fsf@fleche.redhat.com>
> -----Original Message-----
> From: Tom Tromey [mailto:tromey@redhat.com]
> Sent: Monday, November 18, 2013 04:53 PM
> To: Agovic, Sanimir
> Cc: gdb-patches@sourceware.org
> Subject: Re: [PATCH 05/10] vla: allow side effects for sizeof argument
>
> >>>>> "Sanimir" == Agovic, Sanimir <sanimir.agovic@intel.com> writes:
>
> Sanimir> It turns out this patch is not needed anymore as the bounds are
> Sanimir> resolved before the sizeof function is called. So in v2 this
> Sanimir> patch will be dropped from the series.
>
> Tom> (gdb) print sizeof (array[x++])
> Tom> For an ordinary array this should not modify x.
>
> Sanimir> Indeed, that is the behavior we have now in HEAD@vla-c99.
>
> I thought sizeof with a vla as an argument had to evaluate its argument.
> So it seems that the above may yield incorrect semantics in some other
> test case.
>
The patch was needed for a now discontinued vla prototype, meanwhile we
moved the logic to the following value constructors
value_at/value_at_lazy/value_from_contents_and_address which is easier to
maintain and is mostly transparent to existing code.
In this particular case we will end up in dispatching 'array' in the switch
case 'OP_VAR_VALUE', using value_of_variable which will end up calling a
value constructor with an address, therefore we resolved correctly the
bounds and the patch is not needed anymore.
-Sanimir
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052
next prev parent reply other threads:[~2013-11-20 12:16 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-21 14:40 C99 variable length array support Sanimir Agovic
2013-10-21 14:40 ` [PATCH 09/10] test: basic c99 vla tests Sanimir Agovic
2013-11-07 21:23 ` Tom Tromey
2013-10-21 14:40 ` [PATCH 02/10] type: add c99 variable length array support Sanimir Agovic
2013-11-07 19:02 ` Tom Tromey
2013-11-19 15:31 ` Agovic, Sanimir
2013-11-22 20:00 ` Tom Tromey
2013-11-27 17:08 ` Agovic, Sanimir
[not found] ` <0377C58828D86C4588AEEC42FC3B85A7176BC3DE@IRSMSX105.ger.corp.intel.com>
2013-11-27 17:15 ` Agovic, Sanimir
2013-11-07 19:10 ` Tom Tromey
2013-10-21 14:40 ` [PATCH 07/10] test: evaluate pointers to C99 vla correctly Sanimir Agovic
2013-11-07 20:57 ` Tom Tromey
2013-11-08 6:37 ` Tom Tromey
2013-11-07 21:14 ` Tom Tromey
2013-10-21 14:40 ` [PATCH 06/10] vla: update type from newly created value Sanimir Agovic
2013-11-07 20:56 ` Tom Tromey
2013-11-20 7:56 ` Agovic, Sanimir
2013-11-20 11:02 ` Pedro Alves
2013-11-20 13:08 ` Agovic, Sanimir
2013-11-21 18:50 ` Pedro Alves
2013-11-23 19:27 ` Doug Evans
2013-10-21 14:40 ` [PATCH 03/10] vla: enable sizeof operator to work with variable length arrays Sanimir Agovic
2013-11-07 19:10 ` Tom Tromey
2013-10-21 14:40 ` [PATCH 05/10] vla: allow side effects for sizeof argument Sanimir Agovic
2013-10-24 19:55 ` Tom Tromey
2013-10-25 8:13 ` Agovic, Sanimir
2013-10-28 21:00 ` Tom Tromey
2013-11-18 9:37 ` Agovic, Sanimir
2013-11-18 15:56 ` Tom Tromey
2013-11-20 12:18 ` Agovic, Sanimir [this message]
2013-11-19 17:08 ` Pedro Alves
2013-11-20 12:47 ` Agovic, Sanimir
2013-11-20 13:24 ` Pedro Alves
2013-10-21 14:40 ` [PATCH 08/10] test: multi-dimensional c99 vla Sanimir Agovic
2013-11-07 21:19 ` Tom Tromey
2013-10-21 14:40 ` [PATCH 01/10] vla: introduce new bound type abstraction adapt uses Sanimir Agovic
2013-11-07 19:00 ` Tom Tromey
2013-11-18 11:15 ` Agovic, Sanimir
2013-10-21 14:40 ` [PATCH 10/10] test: add mi vla test Sanimir Agovic
2013-11-07 21:31 ` Tom Tromey
2013-10-21 14:40 ` [PATCH 04/10] vla: enable sizeof operator for indirection Sanimir Agovic
2013-11-07 19:57 ` Tom Tromey
2013-11-21 18:52 ` C99 variable length array support Pedro Alves
2013-11-21 19:01 ` Pedro Alves
2013-11-21 19:10 ` Pedro Alves
2013-11-22 10:53 ` Agovic, Sanimir
2013-11-22 12:35 ` Pedro Alves
2013-11-22 17:06 ` Agovic, Sanimir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0377C58828D86C4588AEEC42FC3B85A7176B8257@IRSMSX105.ger.corp.intel.com \
--to=sanimir.agovic@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox