From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24399 invoked by alias); 24 Sep 2013 07:07:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24390 invoked by uid 89); 24 Sep 2013 07:07:50 -0000 Received: from mga01.intel.com (HELO mga01.intel.com) (192.55.52.88) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 24 Sep 2013 07:07:50 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,MIME_BASE64_BLANKS,RDNS_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mga01.intel.com Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 24 Sep 2013 00:07:48 -0700 X-ExtLoop1: 1 Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by fmsmga002.fm.intel.com with ESMTP; 24 Sep 2013 00:07:21 -0700 Received: from irsmsx152.ger.corp.intel.com (163.33.192.66) by IRSMSX103.ger.corp.intel.com (163.33.3.157) with Microsoft SMTP Server (TLS) id 14.3.123.3; Tue, 24 Sep 2013 08:07:21 +0100 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.29]) by IRSMSX152.ger.corp.intel.com ([163.33.192.66]) with mapi id 14.03.0123.003; Tue, 24 Sep 2013 08:07:20 +0100 From: "Agovic, Sanimir" To: 'Philippe Waroquiers' CC: "gdb-patches@sourceware.org" Subject: RE: RFA [PATCH v3] Implement 'catch syscall' for gdbserver Date: Tue, 24 Sep 2013 07:07:00 -0000 Message-ID: <0377C58828D86C4588AEEC42FC3B85A7176814E1@IRSMSX105.ger.corp.intel.com> References: <1379796907.5980.20.camel@soleil> <0377C58828D86C4588AEEC42FC3B85A717680EC1@IRSMSX105.ger.corp.intel.com> <1379964754.2226.6.camel@soleil> In-Reply-To: <1379964754.2226.6.camel@soleil> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg00838.txt.bz2 PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBnZGItcGF0 Y2hlcy1vd25lckBzb3VyY2V3YXJlLm9yZyBbbWFpbHRvOmdkYi1wYXRjaGVz LW93bmVyQHNvdXJjZXdhcmUub3JnXSBPbiBCZWhhbGYNCj4gT2YgUGhpbGlw cGUgV2Fyb3F1aWVycw0KPiBTZW50OiBNb25kYXksIFNlcHRlbWJlciAyMywg MjAxMyAwOTozMyBQTQ0KPiBUbzogQWdvdmljLCBTYW5pbWlyDQo+IENjOiBn ZGItcGF0Y2hlc0Bzb3VyY2V3YXJlLm9yZw0KPiBTdWJqZWN0OiBSRTogUkZB IFtQQVRDSCB2M10gSW1wbGVtZW50ICdjYXRjaCBzeXNjYWxsJyBmb3IgZ2Ri c2VydmVyDQo+IA0KPiBPbiBNb24sIDIwMTMtMDktMjMgYXQgMTE6NTAgKzAw MDAsIEFnb3ZpYywgU2FuaW1pciB3cm90ZToNCj4gPiBIZWxsbyBQaGlsaXBw ZSwNCj4gPg0KPiANCj4gPiA+ICsgIGlmICh0aGVfbG93X3RhcmdldC5nZXRf c3lzY2FsbF90cmFwaW5mbyA9PSBOVUxMKQ0KPiA+ID4gKyAgICB7DQo+ID4g PiArICAgICAgKnN5c25vID0gMDsNCj4gPiA+ICsgICAgICAqc3lzcmV0ID0g MDsNCj4gPiA+ICsgICAgICByZXR1cm47DQo+ID4gPiArICAgIH0NCj4gPiA+ DQo+ID4gSXMgaXQgc3VmZmljaWVudCB0byBhc3NpZ24gc3lzbm8vc3lzcmV0 IHRvIDAgdG8gaW5kaWNhdGUgbWlzc2luZyAnY2F0Y2ggc3lzY2FsbCcNCj4g PiBmdW5jdGlvbmFsaXR5PyBCb3RoIHZhbHVlcyBzZWVtIGxlZ2FsIHRvIG1l Lg0KPiBUaGUgaWRlYSBpcyB0aGF0IHdpbGwgYmUgdXNlZCBpbiBjYXNlIHRo ZSB1c2VyIGZvcmNlcyB0aGUgdXNlIG9mIHRoZQ0KPiBRQ2F0Y2hTeXNjYWxs cyBwYWNrZXQuIFNvLCBJIHRoaW5rIGl0IGlzIGJldHRlciB0byByZXR1cm4g InZhbGlkIiAoYnV0DQo+IG5vdCB1c2VkKSB2YWx1ZXMgOiBJIGRvIG5vdCB0 aGluayB0aGVyZSBpcyBhIHN5c2NhbGwgbnIgMC4NCj4gDQpnZGIgLWJhdGNo IC1leCAnc2V0IGFyY2hpdGVjdHVyZSBpMzg2Ong4Ni02NCcgLWV4ICdjYXRj aCBzeXNjYWxsIDAnDQpUaGUgdGFyZ2V0IGFyY2hpdGVjdHVyZSBpcyBhc3N1 bWVkIHRvIGJlIGkzODY6eDg2LTY0DQpDYXRjaHBvaW50IDEgKHN5c2NhbGwg J3JlYWQnIFswXSkNCg0KSSBqdXN0IHdhbnRlZCB0byBtYWtlIHN1cmUgdGhh dCB3ZSBkbyBub3QgcmVwb3J0IGFueSBmYWxzZSBzeXNjYWxscy4gDQpUaHVz IEkgY2hlY2tlZCBzeXNjYWxsIDAgaW4gZ2RiIG9uIGFtZDY0IHdoaWNoIGlz IG1hcHBlZCB0byAncmVhZCcuDQoNCiAtU2FuaW1pcg0KDQpJbnRlbCBHbWJI CkRvcm5hY2hlciBTdHJhc3NlIDEKODU2MjIgRmVsZGtpcmNoZW4vTXVlbmNo ZW4sIERldXRzY2hsYW5kClNpdHogZGVyIEdlc2VsbHNjaGFmdDogRmVsZGtp cmNoZW4gYmVpIE11ZW5jaGVuCkdlc2NoYWVmdHNmdWVocmVyOiBDaHJpc3Rp YW4gTGFtcHJlY2h0ZXIsIEhhbm5lcyBTY2h3YWRlcmVyLCBEb3VnbGFzIEx1 c2sKUmVnaXN0ZXJnZXJpY2h0OiBNdWVuY2hlbiBIUkIgNDc0NTYKVXN0Li1J ZE5yLi9WQVQgUmVnaXN0cmF0aW9uIE5vLjogREUxMjkzODU4OTUKQ2l0aWJh bmsgRnJhbmtmdXJ0IGEuTS4gKEJMWiA1MDIgMTA5IDAwKSA2MDAxMTkwNTIK >From gdb-patches-return-105695-listarch-gdb-patches=sources.redhat.com@sourceware.org Tue Sep 24 11:08:39 2013 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 20612 invoked by alias); 24 Sep 2013 11:08:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 20597 invoked by uid 89); 24 Sep 2013 11:08:38 -0000 Received: from mga11.intel.com (HELO mga11.intel.com) (192.55.52.93) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 24 Sep 2013 11:08:38 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RDNS_NONE autolearn=no version=3.3.2 X-HELO: mga11.intel.com Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 24 Sep 2013 04:08:37 -0700 X-ExtLoop1: 1 Received: from irvmail001.ir.intel.com ([163.33.26.43]) by fmsmga002.fm.intel.com with ESMTP; 24 Sep 2013 04:08:35 -0700 Received: from ulslx001.iul.intel.com (ulslx001.iul.intel.com [172.28.207.63]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id r8OB8YfJ002447; Tue, 24 Sep 2013 12:08:35 +0100 Received: from ulslx001.iul.intel.com (localhost [127.0.0.1]) by ulslx001.iul.intel.com with ESMTP id r8OB8YwZ027306; Tue, 24 Sep 2013 13:08:34 +0200 Received: (from wtedesch@localhost) by ulslx001.iul.intel.com with id r8OB8Yx0027302; Tue, 24 Sep 2013 13:08:34 +0200 From: Walfred Tedeschi To: tromey@redhat.com, mark.kettenis@xs4all.nl Cc: gdb-patches@sourceware.org, Walfred Tedeschi Subject: [PATCH V6 1/8] Fix conditions in creating a bitfield. Date: Tue, 24 Sep 2013 11:08:00 -0000 Message-Id: <1380020911-27270-1-git-send-email-walfred.tedeschi@intel.com> X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg00840.txt.bz2 Content-length: 1893 Bitfields are represented by intervals [start, begin]. It means that for an interval comprised by only one bit start and end will be equal. The present condition does not always hold. On the other hand in target-description.c (tdesc_gdb_type) bitfield is created when "f->type" is null. The routine maint_print_maint_print_c_tdesc_cmd is modified to follow the same strategy. 2013-07-31 Walfred Tedeschi * target-descriptions.c (maint_print_maint_print_c_tdesc_cmd): Modified logic of creating a bitfield to be in sync with tdesc_gdb_type. testsuite/ * gdb.xml/maint_print_struct.xml (bitfield): Added bitfield having start and end equal 0. --- gdb/target-descriptions.c | 2 +- gdb/testsuite/gdb.xml/maint_print_struct.xml | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/gdb/target-descriptions.c b/gdb/target-descriptions.c index 44ad401..1410c02 100644 --- a/gdb/target-descriptions.c +++ b/gdb/target-descriptions.c @@ -1762,7 +1762,7 @@ feature = tdesc_create_feature (result, \"%s\");\n", /* Going first for implicitly sized types, else part handles bitfields. As reported on xml-tdesc.c implicitly sized types cannot contain a bitfield. */ - if (f->start == 0 && f->end == 0) + if (f->type != NULL) { printf_unfiltered (" field_type = tdesc_named_type (feature, \"%s\");\n", diff --git a/gdb/testsuite/gdb.xml/maint_print_struct.xml b/gdb/testsuite/gdb.xml/maint_print_struct.xml index 5ef0683..deac300 100644 --- a/gdb/testsuite/gdb.xml/maint_print_struct.xml +++ b/gdb/testsuite/gdb.xml/maint_print_struct.xml @@ -15,6 +15,7 @@ + -- 1.7.10.4