From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22704 invoked by alias); 23 Sep 2013 11:51:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22693 invoked by uid 89); 23 Sep 2013 11:51:20 -0000 Received: from mga02.intel.com (HELO mga02.intel.com) (134.134.136.20) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 23 Sep 2013 11:51:20 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.7 required=5.0 tests=AWL,BAYES_05,MIME_BASE64_BLANKS,RDNS_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mga02.intel.com Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 23 Sep 2013 04:51:10 -0700 X-ExtLoop1: 1 Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga001.jf.intel.com with ESMTP; 23 Sep 2013 04:50:44 -0700 Received: from irsmsx153.ger.corp.intel.com (163.33.192.75) by IRSMSX101.ger.corp.intel.com (163.33.3.153) with Microsoft SMTP Server (TLS) id 14.3.123.3; Mon, 23 Sep 2013 12:50:16 +0100 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.29]) by IRSMSX153.ger.corp.intel.com ([169.254.9.47]) with mapi id 14.03.0123.003; Mon, 23 Sep 2013 12:50:16 +0100 From: "Agovic, Sanimir" To: 'Philippe Waroquiers' CC: "gdb-patches@sourceware.org" Subject: RE: RFA [PATCH v3] Implement 'catch syscall' for gdbserver Date: Mon, 23 Sep 2013 11:51:00 -0000 Message-ID: <0377C58828D86C4588AEEC42FC3B85A717680EC1@IRSMSX105.ger.corp.intel.com> References: <1379796907.5980.20.camel@soleil> In-Reply-To: <1379796907.5980.20.camel@soleil> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg00814.txt.bz2 SGVsbG8gUGhpbGlwcGUsDQoNCnlvdSBtYXkgd2FudCB0byB1cGRhdGUgdGhl IHdpa2kgWzFdIHBhZ2UgYWJvdXQgeW91ciBwcm9ncmVzcyB3cnQgbG9jYWwv cmVtb3RlIGZlYXR1cmUgcGFyaXR5Lg0KDQpBIG1pbm9yIGNvbW1lbnQgYmVs b3cuDQoNClsxXSBodHRwczovL3NvdXJjZXdhcmUub3JnL2dkYi93aWtpL0xv Y2FsUmVtb3RlRmVhdHVyZVBhcml0eQ0KDQogLVNhbmltaXINCg0KPiAtLS0t LU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBnZGItcGF0Y2hlcy1v d25lckBzb3VyY2V3YXJlLm9yZyBbbWFpbHRvOmdkYi1wYXRjaGVzLW93bmVy QHNvdXJjZXdhcmUub3JnXSBPbiBCZWhhbGYNCj4gT2YgUGhpbGlwcGUgV2Fy b3F1aWVycw0KPiBTZW50OiBTYXR1cmRheSwgU2VwdGVtYmVyIDIxLCAyMDEz IDEwOjU1IFBNDQo+IFRvOiBnZGItcGF0Y2hlc0Bzb3VyY2V3YXJlLm9yZw0K PiBTdWJqZWN0OiBSRkEgW1BBVENIIHYzXSBJbXBsZW1lbnQgJ2NhdGNoIHN5 c2NhbGwnIGZvciBnZGJzZXJ2ZXINCj4gDQo+IEluZGV4OiBnZGJzZXJ2ZXIv bGludXgtbG93LmMNCj4gPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KPiBSQ1Mg ZmlsZTogL2N2cy9zcmMvc3JjL2dkYi9nZGJzZXJ2ZXIvbGludXgtbG93LmMs dg0KPiByZXRyaWV2aW5nIHJldmlzaW9uIDEuMjQ4DQo+IGRpZmYgLXUgLXAg LXIxLjI0OCBsaW51eC1sb3cuYw0KPiAtLS0gZ2Ric2VydmVyL2xpbnV4LWxv dy5jCTUgU2VwIDIwMTMgMjA6NDU6MzkgLTAwMDAJMS4yNDgNCj4gKysrIGdk YnNlcnZlci9saW51eC1sb3cuYwkyMSBTZXAgMjAxMyAyMDozODoxNSAtMDAw MA0KPiBAQCAtNzQsNiArNzQsMTEgQEANCj4gICNkZWZpbmUgV19TVE9QQ09E RShzaWcpICgoc2lnKSA8PCA4IHwgMHg3ZikNCj4gICNlbmRpZg0KPiANCj4g Ky8qIFVubGlrZSBvdGhlciBleHRlbmRlZCByZXN1bHQgY29kZXMsIFdTVE9Q U0lHIChzdGF0dXMpIG9uDQo+ICsgICBQVFJBQ0VfT19UUkFDRVNZU0dPT0Qg c3lzY2FsbCBldmVudHMgZG9lc24ndCByZXR1cm4gU0lHVFJBUCwgYnV0DQo+ ICsgICBpbnN0ZWFkIFNJR1RSQVAgd2l0aCBiaXQgNyBzZXQuICAqLw0KPiAr I2RlZmluZSBTWVNDQUxMX1NJR1RSQVAgKFNJR1RSQVAgfCAweDgwKQ0KPiAr DQo+ICAvKiBUaGlzIGlzIHRoZSBrZXJuZWwncyBoYXJkIGxpbWl0LiAgTm90 IHRvIGJlIGNvbmZ1c2VkIHdpdGgNCj4gICAgIFNJR1JUTUlOLiAgKi8NCj4g ICNpZm5kZWYgX19TSUdSVE1JTg0KPiBAQCAtNDgxLDYgKzQ4NiwzNiBAQCBn ZXRfcGMgKHN0cnVjdCBsd3BfaW5mbyAqbHdwKQ0KPiAgICByZXR1cm4gcGM7 DQo+ICB9DQo+IA0KPiArLyogVGhpcyBmdW5jdGlvbiBzaG91bGQgb25seSBi ZSBjYWxsZWQgaWYgTFdQIGdvdCBhIFNJR1RSQVBfU1lTQ0FMTC4NCj4gKyAg IEZpbGwgKlNZU05PIHdpdGggdGhlIHN5c2NhbGwgbnIgdHJhcHBlZC4gIEZp bGwgKlNZU1JFVCB3aXRoIHRoZQ0KPiArICAgcmV0dXJuIGNvZGUuICAqLw0K PiArDQo+ICtzdGF0aWMgdm9pZA0KPiArZ2V0X3N5c2NhbGxfdHJhcGluZm8g KHN0cnVjdCBsd3BfaW5mbyAqbHdwLCBpbnQgKnN5c25vLCBpbnQgKnN5c3Jl dCkNCj4gK3sNCj4gKyAgc3RydWN0IHRocmVhZF9pbmZvICpzYXZlZF9pbmZl cmlvcjsNCj4gKyAgc3RydWN0IHJlZ2NhY2hlICpyZWdjYWNoZTsNCj4gKw0K PiArICBpZiAodGhlX2xvd190YXJnZXQuZ2V0X3N5c2NhbGxfdHJhcGluZm8g PT0gTlVMTCkNCj4gKyAgICB7DQo+ICsgICAgICAqc3lzbm8gPSAwOw0KPiAr ICAgICAgKnN5c3JldCA9IDA7DQo+ICsgICAgICByZXR1cm47DQo+ICsgICAg fQ0KPg0KSXMgaXQgc3VmZmljaWVudCB0byBhc3NpZ24gc3lzbm8vc3lzcmV0 IHRvIDAgdG8gaW5kaWNhdGUgbWlzc2luZyAnY2F0Y2ggc3lzY2FsbCcNCmZ1 bmN0aW9uYWxpdHk/IEJvdGggdmFsdWVzIHNlZW0gbGVnYWwgdG8gbWUuDQoN CkludGVsIEdtYkgKRG9ybmFjaGVyIFN0cmFzc2UgMQo4NTYyMiBGZWxka2ly Y2hlbi9NdWVuY2hlbiwgRGV1dHNjaGxhbmQKU2l0eiBkZXIgR2VzZWxsc2No YWZ0OiBGZWxka2lyY2hlbiBiZWkgTXVlbmNoZW4KR2VzY2hhZWZ0c2Z1ZWhy ZXI6IENocmlzdGlhbiBMYW1wcmVjaHRlciwgSGFubmVzIFNjaHdhZGVyZXIs IERvdWdsYXMgTHVzawpSZWdpc3RlcmdlcmljaHQ6IE11ZW5jaGVuIEhSQiA0 NzQ1NgpVc3QuLUlkTnIuL1ZBVCBSZWdpc3RyYXRpb24gTm8uOiBERTEyOTM4 NTg5NQpDaXRpYmFuayBGcmFua2Z1cnQgYS5NLiAoQkxaIDUwMiAxMDkgMDAp IDYwMDExOTA1Mgo= >From gdb-patches-return-105670-listarch-gdb-patches=sources.redhat.com@sourceware.org Mon Sep 23 11:53:24 2013 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 24417 invoked by alias); 23 Sep 2013 11:53:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 24403 invoked by uid 89); 23 Sep 2013 11:53:24 -0000 Received: from mms2.broadcom.com (HELO mms2.broadcom.com) (216.31.210.18) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 23 Sep 2013 11:53:24 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,RDNS_NONE autolearn=no version=3.3.2 X-HELO: mms2.broadcom.com Received: from [10.9.208.55] by mms2.broadcom.com with ESMTP (Broadcom SMTP Relay (Email Firewall v6.5)); Mon, 23 Sep 2013 04:46:43 -0700 X-Server-Uuid: 4500596E-606A-40F9-852D-14843D8201B2 Received: from IRVEXCHSMTP1.corp.ad.broadcom.com (10.9.207.51) by IRVEXCHCAS07.corp.ad.broadcom.com (10.9.208.55) with Microsoft SMTP Server (TLS) id 14.1.438.0; Mon, 23 Sep 2013 04:53:10 -0700 Received: from mail-irva-13.broadcom.com (10.10.10.20) by IRVEXCHSMTP1.corp.ad.broadcom.com (10.9.207.51) with Microsoft SMTP Server id 14.1.438.0; Mon, 23 Sep 2013 04:53:10 -0700 Received: from [10.177.73.74] (unknown [10.177.73.74]) by mail-irva-13.broadcom.com (Postfix) with ESMTP id 202E5246A3 for ; Mon, 23 Sep 2013 04:53:09 -0700 (PDT) Message-ID: <52402BA5.8050900@broadcom.com> Date: Mon, 23 Sep 2013 11:53:00 -0000 From: "Andrew Burgess" User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: "gdb-patches@sourceware.org" Subject: [PATCH] regcache, use print_hex_chars Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg00815.txt.bz2 Content-length: 2231 Another place we reimplement print_hex_chars, again I'll commit as obvious in a few days if nobody objects. Thanks, Andrew gdb/ChangeLog 2013-09-23 Andrew Burgess * regcache.c: Add include of valprint.h. (dump_endian_bytes): Delete. (regcache_dump): Use print_hex_chars not dump_endian_bytes. diff --git a/gdb/regcache.c b/gdb/regcache.c index 57d29e4..7ec75c8 100644 --- a/gdb/regcache.c +++ b/gdb/regcache.c @@ -30,6 +30,7 @@ #include "observer.h" #include "exceptions.h" #include "remote.h" +#include "valprint.h" /* * DATA STRUCTURE @@ -1090,27 +1091,6 @@ reg_flush_command (char *command, int from_tty) printf_filtered (_("Register cache flushed.\n")); } -static void -dump_endian_bytes (struct ui_file *file, enum bfd_endian endian, - const gdb_byte *buf, long len) -{ - int i; - - switch (endian) - { - case BFD_ENDIAN_BIG: - for (i = 0; i < len; i++) - fprintf_unfiltered (file, "%02x", buf[i]); - break; - case BFD_ENDIAN_LITTLE: - for (i = len - 1; i >= 0; i--) - fprintf_unfiltered (file, "%02x", buf[i]); - break; - default: - internal_error (__FILE__, __LINE__, _("Bad switch")); - } -} - enum regcache_dump_what { regcache_dump_none, regcache_dump_raw, @@ -1258,10 +1238,9 @@ regcache_dump (struct regcache *regcache, struct ui_file *file, else { regcache_raw_read (regcache, regnum, buf); - fprintf_unfiltered (file, "0x"); - dump_endian_bytes (file, - gdbarch_byte_order (gdbarch), buf, - regcache->descr->sizeof_register[regnum]); + print_hex_chars (file, buf, + regcache->descr->sizeof_register[regnum], + gdbarch_byte_order (gdbarch)); } } @@ -1280,12 +1259,9 @@ regcache_dump (struct regcache *regcache, struct ui_file *file, else if (status == REG_UNAVAILABLE) fprintf_unfiltered (file, ""); else - { - fprintf_unfiltered (file, "0x"); - dump_endian_bytes (file, - gdbarch_byte_order (gdbarch), buf, - regcache->descr->sizeof_register[regnum]); - } + print_hex_chars (file, buf, + regcache->descr->sizeof_register[regnum], + gdbarch_byte_order (gdbarch)); } }