From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6447 invoked by alias); 3 Sep 2013 06:33:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6437 invoked by uid 89); 3 Sep 2013 06:33:14 -0000 Received: from mga09.intel.com (HELO mga09.intel.com) (134.134.136.24) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 03 Sep 2013 06:33:14 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,MIME_BASE64_BLANKS,RDNS_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mga09.intel.com Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 02 Sep 2013 23:30:15 -0700 X-ExtLoop1: 1 Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by orsmga001.jf.intel.com with ESMTP; 02 Sep 2013 23:32:30 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.64]) by IRSMSX104.ger.corp.intel.com ([169.254.5.157]) with mapi id 14.03.0123.003; Tue, 3 Sep 2013 07:32:29 +0100 From: "Agovic, Sanimir" To: 'Yao Qi' CC: "gdb-patches@sourceware.org" Subject: RE: [RFC 3/3] Test on solib load and unload Date: Tue, 03 Sep 2013 06:33:00 -0000 Message-ID: <0377C58828D86C4588AEEC42FC3B85A71766B1EC@IRSMSX105.ger.corp.intel.com> References: <520B7F70.6070207@codesourcery.com> <1377663394-4975-1-git-send-email-yao@codesourcery.com> <1377663394-4975-4-git-send-email-yao@codesourcery.com> <521D7BCA.10806@codesourcery.com> <0377C58828D86C4588AEEC42FC3B85A717658713@IRSMSX105.ger.corp.intel.com> <52254252.9050503@codesourcery.com> In-Reply-To: <52254252.9050503@codesourcery.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg00058.txt.bz2 PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBZYW8gUWkg W21haWx0bzp5YW9AY29kZXNvdXJjZXJ5LmNvbV0NCj4gU2VudDogVHVlc2Rh eSwgU2VwdGVtYmVyIDAzLCAyMDEzIDAzOjU5IEFNDQo+IFRvOiBBZ292aWMs IFNhbmltaXINCj4gQ2M6IGdkYi1wYXRjaGVzQHNvdXJjZXdhcmUub3JnDQo+ IFN1YmplY3Q6IFJlOiBbUkZDIDMvM10gVGVzdCBvbiBzb2xpYiBsb2FkIGFu ZCB1bmxvYWQNCj4gDQo+IE9uIDA4LzI4LzIwMTMgMDc6MzEgUE0sIEFnb3Zp YywgU2FuaW1pciB3cm90ZToNCj4gPj4gKyAgZm9yIChpID0gMDsgaSA8IG51 bWJlcjsgaSsrKQ0KPiA+PiA+KyAgICB7DQo+ID4+ID4rICAgICAgY2hhciBm dW5uYW1lWzIwXTsNCj4gPj4gPisgICAgICB2b2lkICpwOw0KPiA+PiA+Kw0K PiA+PiA+KyAgICAgIHNwcmludGYgKGZ1bm5hbWUsICJzaHIlZCIsIGkpOw0K PiA+PiA+KyAgICAgIHAgPSBkbHN5bSAoaGFuZGxlc1tpXSwgZnVubmFtZSk7 DQo+ID4+ID4NCj4gPiBEb2VzIGRsc3ltIGhhcyBhbnkgcGVyZiBpbXBhY3Qg b24gdGhlIGRlYnVnZ2VyPw0KPiA+DQo+IA0KPiBQcm9iYWJseSBubyBtdWNo IHBlcmZvcm1hbmNlIGltcGFjdCBvbiB0aGUgZGVidWdnZXIsIElNTy4gIGRs c3ltIGlzIHRvDQo+IHJlc29sdmUgc3ltYm9sIGluIHJ1bnRpbWUsIGRlYnVn Z2VyIGlzIG5vdCBtdWNoIGludm9sdmVkLg0KPg0KV2l0aG91dCBpbXBhY3Qv c2lkZS1lZmZlY3QgSWBkIHJhdGhlciByZW1vdmUgaXQsIGdpdmVuIHRoYXQg dGhpcyBpcyBhDQpOT1AgZm9yIHRoZSBkZWJ1Z2dlci4gQnV0IHRoaXMgaXMg bm90aGluZyBJYG0gd29ycmllZCBhYm91dC4NCg0KPiA+PiA+Kw0KPiA+PiA+ K2dkYl90ZXN0X25vX291dHB1dCAicHl0aG9uIFNvbGliTG9hZFVubG9hZFwo JFNPTElCX05VTUJFUlwpIg0KPiA+PiA+Kw0KPiA+PiA+KyMgQ2FsbCB0aGUg Y29udmVuaWVuY2UgZnVuY3Rpb24gcmVnaXN0ZXJlZCBieSBweXRob24gc2Ny aXB0Lg0KPiA+PiA+K3NlbmRfZ2RiICJjYWxsIFwkcGVyZnRlc3QoKVxuIg0K PiA+PiA+DQo+ID4gTm90IHN1cmUgaWYgYSBjb252ZW5pZW5jZSBmdW5jdGlv biBpcyBuZWNlc3Nhcnk6DQo+ID4gcHl0aG9uIFNvbGliTG9hZFVubG9hZCgp LmV4ZWN1dGVfdGVzdCgpDQo+ID4gY291bGQgZG8gdGhlIGpvYiBhcyB3ZWxs Lg0KPiA+DQo+IA0KPiBDb252ZW5pZW5jZSBmdW5jdGlvbiBpcyB1c2VmdWwg dG8gZGUtY291cGxlIHNvbGliLnB5IGFuZCBzb2xpYi5leHAuDQo+IHNvbGli LnB5IGFkZHMgYSBjb252ZW5pZW5jZSBmdW5jdGlvbiwgd2hpbGUgc29saWIu ZXhwIGlzIHRvIGNhbGwgaXQuDQo+IA0KR290IGl0Lg0KDQo+ID4+ID4rDQo+ ID4+ID4rICAgICAgICAgICAgc3RhcnRfdGltZSA9IHRpbWUuY2xvY2soKQ0K PiA+PiA+KyAgICAgICAgICAgIGdkYi5leGVjdXRlIChkb190ZXN0X2NvbW1h bmQpDQo+ID4+ID4rICAgICAgICAgICAgZWxhcHNlZF90aW1lID0gdGltZS5j bG9jaygpIC0gc3RhcnRfdGltZQ0KPiA+PiA+Kw0KPiA+PiA+KyAgICAgICAg ICAgIHNlbGYucmVzdWx0LnJlY29yZCAobnVtLCBlbGFwc2VkX3RpbWUpDQo+ ID4+ID4rDQo+ID4+ID4rICAgICAgICAgICAgbnVtID0gbnVtIC8gMg0KPiA+ PiA+KyAgICAgICAgICAgIGl0ZXJhdGlvbiAtPSAxDQo+ID4+ID4NCj4gPiBZ b3UgbWF5IGNvbnNpZGVyIG9ic2VydmluZyBzb2xpYnMgbG9hZHMvdW5sb2Fk cyB0byBjb21wdXRlIHRoZSB0aW1lDQo+ID4gYmV0d2VlbiB0aGUgZXZlbnRz Lg0KPiA+IENhbiB5b3UgcmUtcnVuIHRoZSBzYW1wbGUgd2l0aCB0dXJuZWQg b2ZmIGdhcmJhZ2UgY29sbGVjdG9yPyBJdCBtYXkNCj4gPiBjYXVzZSBzb21l IGppdHRlciBpZiB0dXJuZWQgb24uDQo+IA0KPiBJIGRvbid0IGtub3cgaG93 IG11Y2ggdGltZSBpcyBzcGVudCBvbiBqaXR0ZXIsIGJ1dCBweXRob24gY29k ZSBpcw0KPiBzaW1wbGUgYW5kIG1vc3Qgb2YgdGhlIHRpbWUgc2hvdWxkIGJl IHNwZW50IG9uIEdEQiwgd2hpY2ggaXMgd2hhdCB3ZQ0KPiB3YW50LiAgVGhh bmtzIGZvciB5b3VyIHN1Z2dlc3Rpb24uICBJJ2xsIHJlLXJ1biBpdCB3aXRo IGdjIHR1cm5lZCBvZmYsDQo+IHRvIHNlZSBpZiBJIGNhbiBnZXQgc29tZXRo aW5nIGRpZmZlcmVudC4NCj4gDQpUaGFua3MuDQoNCiAtU2FuaW1pcg0KSW50 ZWwgR21iSApEb3JuYWNoZXIgU3RyYXNzZSAxCjg1NjIyIEZlbGRraXJjaGVu L011ZW5jaGVuLCBEZXV0c2NobGFuZApTaXR6IGRlciBHZXNlbGxzY2hhZnQ6 IEZlbGRraXJjaGVuIGJlaSBNdWVuY2hlbgpHZXNjaGFlZnRzZnVlaHJlcjog Q2hyaXN0aWFuIExhbXByZWNodGVyLCBIYW5uZXMgU2Nod2FkZXJlciwgRG91 Z2xhcyBMdXNrClJlZ2lzdGVyZ2VyaWNodDogTXVlbmNoZW4gSFJCIDQ3NDU2 ClVzdC4tSWROci4vVkFUIFJlZ2lzdHJhdGlvbiBOby46IERFMTI5Mzg1ODk1 CkNpdGliYW5rIEZyYW5rZnVydCBhLk0uIChCTFogNTAyIDEwOSAwMCkgNjAw MTE5MDUyCg== >From gdb-patches-return-104914-listarch-gdb-patches=sources.redhat.com@sourceware.org Tue Sep 03 06:37:12 2013 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 9248 invoked by alias); 3 Sep 2013 06:37:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 9232 invoked by uid 89); 3 Sep 2013 06:37:12 -0000 Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 03 Sep 2013 06:37:12 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: smtp.gentoo.org Received: from localhost.localdomain (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 73F3533E976 for ; Tue, 3 Sep 2013 06:37:09 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: [PATCH] gdb: btrace: fix build errors on older glibc builds Date: Tue, 03 Sep 2013 06:37:00 -0000 Message-Id: <1378190232-13873-1-git-send-email-vapier@gentoo.org> X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg00059.txt.bz2 Content-length: 1539 It is possible to have a build of glibc where SYS_perf_event_open is not defined (because when the glibc was compiled, the syscall did not exist), but have newer kernel headers installed so that linux/perf_event.h is available. In this setup, you get a build failure: ./common/linux-btrace.c: In function 'kernel_supports_btrace': ./common/linux-btrace.c:316:23: error: 'SYS_perf_event_open' undeclared (first use in this function) Update the ifdef check to also see if the syscall is available. URL: https://bugs.gentoo.org/473522 Reported-by: William Throwe Signed-off-by: Mike Frysinger 2013-09-03 Mike Frysinger * common/linux-btrace.c: Move sys/syscall.h out of the HAVE_LINUX_PERF_EVENT_H check and wrap it inHAVE_SYS_SYSCALL_H. Also check for SYS_perf_event_open before attempting to buid. --- gdb/common/linux-btrace.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/gdb/common/linux-btrace.c b/gdb/common/linux-btrace.c index b874c84..7e20745 100644 --- a/gdb/common/linux-btrace.c +++ b/gdb/common/linux-btrace.c @@ -33,13 +33,16 @@ #include "gdb_wait.h" #include "i386-cpuid.h" -#if HAVE_LINUX_PERF_EVENT_H +#ifdef HAVE_SYS_SYSCALL_H +#include +#endif + +#if HAVE_LINUX_PERF_EVENT_H && defined(SYS_perf_event_open) #include #include #include #include -#include #include #include #include -- 1.8.3.2