From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24294 invoked by alias); 28 Aug 2013 09:40:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24266 invoked by uid 89); 28 Aug 2013 09:40:23 -0000 Received: from mga03.intel.com (HELO mga03.intel.com) (143.182.124.21) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 28 Aug 2013 09:40:23 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RDNS_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mga03.intel.com Received: from azsmga002.ch.intel.com ([10.2.17.35]) by azsmga101.ch.intel.com with ESMTP; 28 Aug 2013 02:40:18 -0700 X-ExtLoop1: 1 Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by AZSMGA002.ch.intel.com with ESMTP; 28 Aug 2013 02:39:51 -0700 Received: from irsmsx106.ger.corp.intel.com (163.33.3.31) by IRSMSX103.ger.corp.intel.com (163.33.3.157) with Microsoft SMTP Server (TLS) id 14.3.123.3; Wed, 28 Aug 2013 10:39:48 +0100 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.64]) by IRSMSX106.ger.corp.intel.com ([169.254.8.233]) with mapi id 14.03.0123.003; Wed, 28 Aug 2013 10:39:49 +0100 From: "Agovic, Sanimir" To: 'Yao Qi' , "gdb-patches@sourceware.org" Subject: RE: [RFC 1/3] New make target 'check-perf' and new dir gdb.perf Date: Wed, 28 Aug 2013 09:40:00 -0000 Message-ID: <0377C58828D86C4588AEEC42FC3B85A717658623@IRSMSX105.ger.corp.intel.com> References: <520B7F70.6070207@codesourcery.com> <1377663394-4975-1-git-send-email-yao@codesourcery.com> <1377663394-4975-2-git-send-email-yao@codesourcery.com> In-Reply-To: <1377663394-4975-2-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2013-08/txt/msg00814.txt.bz2 lgtm, however I cannot approve your patch. Minor comment below. -Sanimir > -----Original Message----- > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-owner@sourcewa= re.org] On Behalf > Of Yao Qi > Sent: Wednesday, August 28, 2013 06:17 AM > To: gdb-patches@sourceware.org > Subject: [RFC 1/3] New make target 'check-perf' and new dir gdb.perf >=20 > diff --git a/gdb/testsuite/Makefile.in b/gdb/testsuite/Makefile.in > index a7b3d5c..34590de 100644 > --- a/gdb/testsuite/Makefile.in > +++ b/gdb/testsuite/Makefile.in > @@ -151,13 +151,18 @@ DO_RUNTEST =3D \ > export TCL_LIBRARY ; fi ; \ > $(RUNTEST) >=20 > +# A list of all directories named "gdb.*" which also hold a .exp file. > +# We filter out gdb.perf because it contains performance testing cases, > +# and we don't want to run them together with other regression tests. > +# They should be run separately by 'make check-perf'. > +TEST_SRC_DIRS =3D $(filter-out gdb.perf,$(sort $(notdir $(patsubst %/,%,= $(dir $(wildcard > $(srcdir)/gdb.*/*.exp)))))) > + > check-single: all $(abs_builddir)/site.exp > - $(DO_RUNTEST) $(RUNTESTFLAGS) > + $(DO_RUNTEST) --directory=3D"$(TEST_SRC_DIRS)" $(RUNTESTFLAGS) >=20 > -# A list of all directories named "gdb.*" which also hold a .exp file. > # We filter out gdb.base and add fake entries, because that directory > # takes the longest to process, and so we split it in half. > -TEST_DIRS =3D gdb.base1 gdb.base2 $(filter-out gdb.base,$(sort $(notdir = $(patsubst > %/,%,$(dir $(wildcard $(srcdir)/gdb.*/*.exp)))))) > +TEST_DIRS =3D gdb.base1 gdb.base2 $(filter-out gdb.base ,$(TEST_SRC_DIRS= )) > You added whitespace after gdb.base.....................^ -Sanimir Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052