From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28948 invoked by alias); 26 Aug 2013 14:03:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28939 invoked by uid 89); 26 Aug 2013 14:03:21 -0000 Received: from mga14.intel.com (HELO mga14.intel.com) (143.182.124.37) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 26 Aug 2013 14:03:21 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RDNS_NONE,WEIRD_PORT autolearn=no version=3.3.2 X-HELO: mga14.intel.com Received: from azsmga002.ch.intel.com ([10.2.17.35]) by azsmga102.ch.intel.com with ESMTP; 26 Aug 2013 07:03:12 -0700 X-ExtLoop1: 1 Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by AZSMGA002.ch.intel.com with ESMTP; 26 Aug 2013 07:03:11 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.64]) by IRSMSX104.ger.corp.intel.com ([169.254.5.157]) with mapi id 14.03.0123.003; Mon, 26 Aug 2013 15:01:58 +0100 From: "Agovic, Sanimir" To: 'Will Newton' , "gdb-patches@sourceware.org" CC: "patches@linaro.org" Subject: RE: [PATCH] common/linux-ptrace.c: Fix build on non-Intel architectures. Date: Mon, 26 Aug 2013 14:03:00 -0000 Message-ID: <0377C58828D86C4588AEEC42FC3B85A71764E043@IRSMSX105.ger.corp.intel.com> References: <52190AAD.2050901@linaro.org> In-Reply-To: <52190AAD.2050901@linaro.org> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2013-08/txt/msg00740.txt.bz2 Hello Will, I run your fix via buildbot[1] and now all builds are green again, thus it = lgtm. However I cannot approve your patch. [1] http://gcc20.fsffrance.org:9010/waterfall -Sanimir > -----Original Message----- > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-owner@sourcewa= re.org] On Behalf > Of Will Newton > Sent: Saturday, August 24, 2013 09:34 PM > To: gdb-patches@sourceware.org > Cc: patches@linaro.org > Subject: [PATCH] common/linux-ptrace.c: Fix build on non-Intel architectu= res. >=20 >=20 > As uintptr_t is used stdint.h must be included on all architectures. >=20 > 2013-08-24 Will Newton >=20 > * common/linux-ptrace.c: Include stdint.h unconditionally. > --- > gdb/common/linux-ptrace.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/gdb/common/linux-ptrace.c b/gdb/common/linux-ptrace.c > index a4a2ca3..3a8e25e 100644 > --- a/gdb/common/linux-ptrace.c > +++ b/gdb/common/linux-ptrace.c > @@ -30,6 +30,8 @@ > #include "gdb_assert.h" > #include "gdb_wait.h" >=20 > +#include > + > /* Stores the currently supported ptrace options. A value of > -1 means we did not check for features yet. A value of 0 means > there are no supported features. */ > @@ -64,7 +66,6 @@ extern void (linux_ptrace_test_ret_to_nx_instr) (void); > #include > #include > #include > -#include >=20 > #endif /* defined __i386__ || defined __x86_64__ */ >=20 > -- > 1.8.1.4 Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052