From: "Agovic, Sanimir" <sanimir.agovic@intel.com>
To: 'Tom Tromey' <tromey@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: [PATCH 1/2] cleanup: rename is_ref_attr to attr_form_is_ref
Date: Tue, 23 Jul 2013 14:10:00 -0000 [thread overview]
Message-ID: <0377C58828D86C4588AEEC42FC3B85A71763AE22@IRSMSX105.ger.corp.intel.com> (raw)
In-Reply-To: <8761w14c02.fsf@fleche.redhat.com>
2013-07-24 Sanimir Agovic <sanimir.agovic@intel.com>
* dwarf2read.c (attr_is_ref): Rename to attr_form_is_ref.
All uses updated.
(attr_form_is_ref): Move below attr_form_is_constant.
OK?
-Sanimir
> -----Original Message-----
> From: Tom Tromey [mailto:tromey@redhat.com]
> Sent: Tuesday, July 23, 2013 03:55 PM
> To: Agovic, Sanimir
> Cc: gdb-patches@sourceware.org
> Subject: Re: [PATCH 1/2] cleanup: rename is_ref_attr to attr_form_is_ref
>
> >>>>> "Sanimir" == Sanimir Agovic <sanimir.agovic@intel.com> writes:
>
> Sanimir> 2013-07-24 Sanimir Agovic <sanimir.agovi@intel.com>
>
> Sanimir> * dwarf2read.c (attr_is_ref): Rename to attr_form_is_ref.
> Sanimir> All uses updated.
>
> The patch is ok.
> I think the ChangeLog should mention that the function moved.
>
> thanks,
> Tom
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052
next prev parent reply other threads:[~2013-07-23 14:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 11:03 [PATCH 0/2] Minor dwarf2read cleanups Sanimir Agovic
2013-07-23 11:03 ` [PATCH 1/2] cleanup: rename is_ref_attr to attr_form_is_ref Sanimir Agovic
2013-07-23 13:55 ` Tom Tromey
2013-07-23 14:10 ` Agovic, Sanimir [this message]
2013-07-23 14:32 ` Tom Tromey
2013-07-23 11:03 ` [PATCH 2/2] cleanup: constify argument passed to dwarf form predicates Sanimir Agovic
2013-07-23 13:53 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0377C58828D86C4588AEEC42FC3B85A71763AE22@IRSMSX105.ger.corp.intel.com \
--to=sanimir.agovic@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox