From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 7X7ZMT00CWntLx4AWB0awg (envelope-from ) for ; Mon, 03 Nov 2025 18:01:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1762210877; bh=NUjgMZBHJmPdgaHTGjHzjsCWxmF+fZBYTuY+mBr+mCM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=DAcrbjFvpbf5fG9giE+YmccUkZ3D+rXPGFFTIQwHbDIIVht2PbEidNKBt1LAECdmb +FA+qruvXo3OcVAU2dZFguE+UpxfMoTyrffFEtmA78N5aA6rjciZZF6dDQMOi4cggg tbWd8gJkoUSvczch9ReoXWr7uTwQeuXy1l8lGxK4= Received: by simark.ca (Postfix, from userid 112) id B9B1A1E0BC; Mon, 03 Nov 2025 18:01:17 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=YG34TfZy; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A16B61E04C for ; Mon, 03 Nov 2025 18:01:13 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 462353858429 for ; Mon, 3 Nov 2025 23:01:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 462353858429 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=YG34TfZy Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 12AD2385840E; Mon, 3 Nov 2025 22:59:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 12AD2385840E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 12AD2385840E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1762210789; cv=none; b=K+y93CTpZ2djMDE+bEeQBDoT8LgTVzt75scN0bKmLDlsPNGdv3tD0nb7XlVj73j3QDt3SZmNqOShK0MLl6aKpQV+2lN1Q2Gf08cnt0ZBArsCEo84+atvyfpbndidbt6V1Ldund2xc7lh0g9RiQjzaX7He9OA4ekAwsjVYQZwWwY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1762210789; c=relaxed/simple; bh=NUjgMZBHJmPdgaHTGjHzjsCWxmF+fZBYTuY+mBr+mCM=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=NqvpkE4i1rUHrCfnRl/Ys8NdTTJRi8P/yuCelmVyiGSsZVFCDXhutEf5yaK9Z6R84BTe0x+u5q6+N1Ei8lNAp+wdakPTiPVPWOjYpefsiaLiJAI7dXFrQ1pJ2zhsvvI95mzOqRGDZeHC+LnuhBrHKfeiwDi3Wp9XYZfHzTbqhFg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 12AD2385840E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1762210788; bh=NUjgMZBHJmPdgaHTGjHzjsCWxmF+fZBYTuY+mBr+mCM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=YG34TfZy5PVmEdoWVko6ByxA6yBwwHEBC0dcrEs6K92842KtKWyzqCeEhT4KfVNh3 U/f6UDjWAW0idYIyXGRUY8B2/f9MIOK2SgZrPjhnbHMGPdIdF/B9x1+xFov0rG5LSn EqApa5a1BXKPqQvSEIE02hCpLJMCU81FSOxwvS4w= Received: by simark.ca (Postfix) id 334391E04C; Mon, 03 Nov 2025 17:59:48 -0500 (EST) Message-ID: <03732666-279b-4b21-a23f-165dd04fc99d@simark.ca> Date: Mon, 3 Nov 2025 17:59:47 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESEND] gdb/hppa: guess g packet size To: Sven Schnelle , Tom Tromey Cc: gdb-patches@sourceware.org, Helge Deller , John David Anglin , binutils@sourceware.org References: <20251101080538.857188-1-svens@stackframe.org> <87seeuak0z.fsf@tromey.com> <87tszapzhx.fsf@stackframe.org> Content-Language: en-US From: Simon Marchi In-Reply-To: <87tszapzhx.fsf@stackframe.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2025-11-03 16:39, Sven Schnelle wrote: > Tom Tromey writes: > >>>>>>> "Sven" == Sven Schnelle writes: >> >> Sven> With qemu supporting 64 bit now, add some code to determine the >> Sven> register size of a hppa remote target. >> >> Thanks for the patch. >> >> Sven> +struct target_desc *hppa_tdesc32; >> Sven> +struct target_desc *hppa_tdesc64; >> >> These should be 'static'. They can also just be objects, not pointers, >> I think. > >> Sven> + hppa_tdesc32 = allocate_target_description ().release (); >> Sven> + set_tdesc_property (hppa_tdesc32, PROPERTY_GP32, ""); >> Sven> + >> Sven> + hppa_tdesc64 = allocate_target_description ().release (); >> Sven> + set_tdesc_property (hppa_tdesc64, PROPERTY_GP64, ""); >> >> The reason I suggested using objects and not pointers is that, although >> we do have a number of calls to .release() in gdb, we somewhat try to >> avoid them. > > I might of course be wrong because i don't know the code well, but > struct target_desc is declared in target-description.c and in the > tdep file it's only used as opaque type. So it can't be used as object > because the size isn't known. Is this correct, or am i misreading the > code? It seems you're right. My suggestion would perhaps be to make the global (well, static) objects of type `target_desc_up`, you won't need the release then. Simon