From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29167 invoked by alias); 24 May 2011 15:11:26 -0000 Received: (qmail 29156 invoked by uid 22791); 24 May 2011 15:11:25 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,TW_FN X-Spam-Check-By: sourceware.org Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (194.98.77.210) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 24 May 2011 15:11:11 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id BC80ECB0253; Tue, 24 May 2011 17:11:09 +0200 (CEST) Received: from mel.act-europe.fr ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wZr+UCA6J1MO; Tue, 24 May 2011 17:11:06 +0200 (CEST) Received: from ulanbator.act-europe.fr (ulanbator.act-europe.fr [10.10.1.67]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mel.act-europe.fr (Postfix) with ESMTP id BF700CB028D; Tue, 24 May 2011 17:11:06 +0200 (CEST) Subject: Re: [PATCH 3/4] aix: add support for dwarf2. Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Tristan Gingold In-Reply-To: Date: Tue, 24 May 2011 15:11:00 -0000 Cc: gdb-patches@sourceware.org Content-Transfer-Encoding: 7bit Message-Id: <0369C729-8C0F-40FB-BC93-DA6B83F442C7@adacore.com> References: <1306146544-3925-1-git-send-email-gingold@adacore.com> <1306146544-3925-4-git-send-email-gingold@adacore.com> <5EE240AB-A6C1-4925-92D2-E0C0BCFCC43B@adacore.com> To: Tom Tromey X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00570.txt.bz2 On May 24, 2011, at 4:55 PM, Tom Tromey wrote: >>>>>> "Tristan" == Tristan Gingold writes: > > Tom> In which case it seems like xcoffread.c should have a second > Tom> struct sym_fns, with a NULL entry for this method. > > Tristan> But how would that work ? find_sym_fns finds the sym_fns > Tristan> struct according to the bfd flavour, and there is only one > Tristan> xcoff flavour. > > You can change the pointer to an unregistered sym_fns. > See how elfread.c handles this. Thank you for the pointer. > I don't actually know anything about XCOFF or xcoffread.c. > If you think your current approach is safe enough, I am ok with it. Well, I think it is safe enough, but I'd prefer to clarify the point. Let me think about that a little bit. Tristan.