From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 97631 invoked by alias); 23 Nov 2017 22:40:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 97584 invoked by uid 89); 23 Nov 2017 22:40:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=our, among X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 Nov 2017 22:40:38 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9850F4E4F3; Thu, 23 Nov 2017 22:40:36 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id AD2D360BE1; Thu, 23 Nov 2017 22:40:35 +0000 (UTC) Subject: Re: [RFA] C++-ify parse_format_string To: Simon Marchi , Tom Tromey , gdb-patches@sourceware.org References: <20171123164631.11055-1-tom@tromey.com> From: Pedro Alves Message-ID: <0350cb5f-d176-76c4-11e8-5ffb3fe8c84d@redhat.com> Date: Thu, 23 Nov 2017 22:40:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-11/txt/msg00581.txt.bz2 On 11/23/2017 09:13 PM, Simon Marchi wrote: > I have a patch in some branch that does essentially the same thing, so > I was able to compare our approaches. In my version, I removed the > big allocation that is shared among pieces, and made each piece have > its own std::string. Unless we want to keep the current allocation > scheme for performance/memory usage reasons, I think that using > std::strings simplifies things in the parse_format_string function. > The format_pieces structure is replaced with an std::vector of > format_piece. Sounds like a step backwards to me. If it simplifies things, then it sounds like it might be because we're missing some utility, like string_view or something like that. Thanks, Pedro Alves