From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5855 invoked by alias); 27 May 2003 14:22:25 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5786 invoked from network); 27 May 2003 14:22:23 -0000 Received: from unknown (HELO harris.CNS.cwru.edu) (129.22.104.63) by sources.redhat.com with SMTP; 27 May 2003 14:22:23 -0000 Registered-mail-reply-requested-by: chet@po.cwru.edu Received: from nike.ins.cwru.edu (nike.INS.CWRU.Edu [129.22.8.219]) by smtp-a.cwru.edu (iPlanet Messaging Server 5.2 Patch 1 (built Aug 19 2002)) with SMTP id <0HFJ00E45ULB5S@smtp-a.cwru.edu> for gdb-patches@sources.redhat.com; Tue, 27 May 2003 10:22:23 -0400 (EDT) Date: Tue, 27 May 2003 14:22:00 -0000 From: Chet Ramey Subject: Re: Fix readline for platforms without In-reply-to: <"Message from kettenis"@chello.nl> To: kettenis@chello.nl Cc: gdb-patches@sources.redhat.com, ezannoni@redhat.com, chet@cwru.edu Reply-to: chet@cwru.edu Message-id: <030527141412.AA74998.SM@nike.ins.cwru.edu> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7BIT References: <200305251129.h4PBTfrV010272@elgar.kettenis.dyndns.org> X-SW-Source: 2003-05/txt/msg00496.txt.bz2 > [ Chet, I don't now if you ever received the change that was > origionally made to the copy of readline in the GDB tree. Just in > case you intend to incorporate such a change in the next release of > readline, this patch solves a problem with it. ] > > There is a problem with one of our local GDB fixes for readline: I'm not going to include wcwidth in libreadline. It's not appropriate for libraries to be conditionally including C library functions -- it just causes problems down the line. That's what the calling application should be doing. That said, your fix was better than changing the source, since I don't see how wcwidth is going to work without wchar.h anyway. Chet -- ``The lyf so short, the craft so long to lerne.'' - Chaucer ( ``Discere est Dolere'' -- chet ) Chet Ramey, ITS, CWRU chet@po.CWRU.Edu http://cnswww.cns.cwru.edu/~chet/