From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qJoLBxOvj2eLbRYAWB0awg (envelope-from ) for ; Tue, 21 Jan 2025 09:28:35 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=bBaDXsmY; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=3o6/nQX5; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ZuniK769; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=CrZsQJn2; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 143D31E100; Tue, 21 Jan 2025 09:28:35 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 592F41E08E for ; Tue, 21 Jan 2025 09:28:34 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E74CF385700A for ; Tue, 21 Jan 2025 14:28:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E74CF385700A Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=bBaDXsmY; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=3o6/nQX5; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ZuniK769; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=CrZsQJn2 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id E849E3857727 for ; Tue, 21 Jan 2025 14:28:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E849E3857727 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E849E3857727 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737469682; cv=none; b=jY1h0Z1exDw1r1Cin5WxJ1Zfhdgx+fkxCFm2M2gUv5pC3weO4XWJ9b1ewAmdncsqhD47jFJ0Ny4hDOmaHrVr4mS6s5pWwroDlEcIm8UXDcpgBiLDAgiFJcf3saHjFgbqF3x+8KY5yEb5Dmr8Ta58W0u4VvPVaShC/aEpuFp++sY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737469682; c=relaxed/simple; bh=hrtsRn3ZFhgoyUtd03qsK/cVqVg0uKeyiNYYJUt9Apk=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:From:To; b=h9B3xSoXvBnyoCFIp+X0/CD5EzXRnI9UIv0Ux1WclBcABUn+so3BMI40chxhSxKBM69nMEndU3x3LGpjs/ze+ol1jGj0nv848FMc4aSZtV97aHTfeHXGF0c7IdC2l2Y7EhB3LBOpiOnSzPqAM670muTzYxzMH1IqOOxBgPvfWDc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E849E3857727 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id EECC11F385 for ; Tue, 21 Jan 2025 14:28:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1737469681; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s0qUQDvN+OSQTfkiyYKY3EW057X6ZSLqPOeViRjV9Pw=; b=bBaDXsmYYLiOY5z0imdWjAEgKE/5HINwqI7vg06HkxzPKabHbqkhkPwRHCsQ3ohiLsLzRi ghvVsuWjML4EMgYTk4d3Qrd3Sfu+HaGwgyV8XGVho68WQNBNUJtn4C8wo2ZBHz2uITItvv 6ETkM8nKXyIhTCnTAGKTndjA1I8eSGk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1737469681; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s0qUQDvN+OSQTfkiyYKY3EW057X6ZSLqPOeViRjV9Pw=; b=3o6/nQX5HYruvWLeYvVGBAI1cqXIwHYZBuEt1E60wmBoxfEPaMUOpcA1/YgxbEsL2ciNvS kbB0gn29G/SjO8DQ== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1737469680; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s0qUQDvN+OSQTfkiyYKY3EW057X6ZSLqPOeViRjV9Pw=; b=ZuniK7698ecAFTH/fzP1p6VODGznsO2er3d8cbtifrs3ZuMEB/n58B5ZsShtGBJCVXuPRo oGpbztCDz1gVNq1bUtdMkKPE7urJaZEt/QzSPMXt2ArLWEIRlTQtyyWOlycxlaZtrUk0hO HOzG/jztCBDr7/kcZGaFZJbHTfkGfXs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1737469680; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s0qUQDvN+OSQTfkiyYKY3EW057X6ZSLqPOeViRjV9Pw=; b=CrZsQJn2voq7tnmDnvfeiqtcexaKW92mbIhdNolnrmZUvlN6GbWQ0p5mEuN0zjxWpFFqeY 3YGPHxYYk6R0sXDg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id DA6FD13963 for ; Tue, 21 Jan 2025 14:28:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id vt6hM/Cuj2fTKwAAD6G6ig (envelope-from ) for ; Tue, 21 Jan 2025 14:28:00 +0000 Message-ID: <02ba3ebe-bc58-4c81-a006-60a555bc1d11@suse.de> Date: Tue, 21 Jan 2025 15:28:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PING][PATCH 09/11] [gdb/macros] Fix gdb.base/fission-macro.exp with clang From: Tom de Vries To: gdb-patches@sourceware.org References: <20240521154415.9543-1-tdevries@suse.de> <20240521154415.9543-9-tdevries@suse.de> Content-Language: en-US In-Reply-To: <20240521154415.9543-9-tdevries@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 5/21/24 17:44, Tom de Vries wrote: > When running test-case gdb.base/fission-macro.exp with clang, we run into: > ... > (gdb) info macro FIFTH^M > Defined at $build/gdb/testsuite/:18^M > included at $src/gdb/testsuite/gdb.base/fission-macro.c:21^M > (gdb) FAIL: gdb.base/fission-macro.exp: dwarf_version=4: dwarf_bits=32: \ > strict_dwarf=0: info macro FIFTH > ... > > This is caused by the fact that the .debug_macros.dwo section refers to the > .debug_line.dwo section, but the .debug_line section is used instead. > > Fix this by making sure the .debug_line.dwo section is used. > Ping. Thanks, - Tom > PR macros/31750 > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31750 > --- > gdb/dwarf2/read.c | 16 ++++++++++++++++ > gdb/testsuite/gdb.base/fission-macro.exp | 6 ++++-- > 2 files changed, 20 insertions(+), 2 deletions(-) > > diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c > index 6a489502f8b..b742f38c303 100644 > --- a/gdb/dwarf2/read.c > +++ b/gdb/dwarf2/read.c > @@ -21224,6 +21224,7 @@ dwarf_decode_macros (struct dwarf2_cu *cu, unsigned int offset, > struct dwarf2_section_info *section; > const char *section_name; > > + line_header_up lh_up; > if (cu->dwo_unit != nullptr) > { > if (section_is_gnu) > @@ -21236,6 +21237,21 @@ dwarf_decode_macros (struct dwarf2_cu *cu, unsigned int offset, > section = &cu->dwo_unit->dwo_file->sections.macinfo; > section_name = ".debug_macinfo.dwo"; > } > + > + { > + struct dwarf2_section_info *line_section; > + > + line_section = &cu->dwo_unit->dwo_file->sections.line; > + line_section->read (per_objfile->objfile); > + if (line_section->buffer == NULL) > + { > + complaint (_("missing .debug_line.dwo section")); > + return; > + } > + lh_up = dwarf_decode_line_header ((sect_offset)0, 0, per_objfile, > + line_section, &cu->header, nullptr); > + lh = lh_up.get (); > + } > } > else > { > diff --git a/gdb/testsuite/gdb.base/fission-macro.exp b/gdb/testsuite/gdb.base/fission-macro.exp > index 5474baf21d5..de1ce7d3823 100644 > --- a/gdb/testsuite/gdb.base/fission-macro.exp > +++ b/gdb/testsuite/gdb.base/fission-macro.exp > @@ -13,8 +13,10 @@ > # You should have received a copy of the GNU General Public License > # along with this program. If not, see . */ > > -# Gcc 14 is the first release containing the fix for PR debug/111409. > -require {expr [gcc_major_version] >= 14} > +if { [test_compiler_info "gcc-*"] } { > + # Gcc 14 is the first release containing the fix for PR debug/111409. > + require {expr [gcc_major_version] >= 14} > +} > > standard_testfile .c -2.c .h >