From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128352 invoked by alias); 24 Aug 2016 15:33:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 128092 invoked by uid 89); 24 Aug 2016 15:33:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=online X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 24 Aug 2016 15:33:13 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 62CEC4E4DE; Wed, 24 Aug 2016 15:33:12 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u7OFXBqb006798; Wed, 24 Aug 2016 11:33:11 -0400 Subject: Re: [PATCH] Allow resetting an empty inferior-tty To: Simon Marchi , gdb-patches@sourceware.org References: <20160824144548.19204-1-simon.marchi@ericsson.com> From: Pedro Alves Message-ID: <02a660a4-13e9-d741-577a-0aaef7c196ae@redhat.com> Date: Wed, 24 Aug 2016 15:33:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <20160824144548.19204-1-simon.marchi@ericsson.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-08/txt/msg00246.txt.bz2 On 08/24/2016 03:45 PM, Simon Marchi wrote: > This patch allows the user to set the inferior-tty to "empty", in order > to come back to the default behaviour of using the same tty as gdb is > using. LGTM. A couple nits below. > diff --git a/gdb/infcmd.c b/gdb/infcmd.c > index 58ba1cb..97a1e35 100644 > --- a/gdb/infcmd.c > +++ b/gdb/infcmd.c > @@ -151,7 +151,11 @@ void > set_inferior_io_terminal (const char *terminal_name) > { > xfree (current_inferior ()->terminal); > - current_inferior ()->terminal = terminal_name ? xstrdup (terminal_name) : 0; > + > + if (terminal_name != NULL && strlen (terminal_name) > 0) Use th idiomatic empty-string check: *terminal_name != '\0' > /* Add the filename of the terminal connected to inferior I/O. */ > - add_setshow_filename_cmd ("inferior-tty", class_run, > - &inferior_io_terminal_scratch, _("\ > + add_setshow_optional_filename_cmd ("inferior-tty", class_run, > + &inferior_io_terminal_scratch, _("\ > Set terminal for future runs of program being debugged."), _("\ > Show terminal for future runs of program being debugged."), _("\ > Usage: set inferior-tty /dev/pts/1"), Should we update the online help too? Thanks, Pedro Alves