From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 64142 invoked by alias); 9 Mar 2018 19:11:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 64133 invoked by uid 89); 9 Mar 2018 19:11:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=terminology X-HELO: EUR01-VE1-obe.outbound.protection.outlook.com Received: from mail-ve1eur01on0040.outbound.protection.outlook.com (HELO EUR01-VE1-obe.outbound.protection.outlook.com) (104.47.1.40) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 09 Mar 2018 19:11:37 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com (10.160.211.19) by AM3PR08MB0005.eurprd08.prod.outlook.com (10.160.236.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.567.14; Fri, 9 Mar 2018 19:11:32 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::fc60:4b4d:7de8:f8b7]) by AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::fc60:4b4d:7de8:f8b7%16]) with mapi id 15.20.0548.018; Fri, 9 Mar 2018 19:11:31 +0000 From: Alan Hayward To: Joel Brobecker , Pedro Alves , Yao Qi CC: "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH PR gdb/22736] [aarch64] gdb crashes on a conditional breakpoint with cast return type Date: Fri, 09 Mar 2018 19:11:00 -0000 Message-ID: <02E52921-0454-445A-AB05-D6D1FD6BDE34@arm.com> References: <20180302033204.v2wvjmquwy3dswyk@adacore.com> <20180302151824.dg4y23pwjmm6nqjb@adacore.com> <18C9D0DE-F18B-4F88-91F3-826208369A64@arm.com> <31749295-0d7e-11ab-8e13-e25a070c6595@redhat.com> <20180309085122.v4fzh4vcii5plkkk@adacore.com> In-Reply-To: <20180309085122.v4fzh4vcii5plkkk@adacore.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;AM3PR08MB0005;7:7t1gcUn4HMvY+qITZ6RtI5/53Iv+BzsjzdhX8Aq3TTBwPOYcch3neC3oSKIAp1DgAfNTkZcYF8rZv7EGlkFzSttYQPgN/MdaeeQZok9zaDPxUJLxfiePKLHcwpdF9sfgX/iXdKOO4+fGgmLlSLWsQrQVeYa4+b68uK2pzRWQUanwWi/eDP28MoxaxpXp1C0imAkOXc/lyJM//+I+R+7sX5HqTCVGqoZpeNo5A+UL/Fc2WEppjWag/ptFZ6BLk9ZH x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 65825aab-62ae-45ec-475a-08d585f19178 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020);SRVR:AM3PR08MB0005; x-ms-traffictypediagnostic: AM3PR08MB0005: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(85827821059158); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231220)(944501244)(52105095)(3002001)(10201501046)(6055026)(6041310)(20161123564045)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(6072148)(201708071742011);SRVR:AM3PR08MB0005;BCL:0;PCL:0;RULEID:;SRVR:AM3PR08MB0005; x-forefront-prvs: 0606BBEB39 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(979002)(366004)(346002)(39380400002)(396003)(39860400002)(376002)(189003)(199004)(6486002)(54906003)(86362001)(93886005)(99286004)(2950100002)(2906002)(81156014)(76176011)(8936002)(6116002)(81166006)(3280700002)(2900100001)(8676002)(33656002)(14454004)(3846002)(110136005)(316002)(4326008)(53936002)(6512007)(39060400002)(5250100002)(106356001)(478600001)(6436002)(72206003)(97736004)(6246003)(82746002)(36756003)(229853002)(25786009)(53546011)(305945005)(66066001)(6506007)(26005)(83716003)(5660300001)(3660700001)(68736007)(7736002)(105586002)(186003)(102836004)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1101;SCL:1;SRVR:AM3PR08MB0005;H:AM3PR08MB0101.eurprd08.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:3;A:3;LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: zMgmZM6qNJ2ZRlMMwj9kF/8PVfVUXxeKtMFavXmbWi1ciQecti2f46UCWvogmbSw10PDIw9yFzbVWwLgIQSv4N2EutzXkcyh5WQVvrS7bue3v150dAFwrHZ/eSVjEXmivCGeHR82vSR0jfr+9YcDQQbj1ppzp9qCceR1sY8vY6CNgy17GUBEXvvUKBv9fX3RjmMMA4mlR0v6yjniZkRgapvZmw9ReI52sLifZH8rodTGr4iaVQtoec8C/q29DyP3G5XTKPWQ1qE2QL+zCcLV3nXu3AV0DABh3J3nNyK+J830nvOpmfArpUGLSmcBcZ3x1P1GeqzUszvfJRBfh9/0bQ== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <1169561C49ADDB498639DE699C6823D3@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 65825aab-62ae-45ec-475a-08d585f19178 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Mar 2018 19:11:31.5109 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR08MB0005 X-IsSubscribed: yes X-SW-Source: 2018-03/txt/msg00203.txt.bz2 DQoNCj4gT24gOSBNYXIgMjAxOCwgYXQgMDg6NTEsIEpvZWwgQnJvYmVja2Vy IDxicm9iZWNrZXJAYWRhY29yZS5jb20+IHdyb3RlOg0KPiANCj4gSGVsbG8g QWxhbiwNCj4gDQo+PiBUaGUgdGFyZ2V0IHR5cGUgZm9yIHRoZSAqZnVuY3Rp b24gaXMgc2V0IHRvIHRoZSB0eXBlIG9mIHRoZSBmdW5jdGlvbg0KPj4gcG9p bnRlciwgbm90IHRoZSByZXR1cm4gdHlwZS4gIFNvLCBmb3IgSUZVTkMsIFRZ UEVfQ09ERV9GVU5DIHRhcmdldCB0eXBlDQo+PiBpcyBUWVBFX0NPREVfSU5U IHdoaWNoIGdpdmVzIHRoZSB0eXBlIG9mIHRoZSBmdW5jdGlvbiBwb2ludGVy LiBGb3IgdGhlDQo+PiBGVU5DLCB0aGVyZSBpcyBubyBwb2ludGVyLCBzbyB0 aGUgdGFyZ2V0IHR5cGUgb2YgVFlQRV9DT0RFX0ZVTkMgaXMgc2V0DQo+PiB0 byBudWxsLiBUaGF0IG1ha2VzIHNlbnNlIHRvIG1lLCBidXQgaXNu4oCZdCBp bW1lZGlhdGVseSBvYnZpb3VzLg0KPiANCj4gSSBkb24ndCByZWFsbHkgdW5k ZXJzdGFuZCB3aGF0IHlvdSBtZWFuIGJ5IHRoYXQgLS0gbWF5YmUgaXQgaXMg cmVsYXRlZA0KPiB0byB0aGUgJyonIGJlZm9yZSAnZnVuY3Rpb24nIGFib3Zl PyBJZiB3ZSdyZSB0YWxraW5nIGFib3V0IHRoZQ0KPiB0YXJnZXRfdHlwZSBm b3IgdGhlIGZ1bmN0aW9uLCBpdCBzaG91bGQgYmUgdGhlIHR5cGUgb2YgdGhl IHJldHVybiB2YWx1ZS4NCj4gQXQgbGVhc3QgYWNjb3JkaW5nIHRvIHRoZSBk b2N1bWVudGF0aW9uIGZvciB0aGF0IGZpZWxkIGluIGdkYl90eXBlcy5oLg0K PiBCdXQgbWF5YmUgeW91J3JlIHRhbGtpbmcgYWJvdXQgc29tZXRoaW5nIGVs c2U/DQoNCkFncmVlZCB0aGF0IHRoZSBkb2N1bWVudGF0aW9uIHNheXMg4oCc dHlwZeKAnSBzaG91bGQgY29udGFpbiB0aGUgdHlwZSBvZiB0aGUNCmZ1bmN0 aW9uIHJldHVybi4NCg0KSeKAmW0gbm90IHF1aXRlIHN1cmUgb24gdGhlIHRl cm1pbm9sb2d5IGhlcmUsIGJ1dCwgd2hhdCB0aGUgZ2RiIGNvZGUgaXMgcGlj a2luZw0KdXAgYW5kIHBsYWNpbmcgaW50byB0eXBlIGlzIHRoZSB0eXBlIG9m IHRoZSBmdW5jdGlvbiBlbnRyeSBpbiB0aGUgZWxmIGZpbGUuDQpUaGUgY29k ZSBpbiBmaW5kX21pbnN5bV90eXBlX2FuZF9hZGRyZXNzKCkgZW5zdXJlcyB0 aGF0IGEgRlVOQyB3aWxsIGFsd2F5cw0KaGF2ZSB0aGUgdHlwZSBub2RlYnVn X3RleHRfZ251X2lmdW5jX3N5bWJvbCBhbmQgYW4gSUZVTkMgd2lsbCBhbHdh eXMgaGF2ZQ0KdGhlIHR5cGUgbm9kZWJ1Z190ZXh0X3N5bWJvbC4gIFRoaXMg aXMgY29tcGxldGVseSB1bnJlbGF0ZWQgdG8gdGhlIHJldHVybiB0eXBlDQpv ZiB0aGUgZnVuY3Rpb24sIHdoaWNoIGlzIG9ubHkgcmVzb2x2ZWQgbXVjaCBs YXRlciBpbiBjYWxsX2Z1bmN0aW9uX2J5X2hhbmRfZHVtbXkoKS4NCg0KSW4g YW4gaWRlYWwgd29ybGQsIG1heWJlIHRoZSBjb21tb24gY29kZSBuZWVkcyBh IGJpdCBvZiBhIHJld3JpdGU6DQpUaGUgZnVuY3Rpb24gc3RydWN0dXJlIG5l ZWRzIHRvIGNvbnRhaW4gYm90aCB0aGUgdHlwZSBvZiB0aGUgZWxmIGVudHJ5 IGFuZCB0aGUNCnR5cGUgb2YgdGhlIHJldHVybiB2YWx1ZS4gQnV0LCB0aGUg ZXhpc3RpbmcgdmFsdWUqIGFuZCBmdW5jdGlvbiogc3RydWN0dXJlcyBkb27i gJl0DQpyZWFsbHkgc3VwcG9ydCBhZGRpbmcgZXh0cmEgZmllbGRzLiBJIHdh c27igJl0IHJlYWxseSBjb21mb3J0YWJsZSBlbm91Z2ggd2lsbCB0aGlzIHBh cnQNCm9mIHRoZSBjb2RlIHRvIG1lZGRsZSB3aXRoIHRoYXQuDQoNCkhhcHB5 IHdpdGggdGhlIG90aGVyIGNvbW1lbnRzIHRvby4gVGhhbmtzIQ0KDQoNCj4g T24gOSBNYXIgMjAxOCwgYXQgMTY6MDQsIFBlZHJvIEFsdmVzIDxwYWx2ZXNA cmVkaGF0LmNvbT4gd3JvdGU6DQo+IA0KPiBTb3JyeSBmb3IgdGhlIGNvbnN0 YW50IGRlbGF5cyB0aGUgcGFzdCBjb3VwbGUgd2Vla3MuICBJJ3ZlIGJlZW4g Z2V0dGluZw0KPiBkaXN0cmFjdGVkIGJ5IG90aGVyIHRoaW5ncyBtb3JlIHRo YW4gdXN1YWwuICBUb2RheSBJJ20gdHJ5aW5nIHRvIGZpbmlzaC9wb3N0DQo+ IHRoZSBpZnVuYy1maXhpbmcgc2VyaWVzIEkgcG9pbnRlZCBhdCBlYXJsaWVy LCBhbmQgaG9wZWZ1bGx5IHRoYXQgd2lsbCBnaXZlDQo+IG1lIGVub3VnaCBi YWNrZ3JvdW5kIHRvIHVuZGVyc3RhbmQvcmV2aWV3IHRoaXMgcGF0Y2ggKEkn bSBhZnJhaWQgSSBoYXZlbid0DQo+IHJlYWxseSBsb29rZWQgYXQgaXQgaW4g YW55IGRldGFpbCkuDQo+IA0KDQpPaywgaGFwcHkgdG8gd2FpdCB1bnRpbCB5 b3UgaGF2ZSBzb21lIHRpbWUuIEnigJltIGxvb2tpbmcgYXQgcHIvMjI5NDMg d2hpY2ggYWxzbw0KbWlnaHQgaGVscCB3aXRoIG15IHVuZGVyc3RhbmRpbmcg b2YgdGhpcyBvbmUgYSBsaXR0bGUgbW9yZS4NCg0KPiANCj4gT24gOSBNYXIg MjAxOCwgYXQgMTY6NDQsIFlhbyBRaSA8cWl5YW9sdGNAZ21haWwuY29tPiB3 cm90ZToNCj4gDQo+IEZXSVcsIHRoaXMgaXNzdWUgaXMgKm5vdCogcmVsYXRl ZCB0byBpZnVuYy4gIEFzIEFsYW4gZGVzY3JpYmVkIGluDQo+IHByZXZpb3Vz IGVtYWlsLCBpZnVuYyBzeW1ib2wgaXMgT0ssIGJ1dCBub3JtYWwgZnVuY3Rp b24gc3ltYm9sJ3MgdGFyZ2V0DQo+IHR5cGUgaXMgTlVMTCwgYmVjYXVzZSB3 aXRob3V0IGRlYnVnIGluZm9ybWF0aW9uLCBHREIgZG9lc24ndCBrbm93IHRo ZQ0KPiBzeW1ib2wgaXMgYSBmdW5jdGlvbiBvciBub3QuICBJIHRob3VnaHQg YWJvdXQgaXQsIGJ1dCBJIGFtIG5vdCBjb25maWRlbnQNCj4gdGhhdCB3ZSBj YW4gc2V0IHN5bWJvbCdzIHRhcmdldCB0eXBlIChmb3IgZXhhbXBsZSwgc2V0 IGl0IHZvaWQgb3IgaW50KQ0KPiBpbiBhYnNlbnQgb2YgZGVidWcgaW5mb3Jt YXRpb24uDQo+IA0KDQpJ4oCZZCBqdXN0IGFkZCB0aGF0IGV2ZW4gd2l0aCBJ RlVOQyB0aGUgdHlwZSB3aWxsIGFsd2F5cyBiZSBzZXQgdG8gYSBwb2ludGVy IHRvIGFuDQpJbnQsIHJlZ2FyZGxlc3Mgb2YgdGhlIHJldHVybiB0eXBlIG9m IHRoZSBmdW5jdGlvbi4NCg0KDQoNCg0KQWxhbi4NCg0K >From gdb-patches-return-145875-listarch-gdb-patches=sources.redhat.com@sourceware.org Fri Mar 09 20:05:59 2018 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 82324 invoked by alias); 9 Mar 2018 20:05:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 82315 invoked by uid 89); 9 Mar 2018 20:05:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=HContent-Transfer-Encoding:8bit X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 09 Mar 2018 20:05:57 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DDBBEBD9E; Fri, 9 Mar 2018 20:05:55 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 74E829457E; Fri, 9 Mar 2018 20:05:54 +0000 (UTC) Subject: Re: [PATCH PR gdb/22736] [aarch64] gdb crashes on a conditional breakpoint with cast return type To: Alan Hayward , Joel Brobecker , Yao Qi References: <20180302033204.v2wvjmquwy3dswyk@adacore.com> <20180302151824.dg4y23pwjmm6nqjb@adacore.com> <18C9D0DE-F18B-4F88-91F3-826208369A64@arm.com> <31749295-0d7e-11ab-8e13-e25a070c6595@redhat.com> <20180309085122.v4fzh4vcii5plkkk@adacore.com> <02E52921-0454-445A-AB05-D6D1FD6BDE34@arm.com> Cc: "gdb-patches@sourceware.org" , nd From: Pedro Alves Message-ID: <50d58845-c928-1c49-2cd2-cf3e9778f051@redhat.com> Date: Fri, 09 Mar 2018 20:05:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <02E52921-0454-445A-AB05-D6D1FD6BDE34@arm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2018-03/txt/msg00204.txt.bz2 Content-length: 1034 On 03/09/2018 07:11 PM, Alan Hayward wrote: >> On 9 Mar 2018, at 16:44, Yao Qi wrote: >> >> FWIW, this issue is *not* related to ifunc. As Alan described in >> previous email, ifunc symbol is OK, but normal function symbol's target >> type is NULL, because without debug information, GDB doesn't know the >> symbol is a function or not. I thought about it, but I am not confident >> that we can set symbol's target type (for example, set it void or int) >> in absent of debug information. >> And how are we calling a function if we don't know its return type? GDB won't let you, unless you add the cast. And then the question is, why are we losing the cast-to type then? _That_ should the be return type used, it sounds to me (but I still haven't reviewed in detail :-/ ). > > I’d just add that even with IFUNC the type will always be set to a pointer to an > Int, regardless of the return type of the function. Actually, I've changed that today in my series. /me almost done... Thanks, Pedro Alves