From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id G0+mCt6NzmlaJwQAWB0awg (envelope-from ) for ; Thu, 02 Apr 2026 11:40:14 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=CXXX4NUl; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 162391E0BC; Thu, 02 Apr 2026 11:40:14 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3AB411E04F for ; Thu, 02 Apr 2026 11:40:13 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 833914BAD150 for ; Thu, 2 Apr 2026 15:40:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 833914BAD150 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=CXXX4NUl Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 279834BA23DB for ; Thu, 2 Apr 2026 15:38:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 279834BA23DB Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 279834BA23DB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775144327; cv=none; b=VbRnEwqv+49T3m379ZnN1XJKOpEXvthCvU1m3yy6PA30AmkphB6C7j5fy3PAMGYjhSl8mNjPnI9fNKoh1Urllq/ZuQQ+t5mqOaT4dFYBzMeqU61bcFoYOHtocN6R5UuWIZZd+u/ycX0OHGrQeoudSHKiT7DK5L/9FLIk2dlPK94= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775144327; c=relaxed/simple; bh=BwHcnk3wvI4hkgvMNaiy9qkgZBEJ8mZIEEnFNR1MEew=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=dfbT+O2qYB1NPLOyCkRRIQCk1YJ2HFAHp1SNM/yLpE2Pg154ZmL/z+jtzTAlXeY2F1ijfonTTI+oeI3A6q3BfrHKg0GAqS7VVckjqtVP9qKyVUeoY21ZIMaUcsOwnl3WaRt86IZQ51jCUbGe9LTTt7Ilv0dMQ+OwlazBmWCJ7f4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 279834BA23DB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775144326; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e5TdEjwWjOT+CxiFP66k27VeZG8ZT1+Rk1uKYVU8qgg=; b=CXXX4NUlfQ4XDIFtKNxjWeDHxh375tT7QAEaLVKiRg8RisHx2ybdAqoy+4HFfow/8SNIKY MHZhuqCDnF3c4qDGzTO7NeqbQ4DPCwbnhZ4uIeowuuiHptHUFBkrdfFVMZCXs1r7YBbGHL S+6efKQcjc/8YOErIG17uYiKag0tGJY= Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-64-n-bLewMbORyvIv6kVxKgHQ-1; Thu, 02 Apr 2026 11:38:45 -0400 X-MC-Unique: n-bLewMbORyvIv6kVxKgHQ-1 X-Mimecast-MFC-AGG-ID: n-bLewMbORyvIv6kVxKgHQ_1775144325 Received: by mail-ua1-f69.google.com with SMTP id a1e0cc1a2514c-9484dbd65a7so326313241.1 for ; Thu, 02 Apr 2026 08:38:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775144324; x=1775749124; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=e5TdEjwWjOT+CxiFP66k27VeZG8ZT1+Rk1uKYVU8qgg=; b=lOj1Gv+RVIhOgWkKgumzgXvjl4BiSzQjG1drKY7JSi3fqwUdX9PLcyuvr9fPymjcAs JfPne+oWRRYA/xMp6M4S22u2qj1kvAD4YYJdpHp+qbybFJeqtFtu4igdJgyVypuaB/gb xhD3bGeuYs6lbSoiFJsJgMx3qPytSKFikuJ4Z8ObmYM9TDJ/NZEnpz9CqktWSGZZtCeV d5EqVJe21GpxWiChPFD5RacazX5kSkROcMG+A2UkJrmStNB8Uu2t2Eo80rvo2Hc31ZM8 +vriyPvHgu6b2yivNR+mnqQkVa/glMfTD1OnI+HZ7LmxxC+gQDJJoQpmcxFTzaVXzLHm Zwxg== X-Forwarded-Encrypted: i=1; AJvYcCWqeulXg/TlYbXs2s6x7Em5smu2Ooim7ImzbwW5JO+FP2du/j9HMHUdwIYQMdNtKw2hmZ7dD3otRhH1Xw==@sourceware.org X-Gm-Message-State: AOJu0YzvftorcwlW0Nh5r2bSm8l/qS6eOn62qRjFtUzFDRcdaMiuVnG7 0b3K6bIfy6syetEzp6gADPUyoYCc63dNRJt0uZAlpLOBGsOQUslKt9M+XxcrOJvXvSFy3ucUdJY AYezflGpoql/zILh1jk4VQvH1K3J30ga0vxZDRDr6HX+iMpmF2Rq9ERuZiEOBsz4uPW0iZU4= X-Gm-Gg: ATEYQzwbvh3BIA4If/t7FSdkE+f3pXNJcVaKGPWauC3952tOtqGYXXGSZeMkaG6Zp5O pRHKgW87rBJkn6SBkYoquRtZ4miqi8OtWLr2iPccimOczcbiqwoX09SHvxnf/bNnfFHW7rgTkn6 NrKZjpRH16J5KE6taEpZNX8plVy+heWXLkcc8ZFZBLAcmH2fstKE0yLU8YDAXn+NGz+IjKa7Q+U RxTiOxOe710wx7/05ZwcXIbc1gfhM57UfeQbQdJJUs/utOS/86DMLAcWBSMhoKXnW92c2N4COUI 3Kf+TvIb7gCtdHsAM9uEZvLmmXy5NFHZQB4X5bP6+dH929tn0Vt6UGF3hN9YidmW78AAUgsshGT e9c8FszOMMP71gF4IfiHR4ctS+3h0N5w= X-Received: by 2002:ac5:c0cc:0:b0:56a:f979:a9d1 with SMTP id 71dfb90a1353d-56d8a7b7a16mr2571498e0c.1.1775144324598; Thu, 02 Apr 2026 08:38:44 -0700 (PDT) X-Received: by 2002:ac5:c0cc:0:b0:56a:f979:a9d1 with SMTP id 71dfb90a1353d-56d8a7b7a16mr2571489e0c.1.1775144324097; Thu, 02 Apr 2026 08:38:44 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:993e::75d? ([2804:14d:8084:993e::75d]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-56d9bd2106csm3601966e0c.18.2026.04.02.08.38.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Apr 2026 08:38:43 -0700 (PDT) Message-ID: <026a283c-60be-4391-8a01-1b932d2dbc5c@redhat.com> Date: Thu, 2 Apr 2026 12:38:38 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/2] [gdb] Enable ptype /o for some dynamic types To: Tom de Vries , gdb-patches@sourceware.org References: <20260311115506.3101288-1-tdevries@suse.de> From: Guinevere Larsen In-Reply-To: <20260311115506.3101288-1-tdevries@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: k50IRVhmxTsrwps6FPR2D-0qmcLPfW4B3UPMIdr8sJc_1775144325 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 3/11/26 8:55 AM, Tom de Vries wrote: > This patch series fixes PR33966. > > The first patch refactors is_dynamic_types_internal. > > The second patch contains the fix. > > Tested on x86_64-linux. > > Changes in v2: > - committed the first patch of v1 > - updated the first patch to not expose the top_level parameter in > is_dynamic_types > - updated the second patch by: > - hoisting a check > - moving the tests to a new testcase gdb.base/ptype-offsets-c.exp > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=33966 > > Tom de Vries (2): > [gdb] Factor out is_dynamic_type_internal_1 > [gdb] Enable ptype /o for some dynamic types > > gdb/gdbtypes.c | 68 ++++++++++++++++++---- > gdb/gdbtypes.h | 4 ++ > gdb/testsuite/gdb.ada/ptype-o.exp | 2 +- > gdb/testsuite/gdb.base/ptype-offsets-c.c | 37 ++++++++++++ > gdb/testsuite/gdb.base/ptype-offsets-c.exp | 63 ++++++++++++++++++++ > gdb/typeprint.c | 4 +- > 6 files changed, 163 insertions(+), 15 deletions(-) > create mode 100644 gdb/testsuite/gdb.base/ptype-offsets-c.c > create mode 100644 gdb/testsuite/gdb.base/ptype-offsets-c.exp > > > base-commit: fe97d7c31d7e81eec11243e269139a08632d085f Hi Tom! I took a look at this, and I don't see anything that raises an eyebrow, and it fixes the test, so Reviewed-By: Guinevere Larsen -- Cheers, Guinevere Larsen It/she