From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6130 invoked by alias); 19 Sep 2019 11:05:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6120 invoked by uid 89); 19 Sep 2019 11:05:55 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Sep 2019 11:05:54 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 26FE01E4B2; Thu, 19 Sep 2019 07:05:53 -0400 (EDT) Subject: Re: [PATCH] Move declaration of overload_resolution to value.h To: Christian Biesinger , gdb-patches@sourceware.org References: <20190919044248.47444-1-cbiesinger@google.com> From: Simon Marchi Message-ID: <025164e3-12a1-7591-dd9d-c7d20552cb94@simark.ca> Date: Thu, 19 Sep 2019 11:05:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.0 MIME-Version: 1.0 In-Reply-To: <20190919044248.47444-1-cbiesinger@google.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-09/txt/msg00363.txt.bz2 On 2019-09-19 12:42 a.m., Christian Biesinger via gdb-patches wrote: > The variable is defined in valops.c and has an extern decl in > eval.c; move it to the header file. LGTM, thanks for doing these changes. Simon