From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 108141 invoked by alias); 25 Oct 2017 07:11:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 106904 invoked by uid 89); 25 Oct 2017 07:11:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=H*UA:iPhone, H*x:iPhone, iPhone, Hx-languages-length:1219 X-HELO: mail-wm0-f65.google.com Received: from mail-wm0-f65.google.com (HELO mail-wm0-f65.google.com) (74.125.82.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 25 Oct 2017 07:11:32 +0000 Received: by mail-wm0-f65.google.com with SMTP id u138so19781542wmu.5 for ; Wed, 25 Oct 2017 00:11:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=5VPtIe8v6yX0MZFAHzZvojW8CGTpJiaylMkn4rxNAag=; b=lvqVb5bRQrq5WE37ldLY95I9QLWeo4hYpqeg0zzQD1q94DG32gWV8weFRABUOpsjtV s+Ww1whjXJJQqMzgy2E599M9kDJaZAObpE44FbT++2qEsTmv1zpgwd7A6ivZVbdCZBK5 5iJYGrwUHCLzMLvHvjbnXqC3YA7CwyOKSMoxggOfLnuLAFtCAk4K4/KWj/TZ4l+bVZMv 8J3qSY/CKUSH1IahEwjBIY2AfbLij7zZf8oFjcFdPXIVo1lxwySTDq3BKl2uQOmTYH5Y SA1dY7I8O0DrpOPyRoKMZUVPcS5vm7QkaLCfwEd9z6iCaqQmeCI0gw+LmKtAOTaGqGBc oUxA== X-Gm-Message-State: AMCzsaXlBBP+S7kTfNfXssvPMUfqKZhNGz4a2I1PkFhN5mrUr8CA9m0f mMM2nLxXqzv4BesthuZ9nxJmFEe2 X-Google-Smtp-Source: ABhQp+RoI4KQest7TIePzDlcPANUZBBPZhYSVec7f8w3upsIx6LEAS+zs544tSxJVa6yWN6b5yQJOA== X-Received: by 10.80.206.84 with SMTP id k20mr23233844edj.145.1508915490632; Wed, 25 Oct 2017 00:11:30 -0700 (PDT) Received: from [192.168.81.41] (D4B2608A.static.ziggozakelijk.nl. [212.178.96.138]) by smtp.gmail.com with ESMTPSA id f27sm1208404edj.82.2017.10.25.00.11.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Oct 2017 00:11:30 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (1.0) Subject: Re: [PATCH] Fix broken recursion detection when printing static members From: osscontribute In-Reply-To: Date: Wed, 25 Oct 2017 07:11:00 -0000 Cc: gdb-patches@sourceware.org Content-Transfer-Encoding: quoted-printable Message-Id: <0231F3F4-6D2F-4203-84CB-09032CDEA8D1@gmail.com> References: <20171024105535.13287-1-osscontribute@gmail.com> To: Simon Marchi X-SW-Source: 2017-10/txt/msg00757.txt.bz2 I merged the test into test_static_members() in classes.exp. Patch has been= submitted. Thanks Verstuurd vanaf mijn iPhone > Op 25 okt. 2017 om 04:23 heeft Simon Marchi het= volgende geschreven: >=20 >> On 2017-10-24 06:55, Patrick Frants wrote: >> The fix shrinks the stack using obstack_blank_fast() with a negative >> value as described at the bottom of this page: >> https://gcc.gnu.org/onlinedocs/libiberty/Extra-Fast-Growing.html >> "You can use obstack_blank_fast with a =E2=80=9Cnegative=E2=80=9D size a= rgument to >> make the current object smaller. Just don=E2=80=99t try to shrink it bey= ond >> zero length=E2=80=94there=E2=80=99s no telling what will happen if you d= o that. >> Earlier versions of obstacks allowed you to use obstack_blank to >> shrink objects. This will no longer work." >> A unit test (gdb.cp/printstaticrecursion.exp) was added. No new >> regression has been observed in testsuite/gdb.cp/*.exp. >=20 > As mentioned in my last review, did you have a chance to see look if it w= as possible to improve the existing test about recursive static fields in g= db.cp/classes.exp, rather than introducing a new one? >=20 > Thanks, >=20 > Simon