From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id aLiNAVKrd2Ny7hkAWB0awg (envelope-from ) for ; Fri, 18 Nov 2022 10:57:06 -0500 Received: by simark.ca (Postfix, from userid 112) id 043571E124; Fri, 18 Nov 2022 10:57:06 -0500 (EST) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=aRRHEUEc; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_MED,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B16C71E0CB for ; Fri, 18 Nov 2022 10:57:05 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 22F2E385841C for ; Fri, 18 Nov 2022 15:57:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 22F2E385841C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1668787025; bh=0qFK2uA/OrJ7LxzxxlNa9/MNdWfe9yxPmdoEyFAAlto=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=aRRHEUEcAgrS+Idze0PxfCz/lu2uIGl9N0UL+8qC4l1jUhkwK9817OL80ZggYMysf T2U/A4B8R8o9kemJl2aFBiYJe5UY7EHrIJ51yeITXBpMiuYTRfebBmf4nXGwMaYktL 9YHkY4lhUZcr6bYL7Ae8vo/nYqZvBXLCid067/4U= Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 26D0B385457F for ; Fri, 18 Nov 2022 15:56:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 26D0B385457F Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 955C71E0CB; Fri, 18 Nov 2022 10:56:42 -0500 (EST) Message-ID: <02243db7-df98-47f6-40a0-3f774ccf9e8f@simark.ca> Date: Fri, 18 Nov 2022 10:56:42 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v4] [PR python/18655] Fix deletion of FinishBreakpoints Content-Language: en-US To: Johnson Sun , BrunoLarsen , gdb-patches@sourceware.org References: <20221020173411.190318-1-j3.soon777@gmail.com> <20221020174917.192860-1-j3.soon777@gmail.com> In-Reply-To: <20221020174917.192860-1-j3.soon777@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 10/20/22 13:49, Johnson Sun wrote: > Currently, FinishBreakpoints are set at the return address of a frame based on > the `finish' command, and are meant to be temporary breakpoints. However, they > are not being cleaned up after use, as reported in PR python/18655. This was > happening because the disposition of the breakpoint was not being set > correctly. > > This commit fixes this issue by correctly setting the disposition in the > post-stop hook of the breakpoint. It also adds a test to ensure this feature > isn't regressed in the future. > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=18655 Thanks, I see your copyright assignment is complete. I pushed the patch. Simon