From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KlF+FmnXb2hSrzAAWB0awg (envelope-from ) for ; Thu, 10 Jul 2025 11:08:25 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ABJJ7gB1; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 37E411E11C; Thu, 10 Jul 2025 11:08:25 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_SBL_CSS,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 71F7F1E089 for ; Thu, 10 Jul 2025 11:08:24 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 03B7E3857BA2 for ; Thu, 10 Jul 2025 15:08:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 03B7E3857BA2 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ABJJ7gB1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id BA6013858C56 for ; Thu, 10 Jul 2025 15:07:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BA6013858C56 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BA6013858C56 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1752160073; cv=none; b=tsRiVyTiqPz5aInrDSfHJmgbfr5eO52M8Z//A+OLcmiQWwrPP/FSsVo/f5CXNXNsWFIKe6e9xpzlDXV4oWVTrqIfxd8e2X2bUNABwBMPu6/ZBBoz1MjMPVmwtW3ss8V6w0fAKUo6cwZr3lPDCQa2Y1bhwirkWVP5O0NNNaaQrh0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1752160073; c=relaxed/simple; bh=PH80hUDEjBkGpxYM5cTiBSsopSilDDYjDKx91S7sk60=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=a12pWYB4KFkrFhQakBj6x5rGIFzskCzmG39VUlyyb9X+zt+qJ6uDjL8vKkAuvJ8veMGl/TyCDNao5gb9vaA0vexvioQTF6MWUQjjEst9PQxYvTfDwt6MxboNY3ipqSN48ehRtR8JDLxdiekog26SzygNRXmwpaD1scsRxDdkY+Q= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BA6013858C56 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752160073; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FDEe5c8ESgdLAIvmtDCQmC2VsPvveWdzQUcncNWyJkU=; b=ABJJ7gB1LBJ44LLgASRp2e10FK0/B57/72oI9oUNmZAUcag/bT9zyGZr53iQU6uUON1QsT W608THiRGsNLvpY7KEDqK5JLpCeod0ylroA0YQmTZ85dLYp+3TVE4pckeDwHT49URxp4/f TDZ2pxnoshzU3gfhnw0KEfmJDdRZP2Y= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-599-ZKXvJostMbiKc9PMXbP0og-1; Thu, 10 Jul 2025 11:07:52 -0400 X-MC-Unique: ZKXvJostMbiKc9PMXbP0og-1 X-Mimecast-MFC-AGG-ID: ZKXvJostMbiKc9PMXbP0og_1752160072 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-6fad9167e4cso19872186d6.1 for ; Thu, 10 Jul 2025 08:07:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752160072; x=1752764872; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FDEe5c8ESgdLAIvmtDCQmC2VsPvveWdzQUcncNWyJkU=; b=w2hHc17f9aPaT8HZkGJmK4nfHLMhANO8pUzexNwXVBm3tPQUbRc/NRRmYp1pL3GbeY a3nz8YUzO2xPf0XedrnFwxOlnR905Lb4gRZ51crthrXUMYfHVBGCZVN5gX6LhwB4vuK5 Q0i8yKtGib7mQ4AwKpDtPrwfwzVj4wWURSqCK4X1kqhSGcqdqrkZ9wCL7TtDjwPuwBrc Qqa3i/PwMDFtJB0R96MBRHB3k6gSe0ihSfKTlfpLE4eneRBtaAbK5FnmT0d9gobU4Guq 4XeN9RmyncajH/6VJg4lkCnZJWp7NfYJB4CWkKsqXsHdWoDNWCx3kWbEOU9AdR6eUAOe xxTA== X-Gm-Message-State: AOJu0Yw3k7lZojAzmrKrXlv4ZVMvDeILn59cRdMgvFocEv34jf5iEkBv d5v2D5IhblnmPG12vmTbh+IBqPPJdKagJMmdOwo6sDbIzlobTiyV0OMh4NgTsE0RyVg3iyUz9Ra /g0CQc4lDdPYoBt/WOTQKtktyrxwyQSi2wn7IkcuLfa80yq9auGW19lU3oRlnBjo= X-Gm-Gg: ASbGncv5DO54M6sllUPF7lppofnqZHeiNg4MIOvSX4sqxEiw8NRN/0JDqRzVBLL83IL MLHigD5pQfKp+ponIakRAv9ShvOWAZfUQZUSTJMYQMEMnPpFwc04XujJH/02bUKP/BO5TmQzS21 ue18BEVJAfkzMSdGA0OZf+RcM9bcelA7Vd+7oPyotRRfYzdKRAtzQx8dNDRgmJ8laXFCMkxkNYQ iIDttthjjMudv2VIogLQdnZRpq5DPwAtiUcS7+hSLs8i4YCHPhgt/Kzx65JvQE9yOxjrV9yP1wO OnkIb9viYME42thUQ5Pw1GiMWTKosEDJVQ== X-Received: by 2002:ad4:5fc8:0:b0:702:b4d3:26b4 with SMTP id 6a1803df08f44-7049810ec05mr49150176d6.25.1752160071418; Thu, 10 Jul 2025 08:07:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEhqlPkWuEogvvIS5s/Je5U/VbV2/esnuHhL9A7ZTiWRMEIx+pfDfI4EvBO1tw5DVi7WdqIlg== X-Received: by 2002:ad4:5fc8:0:b0:702:b4d3:26b4 with SMTP id 6a1803df08f44-7049810ec05mr49149636d6.25.1752160070935; Thu, 10 Jul 2025 08:07:50 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:9a69::1001? ([2804:14d:8084:9a69::1001]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-704979e2f49sm9278256d6.42.2025.07.10.08.07.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Jul 2025 08:07:50 -0700 (PDT) Message-ID: <021778bb-0e9e-43f4-a462-d3b2bc3415dd@redhat.com> Date: Thu, 10 Jul 2025 12:07:48 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/3] gdb: extend the [[N]]::foo syntax for files To: Kevin Buettner Cc: gdb-patches@sourceware.org References: <20250619180540.2315103-1-guinevere@redhat.com> <20250619180540.2315103-4-guinevere@redhat.com> <20250709192729.099eca7d@f41-zbm-amd> From: Guinevere Larsen In-Reply-To: <20250709192729.099eca7d@f41-zbm-amd> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 0jGr3G_ZLDNKAosrKXdRkcNF7wIMpoICb1o1fMKuseY_1752160072 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 7/9/25 11:27 PM, Kevin Buettner wrote: > On Thu, 19 Jun 2025 15:05:40 -0300 > Guinevere Larsen wrote: > >> + gdb_test "print ${ns0}::'${::srcfile_lib}'::gdb_dlmopen_glob" \ >> + "No function .${::srcfile_lib}. in specified context." > I'm wondering about this test. ${::srcfile_lib} refers to a file, right? > If so, why does the message say "function"? This is an annoying case to work with... The error "No function %s in specified context" comes from the "block: block COLONCOLON name" rule, around line 1105 in my tree. The issue here is that the function "classify_name" couldn't find a file named ${::srcfile_lib} in the specified namespace, and so it classified that string as a generic name, rather than a file name. It's not even a factor of not having enough information to differentiate, the issue is that the name is miscategorized it would be impossible for us to even know when it was meant as a file or a function. At present, this error can only refer to a file if the user is searching for something in a namespace, so I could make that error checking slightly more thorough, and keep the current message when no namespace ID was used, and have a new "No function or file %s in specified context" message. Would that be better, in your opinion? -- Cheers, Guinevere Larsen She/Her/Hers