From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24171 invoked by alias); 28 Feb 2020 20:07:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24162 invoked by uid 89); 28 Feb 2020 20:07:39 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=H*f:sk:871rqeq, H*i:sk:871rqeq, H*MI:sk:871rqeq X-HELO: us-smtp-1.mimecast.com Received: from us-smtp-delivery-1.mimecast.com (HELO us-smtp-1.mimecast.com) (207.211.31.120) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Feb 2020 20:07:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582920457; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hmLnMG/tRWtUpaNqTwGTZhE0W5ogfKH5xWp4Ju9DsmA=; b=g6wVA31iLxsL+pL2n9N04rzphEwljywpKFDUzbbjFb/rT6n+6rF8N4rs+XEMMBLisziGJl 7IBrCOI7SqECMltYG3djsY5vOBm9xINt89So0fevxBbJx31abggp23803qz/1daRBsWFNV lJOvltxfpg5x6SWV9Lcc6HpaKrG3LPA= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-313-zcgy1IjbMf2RT01Un5ByOQ-1; Fri, 28 Feb 2020 15:07:35 -0500 Received: by mail-ed1-f70.google.com with SMTP id d21so3099886edy.3 for ; Fri, 28 Feb 2020 12:07:35 -0800 (PST) Return-Path: Received: from ?IPv6:2001:8a0:f909:7b00:56ee:75ff:fe8d:232b? ([2001:8a0:f909:7b00:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id ca3sm10821edb.95.2020.02.28.12.07.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Feb 2020 12:07:33 -0800 (PST) Subject: Re: [PATCH 1/6] Introduce scoped_pipe.h To: Sergio Durigan Junior References: <20190926042155.31481-1-sergiodj@redhat.com> <20200226200542.746617-1-sergiodj@redhat.com> <20200226200542.746617-2-sergiodj@redhat.com> <8051c51b-da71-68b7-877a-82322475a133@redhat.com> <871rqeqysr.fsf@redhat.com> Cc: GDB Patches , Tom Tromey , Eli Zaretskii , Ruslan Kabatsayev From: Pedro Alves Message-ID: <020a04b6-87c2-1394-cf09-7fba66c5daf5@redhat.com> Date: Fri, 28 Feb 2020 20:07:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <871rqeqysr.fsf@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2020-02/txt/msg01074.txt.bz2 On 2/28/20 7:47 PM, Sergio Durigan Junior wrote: > On Friday, February 28 2020, Pedro Alves wrote: > >> On 2/26/20 8:05 PM, Sergio Durigan Junior wrote: >> >>> --- /dev/null >>> +++ b/gdb/unittests/scoped_pipe-selftests.c >>> @@ -0,0 +1,96 @@ >> >>> + >>> +#include "defs.h" >>> + >>> +#include "gdbsupport/scoped_pipe.h" >>> +#include "config.h" >> >> Was there a reason for this "config.h" include? > > I copied this test from the existing scoped_fd-selftests.c and adjusted > it. I did remove other includes, but left this one untouched. I tried > removing it now, and the file builds just fine, so I'll update my copy > of the patch here. Thanks! Ah, I see. That config.h include shouldn't be there in scoped_fd-selftests.c either. Thanks, Pedro Alves