Re: [RFC][gdb/testsuite] Add -lbl option in gdb_test_multiple

Pedro Alves
2020-03-02T13:34:18Z

On 3/1/20 9:08 AM, Tom de Vries wrote:
> On 27-02-2020 17:02, Pedro Alves wrote:
>> Alternatively, if you don't like the -lbl within the {} block, and if
>> we're going to use "-" options, how about supporting them before
>> the {} user code block, so that the user code block is always
>> at the end? Like:
>>
>> gdb_test_multiple "command" "testname" -lbl {
>> ...
>> }
>>
>> gdb_test_multiple "command" "testname" -prompt $prompt_regexp {
>> ...
>> }
>>
>> That should be doable with:
>>
>> -proc gdb_test_multiple { command message user_code { prompt_regexp "" } } {
>> +proc gdb_test_multiple { command message args } {
>>
>> and then walking the $args list, processing "-" arguments, and interpreting
>> the first non-"-" argument as the user code block (and erroring out if there
>> are more arguments). I think the gdb_test_multiple code would look quite similar
>> to your patch, except that the user_code parameter would no longer be a parameter,
>> instead it would be a local variable set to the first non-"-" element of $args.
>
> Yes, I like that suggestion.
>
> Implemented and attached below.
>
> OK for trunk.

OK.

Thanks,
Pedro Alves