Re: [PATCH][gdb/testsuite] Fix corefile-buildid.exp with check-read1

Pedro Alves
2020-02-19T20:09:36Z

On 2/19/20 5:40 PM, Tom de Vries wrote:
> Hi,
>
> When running gdb.base/corefile-buildid.exp using check-read1, I run into:
> ...
> FAIL: gdb.base/corefile-buildid.exp: shared: info files (timeout)
> FAIL: gdb.base/corefile-buildid.exp: symlink shared: info files (timeout)
> FAIL: gdb.base/corefile-buildid.exp: shared sepdebug: info files (timeout)
> FAIL: gdb.base/corefile-buildid.exp: symlink shared sepdebug: info files \
> (timeout)
> ...
>
> This is caused by attempting to match the output of an "info files" command
> using a single gdb_test in check_exec_file.
>
> Fix this by doing line-by-line matching in check_exec_file.
>
> Tested on x86_64-linux, using make targets check and check-read1.
>
> OK for trunk?

OK.

If this pattern appears in more places it may be worth it to
think about some abstraction to make it easier to write.
Like e.g., a new "-lbl" (line-by-line) option switch to
gdb_test_multiple that auto-appends the "match one line" regexp.

Thanks,
Pedro Alves