From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 35048 invoked by alias); 25 Nov 2016 17:31:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 35029 invoked by uid 89); 25 Nov 2016 17:31:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=HX-PHP-Originating-Script:rcube.php, gave, eyes X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 25 Nov 2016 17:31:40 +0000 Received: by simark.ca (Postfix, from userid 33) id F34041E13C; Fri, 25 Nov 2016 12:31:37 -0500 (EST) To: Luis Machado Subject: Re: [PATCH 0/8] Fix gdb's testsuite test names X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 25 Nov 2016 17:31:00 -0000 From: Simon Marchi Cc: gdb-patches@sourceware.org In-Reply-To: <1480093744-13771-1-git-send-email-lgustavo@codesourcery.com> References: <1480093744-13771-1-git-send-email-lgustavo@codesourcery.com> Message-ID: <01dc0b4ef0735c891cb9be0e52151ab9@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.2 X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00823.txt.bz2 On 2016-11-25 12:08, Luis Machado wrote: > I was going to go with a single patch for this, but i kept hitting > other > cases where i needed to adjust the regular expressions and substitution > rules. > > I then decided to have a series with each individual piece that should > make it > easier to review as well. The changes are all pretty mechanical, but it > would > be nice to have another pair of eyes looking at these to make sure > nothing > incorrect got through. > > The first patch handles the "testfile as test name" problem. The rest > of the > series handles test names starting with uppercase. > > Luis Machado (8): > Fixup testcases outputting own name as a test name > Fix test names starting with uppercase output by basic functions > Fix test names starting with uppercase using gdb_test on a single > line. > Fix test names starting with uppercase using gdb_test_no_output > Fix test names starting with uppercase using gdb_test_multiple > Fix test names starting with uppercase using multi-line > gdb_test/mi_gdb_test > Fix test names starting with uppercase using multi-line > gdb_test_no_output > Fix test names starting with uppercase using multi-line > gdb_test_multiple Hi Luis, I'll take a quick look at those. While applying, git gave me these warnings. It's probably extraneous spaces that were there before, but if you feel like it you can remove them. Applying: Fix test names starting with uppercase output by basic functions .git/rebase-apply/patch:3302: trailing whitespace. pass "thread command" warning: 1 line adds whitespace errors. Applying: Fix test names starting with uppercase using gdb_test on a single line. .git/rebase-apply/patch:1325: trailing whitespace. gdb_test "print r" " = -1" "test cos(pi) is equal to -1" .git/rebase-apply/patch:1477: trailing whitespace. gdb_test "set print test-enum-param three" "Undefined item: \"three\".*" "set invalid enum parameter" warning: 2 lines add whitespace errors. Simon