From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id S+yMAaIp/mNHtgAAWB0awg (envelope-from ) for ; Tue, 28 Feb 2023 11:19:46 -0500 Received: by simark.ca (Postfix, from userid 112) id EB0951E222; Tue, 28 Feb 2023 11:19:45 -0500 (EST) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=TFv4d57G; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9F58A1E128 for ; Tue, 28 Feb 2023 11:19:45 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D9EF03858421 for ; Tue, 28 Feb 2023 16:19:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D9EF03858421 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1677601183; bh=Jsh0jSyTAsiO+nPd/DKC6i4LFeRNRnsNpOE7do4ELI8=; h=To:Cc:Date:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=TFv4d57GZyCztAn8rAmofrwsI8k5+pfeLjYSxMv4P82ffLO0KDtSUNGCVLCIGXZ0y kr6kVujKvc0UEm4RC1NbjSRv54h+NeQmxHPVFScEEN3U4GU6DpQU6FjMh8OlJPZshx TfzsrzNnzJvYHfDyMRHXVZTSvUTsjyUtcGrbuXaQ= Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id BE21E3858D33 for ; Tue, 28 Feb 2023 16:19:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BE21E3858D33 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31SFLdU2021542; Tue, 28 Feb 2023 16:19:20 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3p1gstggbv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 28 Feb 2023 16:19:20 +0000 Received: from m0098409.ppops.net (m0098409.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 31SDuB0X032359; Tue, 28 Feb 2023 16:19:20 GMT Received: from ppma03wdc.us.ibm.com (ba.79.3fa9.ip4.static.sl-reverse.com [169.63.121.186]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3p1gstggbc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 28 Feb 2023 16:19:20 +0000 Received: from pps.filterd (ppma03wdc.us.ibm.com [127.0.0.1]) by ppma03wdc.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 31SF0FkB018850; Tue, 28 Feb 2023 16:19:18 GMT Received: from smtprelay06.wdc07v.mail.ibm.com ([9.208.129.118]) by ppma03wdc.us.ibm.com (PPS) with ESMTPS id 3nybcbsw2a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 28 Feb 2023 16:19:18 +0000 Received: from smtpav06.wdc07v.mail.ibm.com (smtpav06.wdc07v.mail.ibm.com [10.39.53.233]) by smtprelay06.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 31SGJH4764094544 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 28 Feb 2023 16:19:17 GMT Received: from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 672D65803F; Tue, 28 Feb 2023 16:19:17 +0000 (GMT) Received: from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B1FE25804E; Tue, 28 Feb 2023 16:19:16 +0000 (GMT) Received: from li-e362e14c-2378-11b2-a85c-87d605f3c641.ibm.com (unknown [9.211.67.183]) by smtpav06.wdc07v.mail.ibm.com (Postfix) with ESMTP; Tue, 28 Feb 2023 16:19:16 +0000 (GMT) Message-ID: <01c83c8b18445880e0cece12c40f556442ecd77a.camel@us.ibm.com> To: Bruno Larsen , Ulrich Weigand , "gdb-patches@sourceware.org" , "tdevries@suse.de" , "pedro@palves.net" Cc: cel@us.ibm.com Date: Tue, 28 Feb 2023 08:19:16 -0800 In-Reply-To: References: <78b464a1-e32e-c3da-85e4-7bfc322cc29f@redhat.com> <7848e9858b54e33e399b871774ffc0b5058c1736.camel@us.ibm.com> <65d44121-65f7-a212-79ec-07ce53c15ecb@suse.de> <9fe94c0979cb40979b0dea7693a901c2d9f66164.camel@us.ibm.com> <59417813-eb4a-baf8-4e5d-e225d6732f71@suse.de> <7a494157-494f-6adf-d533-bf373b0f054f@redhat.com> <71aa635593df0677811afb85409aa190bcfa4f6a.camel@us.ibm.com> <15864a6b87b25c93e99a28149f23138267735f2a.camel@us.ibm.com> <041f62e9f26fd4a536bc90c34f072985582e6237.camel@de.ibm.com> <46c2c756475ba5923d7eed97996632a08285dd42.camel@us.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-18.el8) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: mkb7P9euqk-VEBfWE1ait1U_NZSwfxc4 X-Proofpoint-ORIG-GUID: x-bRsNl-WKJZ-N-VRlfbFC88iDSZRP80 Subject: RE: [PATCH ] PowerPC: fix for gdb.reverse/finish-precsave.exp and gdb.reverse/finish-reverse.exp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-02-28_13,2023-02-28_03,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 bulkscore=0 spamscore=0 malwarescore=0 suspectscore=0 adultscore=0 mlxscore=0 mlxlogscore=809 lowpriorityscore=0 clxscore=1015 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302280132 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Carl Love via Gdb-patches Reply-To: Carl Love Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Bruno: Thanks for testing and reviewing the patch On Tue, 2023-02-28 at 14:39 +0100, Bruno Larsen wrote: > Hi Carl, > > Sorry about the delay. I've tested the series and see no regressions. > In > particular, the tests you called out all passed on my machine. I have > a > minor wording nit in one comment, but regardless, you can add to the > tag: > > Reviewed-By: Bruno Larsen > > > ----------------------------------------------------- > > > > > > - /* Set a step-resume at the function's entry point. Once > > that's > > - hit, we'll do one more step backwards. */ > > + if ((pc < alt_entry_point) || (pc > entry_point)) > > + { > > + /* We are in the body of the function. Set a breakpoint to > > backup to > > I would change backup for "return", or separate it to "back up", > otherwise I personally think of data backups. OK, I changed the line as follows in my copy of the patch entry_point = gdbarch_skip_entrypoint (gdbarch, sal.pc); if ((pc < alt_entry_point) || (pc > entry_point)) { - /* We are in the body of the function. Set a breakpoint to backup to + /* We are in the body of the function. Set a breakpoint to go back to the normal entry point. */ symtab_and_line sr_sal; I think that addresses your concern. It is not worth resending the patch at this point for this change but will include it in any future posts or commits. Thanks for the feedback. Carl