From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25462 invoked by alias); 20 May 2005 11:31:41 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 25317 invoked from network); 20 May 2005 11:31:28 -0000 Received: from unknown (HELO romy.inter.net.il) (192.114.186.66) by sourceware.org with SMTP; 20 May 2005 11:31:28 -0000 Received: from zaretski (IGLD-83-130-247-87.inter.net.il [83.130.247.87]) by romy.inter.net.il (MOS 3.5.8-GR) with ESMTP id BGY25794 (AUTH halo1); Fri, 20 May 2005 14:30:51 +0300 (IDT) Date: Fri, 20 May 2005 12:42:00 -0000 From: "Eli Zaretskii" To: Ian Lance Taylor Message-ID: <01c55d2f$Blat.v2.4$0dc6b6e0@zahav.net.il> Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=ISO-8859-1 CC: gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org, binutils@sourceware.org In-reply-to: <20050515195522.GA19088@nevyn.them.org> (message from Daniel Jacobowitz on Sun, 15 May 2005 15:55:23 -0400) Subject: Re: [RFA] Eliminate warnings about snprintf declaration Reply-to: Eli Zaretskii References: <01c5570e$Blat.v2.4$1c533160@zahav.net.il> <20050512162453.GA5180@nevyn.them.org> <01c55732$Blat.v2.4$e9bd3640@zahav.net.il> <20050512205103.GB13519@nevyn.them.org> <01c5586c$Blat.v2.4$a7dfc720@zahav.net.il> <20050514141204.GA10684@nevyn.them.org> <01c558a0$Blat.v2.4$2b06ba40@zahav.net.il> <20050515170435.GB11855@nevyn.them.org> <01c55986$Blat.v2.4$2a6b6c20@zahav.net.il> <20050515195522.GA19088@nevyn.them.org> X-SW-Source: 2005-05/txt/msg00488.txt.bz2 > Date: Sun, 15 May 2005 15:55:23 -0400 > From: Daniel Jacobowitz > Cc: Ian Lance Taylor , gcc-patches@gcc.gnu.org, > gdb-patches@sourceware.org, binutils@sourceware.org > > On Sun, May 15, 2005 at 10:40:59PM +0300, Eli Zaretskii wrote: > > > Date: Sun, 15 May 2005 13:04:35 -0400 > > > From: Daniel Jacobowitz > > > Cc: Eli Zaretskii , gcc-patches@gcc.gnu.org, > > > gdb-patches@sourceware.org, binutils@sourceware.org > > > > > > > > bfd/ChangeLog: > > > > > 2005-05-14 Eli Zaretskii > > > > > > > > > > * configure.in: Add snprintf and vsnprintf to AC_CHECK_DECLS. > > > > > > > > These patches are approved, plus the change to libiberty/configure.ac > > > > which needs the obvious ChangeLog entry. Thanks. > > > > > > Eli, please mention regenerating configure in the ChangeLog. > > > > I didn't send patches for the (regenerated) configure and config.in. > > Should I do that, given that I cannot commit them anyway? > > No, you don't need to. If you mention them in the ChangeLog, that'll > serve as a hint to whoever commits the patch which files need to be > regenerated. > > > > Same comment as above applies; please mention configure. > > > > (And config.in, right?) Will do. > > Good catch. Yes, thank you. Okay, here's the revised patch with revised ChangeLog entries. I will commit the GDB part shortly, but I need someone else to commit the patches in bfd/, include/, and libiberty/. TIA libiberty/ChangeLog: 2005-05-20 Eli Zaretskii * configure.ac: Add snprintf and vsnprintf to AC_CHEK_DECLS. * config.in, configure: Regenerate. include/ChangeLog: 2005-05-20 Eli Zaretskii * libiberty.h: (snprintf) [!HAVE_DECL_SNPRINTF]: Declare if needed. (vsnprintf) [!HAVE_DECL_VSNPRINTF]: Declare if needed. gdb/ChangeLog: 2005-05-20 Eli Zaretskii * configure.ac: Add snprintf and vsnprintf to AC_CHECK_DECLS. * config.in, configure: Regenerate. bfd/ChangeLog: 2005-05-20 Eli Zaretskii * configure.in: Add snprintf and vsnprintf to AC_CHECK_DECLS. * config.in, configure: Regenerate. Index: bfd/configure.in =================================================================== RCS file: /cvs/src/src/bfd/configure.in,v retrieving revision 1.183 diff -u -r1.183 configure.in --- bfd/configure.in 10 May 2005 01:27:53 -0000 1.183 +++ bfd/configure.in 20 May 2005 11:16:55 -0000 @@ -144,6 +144,8 @@ AC_CHECK_DECLS(realloc) AC_CHECK_DECLS(stpcpy) AC_CHECK_DECLS(strstr) +AC_CHECK_DECLS(snprintf) +AC_CHECK_DECLS(vsnprintf) # If we are configured native, pick a core file support file. COREFILE= cvs diff: I know nothing about gdb/configure.in Index: include/libiberty.h =================================================================== RCS file: /cvs/src/src/include/libiberty.h,v retrieving revision 1.44 diff -u -r1.44 libiberty.h --- include/libiberty.h 12 May 2005 20:00:35 -0000 1.44 +++ include/libiberty.h 20 May 2005 11:20:18 -0000 @@ -531,6 +531,16 @@ ATTRIBUTE_PRINTF(2,0); #endif +#if defined(HAVE_DECL_SNPRINTF) && !HAVE_DECL_SNPRINTF +/* Like sprintf but prints at most N characters. */ +extern int snprintf (char *, size_t, const char *, ...) ATTRIBUTE_PRINTF_3; +#endif + +#if defined(HAVE_DECL_VSNPRINTF) && !HAVE_DECL_VSNPRINTF +/* Like vsprintf but prints at most N characters. */ +extern int vsnprintf (char *, size_t, const char *, va_list); +#endif + #define ARRAY_SIZE(a) (sizeof (a) / sizeof ((a)[0])) /* Drastically simplified alloca configurator. If we're using GCC, Index: libiberty/configure.ac =================================================================== RCS file: /cvs/src/src/libiberty/configure.ac,v retrieving revision 1.22 diff -u -r1.22 configure.ac --- libiberty/configure.ac 7 May 2005 02:00:41 -0000 1.22 +++ libiberty/configure.ac 20 May 2005 11:22:47 -0000 @@ -282,7 +282,7 @@ sysconf times sbrk gettimeofday ffs snprintf vsnprintf \ pstat_getstatic pstat_getdynamic sysmp getsysinfo table sysctl wait3 wait4 \ realpath canonicalize_file_name __fsetlocking) - AC_CHECK_DECLS([basename, ffs, asprintf, vasprintf]) + AC_CHECK_DECLS([basename, ffs, asprintf, vasprintf, snprintf, vsnprintf]) AC_DEFINE(HAVE_SYS_ERRLIST, 1, [Define if you have the sys_errlist variable.]) AC_DEFINE(HAVE_SYS_NERR, 1, [Define if you have the sys_nerr variable.]) AC_DEFINE(HAVE_SYS_SIGLIST, 1, [Define if you have the sys_siglist variable.]) @@ -518,7 +518,7 @@ [AC_MSG_RESULT([no])]) AC_CHECK_FUNCS($checkfuncs) - AC_CHECK_DECLS([basename, ffs, asprintf, vasprintf]) + AC_CHECK_DECLS([basename, ffs, asprintf, vasprintf, snprintf, vsnprintf]) libiberty_NEED_DECLARATION(canonicalize_file_name) fi Index: gdb/configure.ac =================================================================== RCS file: /cvs/src/src/gdb/configure.ac,v retrieving revision 1.18 diff -u -r1.18 configure.ac --- gdb/configure.ac 21 Apr 2005 05:34:33 -0000 1.18 +++ gdb/configure.ac 20 May 2005 11:28:33 -0000 @@ -418,7 +418,7 @@ AC_CHECK_DECLS([free, malloc, realloc]) AC_CHECK_DECLS([strerror, strstr]) -AC_CHECK_DECLS(getopt) +AC_CHECK_DECLS([getopt, snprintf, vsnprintf]) # ----------------------- # # Checks for structures. #