From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17851 invoked by alias); 12 May 2005 16:20:20 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 17725 invoked from network); 12 May 2005 16:20:15 -0000 Received: from unknown (HELO romy.inter.net.il) (192.114.186.66) by sourceware.org with SMTP; 12 May 2005 16:20:15 -0000 Received: from zaretski (IGLD-83-130-254-105.inter.net.il [83.130.254.105]) by romy.inter.net.il (MOS 3.5.6-GR) with ESMTP id BEY20313 (AUTH halo1); Thu, 12 May 2005 19:20:07 +0300 (IDT) Date: Thu, 12 May 2005 16:25:00 -0000 From: "Eli Zaretskii" To: gcc-patches@gcc.gnu.org, gdb-patches@sources.redhat.com Message-ID: <01c5570e$Blat.v2.4$1c533160@zahav.net.il> Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=ISO-8859-1 In-reply-to: <20050512154716.GA3513@nevyn.them.org> (message from Daniel Jacobowitz on Thu, 12 May 2005 11:47:16 -0400) Subject: Re: [RFA] Eliminate warnings about snprintf declaration Reply-to: Eli Zaretskii References: <01c4c990$Blat.v2.2.2$887ec720@zahav.net.il> <41994B9D.9080809@gnu.org> <01c55702$Blat.v2.4$d4764900@zahav.net.il> <20050512150804.GA1808@nevyn.them.org> <01c55708$Blat.v2.4$cfc9f040@zahav.net.il> <20050512154716.GA3513@nevyn.them.org> X-SW-Source: 2005-05/txt/msg00297.txt.bz2 > Date: Thu, 12 May 2005 11:47:16 -0400 > From: Daniel Jacobowitz > Cc: gcc-patches@gcc.gnu.org, gdb-patches@sources.redhat.com > > > > That will only affect libiberty.h when building libiberty; it won't > > > affect the users of libiberty. > > > > Then how does one cause libiberty/configure to check for these > > declarations and edit libiberty/config.h accordingly? I thought one > > should modify configure.ac and the regenerate configure, no? > > It doesn't matter. libiberty/config.h is not a public file; it is only > used while building libiberty. Any project that wants a prototype for > these functions is responsible for the check in its own private > config.h. I guess I'm missing something obvious, since I still don't get it. Here's the process of getting these declarations as I understand it: . the configure script checks whether asprintf, basename, ffs, etc. are declared on standard headers . it then edits config.in into config.h and adds the appropriate definitions for HAVE_DECL_ASPRINTF, HAVE_DECL_BASENAME, etc. . include/libiberty.h then enables its own declarations for those platforms for which HAVE_DECL_ASPRINTF etc. say there's a need for a declaration Is the above correct? If so, I need to cause two changes, in addition to modifying include/libiberty.h: 1) cause the configure script check for declarations of 2 additional functions--snprintf and vsnprintf 2) add #undef's for HAVE_DECL_SNPRINTF and HAVE_DECL_VSNPRINTF which will be edited by the configure script How do I make these two changes, if not by modifications to libiberty/configure.ac followed by running Autoconf? Are you saying that I should change gdb/configure.ac (or some other configure) instead? Sorry for being so slow.