From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23156 invoked by alias); 16 Apr 2005 09:14:05 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23134 invoked from network); 16 Apr 2005 09:14:00 -0000 Received: from unknown (HELO legolas.inter.net.il) (192.114.186.24) by sourceware.org with SMTP; 16 Apr 2005 09:14:00 -0000 Received: from zaretski (IGLD-84-228-237-143.inter.net.il [84.228.237.143]) by legolas.inter.net.il (MOS 3.5.6-GR) with ESMTP id EDS61489 (AUTH halo1); Sat, 16 Apr 2005 12:13:48 +0300 (IDT) Date: Sat, 16 Apr 2005 09:14:00 -0000 From: "Eli Zaretskii" To: Kevin Buettner Message-ID: <01c54264$Blat.v2.4$17082620@zahav.net.il> Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=ISO-8859-1 CC: gdb-patches@sources.redhat.com In-reply-to: <20050415130913.50ee721c@ironwood.lan> (message from Kevin Buettner on Fri, 15 Apr 2005 13:09:13 -0700) Subject: Re: [RFC] remote.c: Add remote TLS support Reply-to: Eli Zaretskii References: <20050331162017.0e47552c@ironwood.lan> <20050415130913.50ee721c@ironwood.lan> X-SW-Source: 2005-04/txt/msg00179.txt.bz2 > Date: Fri, 15 Apr 2005 13:09:13 -0700 > From: Kevin Buettner > > I ended up deleting all calls to deprecated_show_value_hack(). As > observed in other discussion, these calls were printing redundant > information. I wish to thank Daniel Jacobowitz for reviewing these > changes. > > With that out of the way, I ended up committing the following changes, > only modified slightly from my earlier posting. (It no longer > refers to the deprecated function and I removed some unused variables > that were leftovers from an even earlier version of the work.) > > * remote.c (remote_protocol_qGetTLSAddr): New static global variable. > (set_remote_protocol_qGetTLSAddr_packet_cmd) > (show_remote_protocol_qGetTLSAddr_packet_cmd) > (remote_get_thread_local_address): New functions. > (init_all_packet_configs): Initialize remote_protocol_qGetTLSAddr > variable. > (init_remote_ops): Initialize ``to_get_thread_local_address'' in > target vector. > (show_remote_cmd): Call show_remote_protocol_qGetTLS_Addr_packet_cmd(). > (_initialize_remote): Register the following commands: > "set remote get-thread-local-storage-address-packet" and > "show remote get-thread-local-address-packet". Thanks. Please also add documentation for these new commands (in the "Remote configuration" node). I'd also like to ask everyone who approves patches to request that each new command be accompanied by the appropriate patch for gdb.texinfo. Ditto for a change in user-visible behavior of existing commands. Let us not have undocumented features anymore! TIA