From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27464 invoked by alias); 27 Mar 2005 10:56:59 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 27441 invoked from network); 27 Mar 2005 10:56:54 -0000 Received: from unknown (HELO romy.inter.net.il) (192.114.186.66) by sourceware.org with SMTP; 27 Mar 2005 10:56:54 -0000 Received: from zaretski (IGLD-83-130-253-83.inter.net.il [83.130.253.83]) by romy.inter.net.il (MOS 3.5.6-GR) with ESMTP id AVO09442 (AUTH halo1); Sun, 27 Mar 2005 12:56:37 +0200 (IST) Date: Sun, 27 Mar 2005 10:56:00 -0000 From: "Eli Zaretskii" To: gdb-patches@sourceware.org Message-ID: <01c532bb$Blat.v2.4$589bb600@zahav.net.il> Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=ISO-8859-1 In-reply-to: <20050327052052.GA23610@coe.casa.cgf.cx> (message from Christopher Faylor on Sun, 27 Mar 2005 00:20:52 -0500) Subject: Re: [commit] Ignore SEGVs from win32 IsBad* functions Reply-to: Eli Zaretskii References: <20050327052052.GA23610@coe.casa.cgf.cx> X-SW-Source: 2005-03/txt/msg00360.txt.bz2 > Date: Sun, 27 Mar 2005 00:20:52 -0500 > From: Christopher Faylor > > + { > + char *fn; > + if (find_pc_partial_function ((CORE_ADDR) current_event.u.Exception > + .ExceptionRecord.ExceptionAddress, > + &fn, NULL, NULL) > + && strncmp (fn, "KERNEL32!IsBad", strlen ("KERNEL32!IsBad")) == 0) > + return 0; > + } Nitpicking: won't it be cleaner to have a single string "KERNEL32!IsBad", instead of mentioning it twice, and to use sizeof instead of strlen?