From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20953 invoked by alias); 18 Feb 2005 16:51:11 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20913 invoked from network); 18 Feb 2005 16:51:04 -0000 Received: from unknown (HELO legolas.inter.net.il) (192.114.186.24) by sourceware.org with SMTP; 18 Feb 2005 16:51:04 -0000 Received: from zaretski (IGLD-83-130-209-13.inter.net.il [83.130.209.13]) by legolas.inter.net.il (MOS 3.5.6-GR) with ESMTP id DUB05206 (AUTH halo1); Fri, 18 Feb 2005 18:50:56 +0200 (IST) Date: Fri, 18 Feb 2005 19:27:00 -0000 From: "Eli Zaretskii" To: Andrew Cagney Message-ID: <01c515da$Blat.v2.4$0100a340@zahav.net.il> Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=ISO-8859-1 CC: gdb-patches@sources.redhat.com In-reply-to: <421608B6.5030004@gnu.org> (message from Andrew Cagney on Fri, 18 Feb 2005 10:24:38 -0500) Subject: Re: [commit] Use add_setshow_boolean_cmd Reply-to: Eli Zaretskii References: <421608B6.5030004@gnu.org> X-SW-Source: 2005-02/txt/msg00197.txt.bz2 > Date: Fri, 18 Feb 2005 10:24:38 -0500 > From: Andrew Cagney > > --- dcache.c 15 Feb 2005 15:49:08 -0000 1.21 > +++ dcache.c 18 Feb 2005 15:16:26 -0000 > @@ -585,18 +585,18 @@ dcache_info (char *exp, int tty) > void > _initialize_dcache (void) > { > - deprecated_add_show_from_set > - (add_set_cmd ("remotecache", class_support, var_boolean, > - (char *) &dcache_enabled_p, > - "\ > -Set cache use for remote targets.\n\ > + add_setshow_boolean_cmd ("remotecache", class_support, > + &dcache_enabled_p, _("\ > +Set cache use for remote targets."), _("\ > +Show cache use for remote targets."), _("\ > When on, use data caching for remote targets. For many remote targets\n\ > this option can offer better throughput for reading target memory.\n\ > Unfortunately, gdb does not currently know anything about volatile\n\ > registers and thus data caching will produce incorrect results with\n\ > -volatile registers are in use. By default, this option is off.", > - &setlist), > - &showlist); > +volatile registers are in use. By default, this option is off."), This, and other similar patches, need tio have an i18n comment to tell the translators that the "When on..." part is the continuation of the "Set/Show cache use..." doc string.