From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31827 invoked by alias); 15 Feb 2005 04:52:55 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 31770 invoked from network); 15 Feb 2005 04:52:48 -0000 Received: from unknown (HELO legolas.inter.net.il) (192.114.186.24) by sourceware.org with SMTP; 15 Feb 2005 04:52:48 -0000 Received: from zaretski (tony06-88-59.inter.net.il [80.230.88.59]) by legolas.inter.net.il (MOS 3.5.6-GR) with ESMTP id DTJ42404 (AUTH halo1); Tue, 15 Feb 2005 06:52:34 +0200 (IST) Date: Tue, 15 Feb 2005 15:36:00 -0000 From: "Eli Zaretskii" To: Andrew Cagney Message-ID: <01c5131a$Blat.v2.4$331ad0c0@zahav.net.il> Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=ISO-8859-1 CC: gdb-patches@sources.redhat.com In-reply-to: <421156FB.70907@gnu.org> (message from Andrew Cagney on Mon, 14 Feb 2005 20:57:15 -0500) Subject: Re: [commit] Mark up add_cmd Reply-to: Eli Zaretskii References: <4210E94F.6010505@gnu.org> <01c512e1$Blat.v2.4$149cf760@zahav.net.il> <421156FB.70907@gnu.org> X-SW-Source: 2005-02/txt/msg00142.txt.bz2 > Date: Mon, 14 Feb 2005 20:57:15 -0500 > From: Andrew Cagney > Cc: gdb-patches@sources.redhat.com > > It's taken us three months to get through files a-c, simple math tells > us that at that rate we'll finish sometime on '07. I don't think so. I don't know why it took so long, but it certainly isn't because of the time it took to review the patch and post the results. IIRC, none of the reviews was ever posted more than a few days after the RFA, usually only hours since the RFA was received. So this argument cannot possibly justify your decision to bypass the normal procedures. > > Sigh. I don't know anymore why should I bother reviewing patches when > > they are committed unconditionally, but here goes anyway... > > As you identify problems, please mark them in the code using a comment > of the form: > > /* FIXME: i18n: ... I didn't know that we switched to marking problems instead of fixing them. How many FIXME's do we want to have in a released GDB?