Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Eli Zaretskii" <eliz@gnu.org>
To: Daniel Jacobowitz <drow@false.org>
Cc: cagney@gnu.org, gdb-patches@sources.redhat.com
Subject: Re: [commit] mark up quit et.al.
Date: Sat, 12 Feb 2005 13:10:00 -0000	[thread overview]
Message-ID: <01c510f0$Blat.v2.4$f7cb04c0@zahav.net.il> (raw)
In-Reply-To: <20050211183109.GA1889@nevyn.them.org> (message from Daniel Jacobowitz on Fri, 11 Feb 2005 13:31:09 -0500)

> Date: Fri, 11 Feb 2005 13:31:09 -0500
> From: Daniel Jacobowitz <drow@false.org>
> Cc: gdb-patches@sources.redhat.com
> 
> On Fri, Feb 11, 2005 at 01:15:26PM -0500, Andrew Cagney wrote:
> > FYI,
> > committed,
> > Andrew
> 
> Perhaps you should wait for someone to proofread this sort of thing.

It looks like Andrew has switched to ``commit'em-all-without-asking''
method, even for patches outside of his domain.  When someone posts an
objection about such a policy, that objection is simply ignored.

Here's one more objection that will probably be ignored:

       ANDREW, WOULD YOU PLEASE STOP DOING THAT?


> > @@ -995,7 +995,7 @@ insert_bp_location (struct bp_location *
> >  	}
> >        else
> >  	{
> > -	  printf_filtered ("Hardware watchpoint %d deleted ", bpt->owner->number);
> > +	  printf_filtered (_("Hardware watchpoint %d deleted "), bpt->owner->number);
> >  	  printf_filtered ("because the program has left the block \n");
> >  	  printf_filtered ("in which its expression is valid.\n");
> >  	  if (bpt->owner->related_breakpoint)
> 
> For instance, this one is bogus.

Indeed.  And I have more comments about that patch (working on it as
we speak).  It's beyond me why such a large patch needed to be
committed without asking for a review.


  parent reply	other threads:[~2005-02-12 10:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-11 19:11 Andrew Cagney
2005-02-11 19:35 ` Daniel Jacobowitz
2005-02-12  2:24   ` Andrew Cagney
2005-02-12 14:29     ` Eli Zaretskii
2005-02-12 13:10   ` Eli Zaretskii [this message]
2005-02-14 22:03     ` Daniel Jacobowitz
2005-02-15  1:58       ` Eli Zaretskii
2005-02-12 16:05 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='01c510f0$Blat.v2.4$f7cb04c0@zahav.net.il' \
    --to=eliz@gnu.org \
    --cc=cagney@gnu.org \
    --cc=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox