From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20992 invoked by alias); 15 Dec 2004 21:12:18 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20764 invoked from network); 15 Dec 2004 21:12:07 -0000 Received: from unknown (HELO romy.inter.net.il) (192.114.186.66) by sourceware.org with SMTP; 15 Dec 2004 21:12:07 -0000 Received: from zaretski (IGLD-83-130-213-50.inter.net.il [83.130.213.50]) by romy.inter.net.il (MOS 3.5.6-GR) with ESMTP id ABP97700 (AUTH halo1); Wed, 15 Dec 2004 23:11:44 +0200 (IST) Date: Wed, 15 Dec 2004 21:48:00 -0000 From: "Eli Zaretskii" To: Baurjan Ismagulov Message-ID: <01c4e2ea$Blat.v2.2.2$ceff9ee0@zahav.net.il> Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=ISO-8859-1 CC: gdb-patches@sources.redhat.com In-reply-to: <20041215000745.GA3049@ata.cs.hun.edu.tr> (message from Baurjan Ismagulov on Wed, 15 Dec 2004 01:07:45 +0100) Subject: Re: i18n, part 2 Reply-to: Eli Zaretskii References: <20041204195702.GA25306@ata.cs.hun.edu.tr> <20041204200605.GA15732@nevyn.them.org> <20041204215404.GA2413@ata.cs.hun.edu.tr> <01c4db12$Blat.v2.2.2$4dfdf600@zahav.net.il> <20041215000745.GA3049@ata.cs.hun.edu.tr> X-SW-Source: 2004-12/txt/msg00389.txt.bz2 > Date: Wed, 15 Dec 2004 01:07:45 +0100 > From: Baurjan Ismagulov > > here's the new version. I've addressed two issues: > > * Providing context. > > I've followed the advice from Andreas Schwab and provided examples of > the whole phrases as they are printed by gdb. In this way, the code is > readable, and the message file has even more context than is provided > by the translated string itself. I've done this only for permutations; > obvious cases like "big endian" / "little endian" have been rewritten. > The relevant excerpt from the output of "xgettext -o a.po -k_ > --add-comments=i18n *.c" is attached. Thanks. This version is okay with me, provided that we record somewhere that when the flag day comes, xgettext will be invoked henceforth with the --add-comments=i18n switch. I'm unsure where to put that info. Andrew? > if (arm_fp_model == ARM_FLOAT_AUTO > && gdbarch_bfd_arch_info (current_gdbarch)->arch == bfd_arch_arm) > - printf_filtered (" - the default for the current ABI is \"%s\".\n", > + printf_filtered (_(" - the default for the current ABI is \"%s\".\n"), > fp_model_strings[tdep->fp_model]); This lacks the leading context, which makes it unclear what default is this string about. Can we either rewrite the printf to include the context, or resolve it with a i18n comment?