From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16260 invoked by alias); 10 Dec 2004 12:21:51 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15512 invoked from network); 10 Dec 2004 12:21:08 -0000 Received: from unknown (HELO balder.inter.net.il) (192.114.186.15) by sourceware.org with SMTP; 10 Dec 2004 12:21:08 -0000 Received: from zaretski (IGLD-83-130-247-149.inter.net.il [83.130.247.149]) by balder.inter.net.il (Mirapoint Messaging Server MOS 3.3.7-GR) with ESMTP id DXB21887 (AUTH halo1); Fri, 10 Dec 2004 14:20:27 +0200 (IST) Date: Fri, 10 Dec 2004 13:31:00 -0000 From: "Eli Zaretskii" To: Jeff Johnston Message-ID: <01c4deb2$Blat.v2.2.2$ce83b6e0@zahav.net.il> Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=ISO-8859-1 CC: gdb-patches@sources.redhat.com In-reply-to: <41B8E16D.6070505@redhat.com> (message from Jeff Johnston on Thu, 09 Dec 2004 18:36:13 -0500) Subject: Re: [RFA]: Modified Watchthreads Patch Reply-to: Eli Zaretskii References: <41B8E16D.6070505@redhat.com> X-SW-Source: 2004-12/txt/msg00263.txt.bz2 > Date: Thu, 09 Dec 2004 18:36:13 -0500 > From: Jeff Johnston > > The following is a modified version of my thread watchpoint patch from > October/November. It removes the code I had used to switch between lwp ptids > and thread ptids now that Daniel's lwp patch is in place. It uses the former > version of my observer that is linux-specific and is activated in attach_thread > in linux-thread-db.c. Eli, I renamed the observer as asked to indicate this. Thanks. > * breakpoint.c (insert_watchpoints_for_new_thread): New function. > (print_it_typical): Do not issue an error for bp_thread_event > if a subsequent event is on the chain. > * breakpoint.h (insert_watchpoints_for_new_thread): New prototype. Hmm... the new function insert_watchpoints_for_new_thread is called only by ia64_linux_new_thread. Is there any policy for functions that are only used by a single port? Do we care that all the other GDB builds will get a useless function compiled into them? Should we perhaps #ifdef it away conditioned on some symbol? > +@deftypefun void linux_new_thread (ptid_t @var{ptid}) > +A new linux thread described by @var{ptid} has been officially attached > +to by gdb. > +@end deftypefun What does it mean ``officially attached''? Can a thread be attached to ``unofficially''?