From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29569 invoked by alias); 5 Dec 2004 21:34:05 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 29334 invoked from network); 5 Dec 2004 21:33:53 -0000 Received: from unknown (HELO legolas.inter.net.il) (192.114.186.24) by sourceware.org with SMTP; 5 Dec 2004 21:33:53 -0000 Received: from zaretski ([80.230.156.125]) by legolas.inter.net.il (MOS 3.5.5-GR) with ESMTP id DGP46296 (AUTH halo1); Sun, 5 Dec 2004 23:33:42 +0200 (IST) Date: Sun, 05 Dec 2004 21:41:00 -0000 From: "Eli Zaretskii" To: Baurjan Ismagulov Message-ID: <01c4db12$Blat.v2.2.2$4dfdf600@zahav.net.il> Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=ISO-8859-1 CC: gdb-patches@sources.redhat.com In-reply-to: <20041204215404.GA2413@ata.cs.hun.edu.tr> (message from Baurjan Ismagulov on Sat, 4 Dec 2004 22:54:04 +0100) Subject: Re: i18n, part 2 Reply-to: Eli Zaretskii References: <20041204195702.GA25306@ata.cs.hun.edu.tr> <20041204200605.GA15732@nevyn.them.org> <20041204215404.GA2413@ata.cs.hun.edu.tr> X-SW-Source: 2004-12/txt/msg00136.txt.bz2 > Date: Sat, 4 Dec 2004 22:54:04 +0100 > From: Baurjan Ismagulov > > Hmm, it did the last time I tried it, but 0.14.1-6 seems to work as > expected. I modified the patch. Thanks. My comments are below. > BTW, is there an argument reformatting function in emacs, so that, say, > M-q would wrap the arguments and strings up to fill-column? Not that I know of, but you might have better success asking this on emacs-devel@gnu.org. > @@ -1700,16 +1700,16 @@ aix_thread_extra_thread_info (struct thr > status = pthdb_pthread_suspendstate (pd_session, pdtid, > &suspendstate); > if (status == PTHDB_SUCCESS && suspendstate == PSS_SUSPENDED) > - fprintf_unfiltered (buf, ", suspended"); > + fprintf_unfiltered (buf, _(", suspended")); > > status = pthdb_pthread_detachstate (pd_session, pdtid, > &detachstate); > if (status == PTHDB_SUCCESS && detachstate == PDS_DETACHED) > - fprintf_unfiltered (buf, ", detached"); > + fprintf_unfiltered (buf, _(", detached")); > > pthdb_pthread_cancelpend (pd_session, pdtid, &cancelpend); > if (status == PTHDB_SUCCESS && cancelpend) > - fprintf_unfiltered (buf, ", cancel pending"); > + fprintf_unfiltered (buf, _(", cancel pending")); > > ui_file_write (buf, "", 1); We discussed cases like this before, I believe. The original code fragment looks like this: if (tid != PTHDB_INVALID_TID) fprintf_unfiltered (buf, "tid %d", tid); status = pthdb_pthread_state (pd_session, pdtid, &state); if (status != PTHDB_SUCCESS) state = PST_NOTSUP; fprintf_unfiltered (buf, ", %s", state2str (state)); status = pthdb_pthread_suspendstate (pd_session, pdtid, &suspendstate); if (status == PTHDB_SUCCESS && suspendstate == PSS_SUSPENDED) fprintf_unfiltered (buf, ", suspended"); status = pthdb_pthread_detachstate (pd_session, pdtid, &detachstate); if (status == PTHDB_SUCCESS && detachstate == PDS_DETACHED) fprintf_unfiltered (buf, ", detached"); pthdb_pthread_cancelpend (pd_session, pdtid, &cancelpend); if (status == PTHDB_SUCCESS && cancelpend) fprintf_unfiltered (buf, ", cancel pending"); ui_file_write (buf, "", 1); This code produces a complete sentence one word at a time, which I think is bad for translating. I think the code needs to be rewritten to have full sentences like these: "tid %d, %s, suspended, detached, cancel pending" "tid %d, %s, detached, cancel pending" "tid %d, %s, cancel pending" "tid %d, %s" "tid %d, %s, suspended, cancel pending" "tid %d, %s, suspended, detached" "tid %d, %s, detached, cancel pending" "tid %d, %s, detached" etc. That makes the code less clever, but the translation is much easier. As the code is now, it will be almost impossible to get right in some languages. > - error ("Illegal update to pc in instruction"); > + error (_("Illegal update to pc in instruction")); Perhaps we should take this opportunity to change "Illegal" to "Invalid" here (and elsewhere in your patch), to follow the GNU coding standards. Otherwise, okay; thanks.