From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16096 invoked by alias); 20 Nov 2004 17:22:26 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 16079 invoked from network); 20 Nov 2004 17:22:18 -0000 Received: from unknown (HELO legolas.inter.net.il) (192.114.186.24) by sourceware.org with SMTP; 20 Nov 2004 17:22:18 -0000 Received: from zaretski ([80.230.142.118]) by legolas.inter.net.il (MOS 3.5.5-GR) with ESMTP id DDS08525 (AUTH halo1); Sat, 20 Nov 2004 19:22:15 +0200 (IST) Date: Sat, 20 Nov 2004 17:22:00 -0000 From: "Eli Zaretskii" To: Mark Kettenis Message-ID: <01c4cf25$Blat.v2.2.2$44ec6860@zahav.net.il> Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=ISO-8859-1 CC: gdb-patches@sources.redhat.com In-reply-to: <200411201239.iAKCd9O5061792@elgar.sibelius.xs4all.nl> (message from Mark Kettenis on Sat, 20 Nov 2004 13:39:09 +0100 (CET)) Subject: Re: [COMMIT] Improve coding standard in dbxread.c Reply-to: Eli Zaretskii References: <200411201239.iAKCd9O5061792@elgar.sibelius.xs4all.nl> X-SW-Source: 2004-11/txt/msg00403.txt.bz2 > Date: Sat, 20 Nov 2004 13:39:09 +0100 (CET) > From: Mark Kettenis > > Only a tiny fraction of the code, but it's a step into the right > direction. I think changes like these are wrong: > - case N_STSYM: /* Static symbol in data seg */ > - case N_LCSYM: /* Static symbol in BSS seg */ > - case N_ROSYM: /* Static symbol in Read-only data seg */ > + case N_STSYM: /* Static symbol in data segment. */ > + case N_LCSYM: /* Static symbol in BSS segment. */ > + case N_ROSYM: /* Static symbol in read-only data segment. */ The text in these comments does not constitute a full sentence, and so adding a period at the end is not the right change. The right way to fix this, IMHO, is to lower-case the first letter of the comment, like this: case N_STSYM: /* static symbol in data segment */ There are numerous other instances of similar changes, and IMHO they all are wrong. This one looks particularly incorrect after the change: > + case N_NOMAP: /* No map? (Ultrix). */ Some of the other changes simply reformat comments to break the line at a different column. Do we have a canonical column number for that, and if we do, what is its value?