From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6455 invoked by alias); 11 Nov 2004 19:44:26 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 6405 invoked from network); 11 Nov 2004 19:44:16 -0000 Received: from unknown (HELO balder.inter.net.il) (192.114.186.15) by sourceware.org with SMTP; 11 Nov 2004 19:44:16 -0000 Received: from zaretski (pns03-208-44.inter.net.il [80.230.208.44]) by balder.inter.net.il (Mirapoint Messaging Server MOS 3.3.7-GR) with ESMTP id DWA99057 (AUTH halo1); Thu, 11 Nov 2004 21:43:33 +0200 (IST) Date: Thu, 11 Nov 2004 19:44:00 -0000 From: "Eli Zaretskii" To: Andrew Cagney Message-ID: <01c4c826$Blat.v2.2.2$10ab7100@zahav.net.il> Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=ISO-8859-1 CC: gdb-patches@sources.redhat.com In-reply-to: <41939529.8050308@gnu.org> (message from Andrew Cagney on Thu, 11 Nov 2004 11:36:57 -0500) Subject: Re: [commit] Convert COERCE_* to functions Reply-to: Eli Zaretskii References: <41926591.9080206@gnu.org> <01c4c75e$Blat.v2.2.2$ca853fc0@zahav.net.il> <41939529.8050308@gnu.org> X-SW-Source: 2004-11/txt/msg00240.txt.bz2 > Date: Thu, 11 Nov 2004 11:36:57 -0500 > From: Andrew Cagney > Cc: gdb-patches@sources.redhat.com > > > 1) Can you tell the reason for these changes? > > > > 2) Personally, I think that > > > > foo = foobar (foo); > > > > is not a good style of C programming. > > opaque `struct value' > http://sources.redhat.com/ml/gdb/2004-11/msg00010.html Thanks. Perhaps it would help in the future to post the URL with the patch. > Converting a macro to a function has for a long time been considered > obvious. I don't think it's obvious, but if I'm the only one, let's codify that where we say what falls under the ``obvious'' rule. What about my second comment? isn't it better to make the functions void and let them modify the argument?