From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27132 invoked by alias); 20 Oct 2004 05:04:34 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 27122 invoked from network); 20 Oct 2004 05:04:32 -0000 Received: from unknown (HELO balder.inter.net.il) (192.114.186.15) by sourceware.org with SMTP; 20 Oct 2004 05:04:32 -0000 Received: from zaretski ([80.230.149.128]) by balder.inter.net.il (Mirapoint Messaging Server MOS 3.3.7-GR) with ESMTP id DVE89339 (AUTH halo1); Wed, 20 Oct 2004 07:04:15 +0200 (IST) Date: Wed, 20 Oct 2004 05:04:00 -0000 From: "Eli Zaretskii" To: Jeff Johnston Message-ID: <01c4b661$Blat.v2.2.2$cdd3a8a0@zahav.net.il> Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=ISO-8859-1 CC: gdb-patches@sources.redhat.com In-reply-to: <4175A9C9.8040300@redhat.com> (message from Jeff Johnston on Tue, 19 Oct 2004 19:56:57 -0400) Subject: Re: [RFA]: Watchpoints per thread patch Reply-to: Eli Zaretskii References: <4175A9C9.8040300@redhat.com> X-SW-Source: 2004-10/txt/msg00329.txt.bz2 > Date: Tue, 19 Oct 2004 19:56:57 -0400 > From: Jeff Johnston > > The following patch adds needed support for the ia64 and s390 platforms. For > these platforms, watchpoints need to be inserted / removed on each thread so as > to work across all threads. The patch is fine with me, provided that you take care of the following minor issues: > +# Set various watchpoint flags based on host/cpu > + > +case "${host}" in > +ia64-*-*) > + gdb_host_watchpoints_per_thread=1 This is not very autoconfish, but I guess there's no better way to test for this, is there? > +int > +thread_switch_and_call (int thread_num, int (*callback) (void *), void *args) IMHO, the name of this function is misleading; a better name would something like map_threads or apply_to_all_threads. > +int > +insert_watchpoints_for_new_thread (struct thread_info *ti) This function is only neded if WATCHPOINTS_PER_THREAD is defined, so I think the function's definition itself should be conditioned by WATCHPOINTS_PER_THREAD.