From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-36020-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 18473 invoked by alias); 28 Sep 2004 20:14:58 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 18463 invoked from network); 28 Sep 2004 20:14:57 -0000
Received: from unknown (HELO legolas.inter.net.il) (192.114.186.24)
  by sourceware.org with SMTP; 28 Sep 2004 20:14:57 -0000
Received: from zaretski ([80.230.147.243])
	by legolas.inter.net.il (MOS 3.5.3-GR)
	with ESMTP id CRY45040 (AUTH halo1);
	Tue, 28 Sep 2004 22:14:52 +0200 (IST)
Date: Tue, 28 Sep 2004 20:14:00 -0000
From: "Eli Zaretskii" <eliz@gnu.org>
To: Paul Hilfinger <hilfingr@gnat.com>
Message-ID: <01c4a597$Blat.v2.2.2$990c9580@zahav.net.il>
Content-Transfer-Encoding: 7BIT
Content-Type: text/plain; charset=ISO-8859-1
CC: gdb-patches@sources.redhat.com
In-reply-to: <20040927103327.450A8F2C33@nile.gnat.com> (message from Paul
	Hilfinger on Mon, 27 Sep 2004 06:33:27 -0400 (EDT))
Subject: Re: [RFA]: Turn on initial Ada support in GDB
Reply-to: Eli Zaretskii <eliz@gnu.org>
References:  <20040927103327.450A8F2C33@nile.gnat.com>
X-SW-Source: 2004-09/txt/msg00458.txt.bz2

> From: Paul Hilfinger <hilfingr@gnat.com>
> Date: Mon, 27 Sep 2004 06:33:27 -0400 (EDT)
> 

Oops, missed that.

The patch to gdb.texinfo is approved, but please fix the minor gotchas
below.

I also think this warrants an entry in NEWS.

Thanks.

> +* Ada Mode Intro::              General remarks on the Ada syntax 
> +                                   and semantics supported by Ada mode 
> +                                   in @value{GDBN}

A period is missing at the end of the sentence.

> +Dispatching subprogram calls are not implemented.

"Dispatching" is not plural, so we should say ``is not implemented''.

> +in strings.   For example,
> +@smallexample
> +   "One line.["0a"]Next line.["0a"]"
> +@end smallexample
> +@noindent
> +Contains an ASCII newline character (@code{Ada.Characters.Latin_1.LF}) after each
> +period.

"Contains" should not begin with a capital C here, as it is a
continuation of the sentence before the example.

> +(gdb) break exception Standard.Constraint_Error

This should use "@value{GDBP}" rather than a literal "(gdb)".