From: "Eli Zaretskii" <eliz@gnu.org>
To: Andrew Cagney <cagney@gnu.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch/rfc] Implement ptrace target vector inheritance
Date: Mon, 06 Sep 2004 04:59:00 -0000 [thread overview]
Message-ID: <01c493ce$Blat.v2.2.2$4f8cf380@zahav.net.il> (raw)
In-Reply-To: <413B1E60.9060506@gnu.org> (message from Andrew Cagney on Sun, 05 Sep 2004 10:10:40 -0400)
> Date: Sun, 05 Sep 2004 10:10:40 -0400
> From: Andrew Cagney <cagney@gnu.org>
>
> The current native code constructs its target vector using a convoluted
> combination of #ifdefs and global functions.
>
> This patch replaces all that with what is effectively a runtime
> inheritance structure:
>
> inf-ptrace is-a inf-child is-a target
>
> I've updated/tested NetBSD/PPC, with a tweak to nbsdppc-nat. that
> further extends the above with:
>
> nbsdppc-nat is-a inf-ptrace
>
> there were no regressions.
>
> The intent is for all natives to eventually migrate to this.
>
> Comments?
My comments are:
(1) Let's have this machinery documented in gdbint.texinfo.
(2) The patch introduces a couple of user commands (like `udot')
that should be documented in gdb.texinfo.
(3) Several hunks in the patch do not belong to it: they are merely
whitespace adjustments.
next prev parent reply other threads:[~2004-09-06 4:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-05 14:11 Andrew Cagney
2004-09-06 4:59 ` Eli Zaretskii [this message]
2004-09-06 13:51 ` Andrew Cagney
2004-09-12 13:04 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='01c493ce$Blat.v2.2.2$4f8cf380@zahav.net.il' \
--to=eliz@gnu.org \
--cc=cagney@gnu.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox