From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20705 invoked by alias); 1 Sep 2004 03:40:06 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20492 invoked from network); 1 Sep 2004 03:40:05 -0000 Received: from unknown (HELO balder.inter.net.il) (192.114.186.15) by sourceware.org with SMTP; 1 Sep 2004 03:40:05 -0000 Received: from zaretski (pns03-198-66.inter.net.il [80.230.198.66]) by balder.inter.net.il (Mirapoint Messaging Server MOS 3.3.7-GR) with ESMTP id DTY54312 (AUTH halo1); Wed, 1 Sep 2004 06:39:55 +0300 (IDT) Date: Wed, 01 Sep 2004 03:40:00 -0000 From: "Eli Zaretskii" To: Jeff Johnston Message-ID: <01c48fd5$Blat.v2.2.2$6c961e40@zahav.net.il> Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=ISO-8859-1 CC: gdb-patches@sources.redhat.com In-reply-to: <4134DD15.2080806@redhat.com> (message from Jeff Johnston on Tue, 31 Aug 2004 16:18:29 -0400) Subject: Re: [RFA]: Change to_stopped_data_address ABI Reply-to: Eli Zaretskii References: <4134C991.7050507@redhat.com> <01c48f92$Blat.v2.2.2$1eec0d00@zahav.net.il> <4134DD15.2080806@redhat.com> X-SW-Source: 2004-09/txt/msg00004.txt.bz2 > Date: Tue, 31 Aug 2004 16:18:29 -0400 > From: Jeff Johnston > Cc: gdb-patches@sources.redhat.com > > Perhaps my description isn't clear enough. The function returns non-zero if > successful (i.e. true). It returns 0 (false) to indicate failure or no stopped > data address. Well, I understood that, I think; but the code you posted seems to work differently: if no watchpoint triggered, it returns 1, not zero: > >>@@ -593,7 +598,16 @@ i386_stopped_data_address (void) > >> if (maint_show_dr && addr == 0) > >> i386_show_dr ("stopped_data_addr", 0, 0, hw_write); > >> > >>- return addr; > >>+ *addr_p = addr; > >>+ return 1; Thus, in the case of "no stopped data address", i386_stopped_data_address will return 1 with 0 in the place pointed to by its argument, is that right?