Andrew, I revised my patch. > I've committed the attached which re-indents remote-m32r-sdi.c using > gdb/gdb_indent.sh. You'll want to merge in that change and strip out > any other stray mods. I've merged these changes. > can you add helper functions like: > send_l4_data (SDI_WRITE_MEMORY, 0xffff8200 + 4 * i, 4, 0xffffffff); > for each of these cases (and any others you feel useful). I added several helper functions. Some sequences still remain because they are unique. But most sequences are replaced with helper functions. OK to commit? === 2004-07-26 Kei Sakamoto * remote-m32r-sdi.c: Fix breakpoint bug. (send_cmd, send_one_arg_cmd, send_two_arg_cmd, send_three_arg_cmd, recv_char_data, recv_long_data): New functions to replace communication sequences.