From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailsec110.isp.belgacom.be (mailsec110.isp.belgacom.be [195.238.20.106]) by sourceware.org (Postfix) with ESMTPS id A73C5386F82A for ; Sun, 21 Jun 2020 11:30:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A73C5386F82A IronPort-SDR: L09KYTHnEblm5FE2UqqO/tsh44xJekYW1DM9Lw5YSnEH/AoRHsg0XNyZhruVRUWhye6WVvc319 ZT7amfCQ8i4/AMnxG/7WbhaGGW0cpzHaL/dY4tQAbZiXadYKKxkJvOEglsYSkqSvQlIx2AUsj2 /NIUCJXOwLmFDxZE9lJ2kEC2EuT7iDJJ+lhwJcvhX7KdKcZL7ollj7VK/KERHEqoDV8o/Md3VU E5nW58RlWLFO9asF9U1KQi8149rsDTAZiEfNsyYSsz7gABNC6qff40Gs7x6LF3IfCcTalvnnhT iJA= IronPort-PHdr: =?us-ascii?q?9a23=3AuXfxExNe7yP4rD/1EZsl6mtUPXoX/o7sNwtQ0K?= =?us-ascii?q?IMzox0I/T9rarrMEGX3/hxlliBBdydt6sZzbOG6+u7ASQp2tWoiDg6aptCVh?= =?us-ascii?q?sI2409vjcLJ4q7M3D9N+PgdCcgHc5PBxdP9nC/NlVJSo6lPwWB6nK94iQPFR?= =?us-ascii?q?rhKAF7Ovr6GpLIj8Swyuu+54Dfbx9HiTagYb5+Ngi6oAbNusUZj4ZuNrs6xw?= =?us-ascii?q?fUrHdPZ+lY335jK0iJnxb76Mew/Zpj/DpVtvk86cNOUrj0crohQ7BAAzsoL2?= =?us-ascii?q?465MvwtRneVgSP/WcTUn8XkhVTHQfI6gzxU4rrvSv7sup93zSaPdHzQLspVz?= =?us-ascii?q?mu87tnRRn1gyocKTU37H/YhdBxjKJDoRKuuRp/w5LPYIqIMPZyZ77Rcc8GSW?= =?us-ascii?q?ZEWMtaSi5PDZ6mb4YXDOQPIOZWoZfzqVQMoxuxGQejC+zgxDJTmn/737c33/?= =?us-ascii?q?g9HQzc3gEtGc8FvnTOrNXyMacfSfq7zKnJzTXHbvNWwS/955bVeR8hu/6MR7?= =?us-ascii?q?VwcdPMyUkuCQzFlE6QopHiMjON1uQNsmyb7+t4VeK3lWErsQ9wrSK1xscrk4?= =?us-ascii?q?nJm4MVxU7e9SVi24s1Pt64SU59YdG6DJtcrTqVOJVvT84kXmpntzo0xKcctp?= =?us-ascii?q?6nYCgF1o4nxxjHZvCZbYSF4Q7uWemNLTtkhn9oeL2yiguy/0S8xeDyWcm63U?= =?us-ascii?q?tEoydBjNTCuG4A2hLQ58WERPZw/0es1DiA2g3X6+xJJ10/m6nDK5M53LI8i5?= =?us-ascii?q?gevV7eEiL4mUj6lqybelg+9uWm5enqZKjtqIWGOI9ukA7+N7wjmsm4AeslLA?= =?us-ascii?q?cDR3Ob+eGg1L37+k35XalKguU2kqbHtJDaItwWpqukDANN04Yj7QiwDyu+3d?= =?us-ascii?q?gGgHUKLkhJdA+JgoXoIV3DI+30Ae2xjlmiiDtrwurJPrzlApXDNHjDl7LhcK?= =?us-ascii?q?5l605cyQozydFf54pMCr4fOv7yVFX+tMbfDh8gLgy0wvjoCM9m1o4FQmKPAa?= =?us-ascii?q?+YMKXMvl+U/O4gOPeDaJcPuDnhM/gl++LujXghlF8FZ6ap2YUXZ26jHvl9OU?= =?us-ascii?q?WWf2fjgtcbHmcWpAYxUOvqiFiaWz5Je3myR7485i08CI++AofMW5uijKWZ3C?= =?us-ascii?q?ihAp1ZemBGBU6XEXrzbIWEXOoMaDiOLcB/nD0LT6KhRJE72RGprg/6xOkvEu?= =?us-ascii?q?2BwiAUr5Wr/dxr6vabwQk78SJ5FOyH3m2NRn0ylWQNEXt+06x15FR01lyD3L?= =?us-ascii?q?NQmPtFD9de+PpTX0E9L5GP4fZ9DoXKWgPFf8+RRR6ZS8+hGCwwQ8gqi4sWY0?= =?us-ascii?q?d5Gs26g1bc1jCtGqIUmqaQLIc346TRwz77KpAumD79yKA9ggx+EYN0Pmq8i/?= =?us-ascii?q?s6rlCLCg=3D=3D?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2BBAADgQ+9e/yFRiNlmHAEBAQEBAQc?= =?us-ascii?q?BARIBAQQEAQFAB4ExBQEBCwGBeoFyhQOJAYgJmgIUgWgLAQEBAQEBAQEBCCw?= =?us-ascii?q?BAgQBAYRHAoIpJTYHDgIDAQEBAwIFAQEGAQEBAQEBBQQBhg5FgjspAYMOAQU?= =?us-ascii?q?jMzMIAw4KAgImAgJXBgGGObchgTKJRIFAgQ4qAYhfhBKBTD+EIT6EI4Mugj4?= =?us-ascii?q?iBJoWmhUoB4JdgQYEC5gUIIJxiSSSZpErnnCBWgSCBG2DPU8mjlVuAQcIB40?= =?us-ascii?q?NQmcCBggBAQMJdAgTj3IBAQ?= X-IPAS-Result: =?us-ascii?q?A2BBAADgQ+9e/yFRiNlmHAEBAQEBAQcBARIBAQQEAQFAB?= =?us-ascii?q?4ExBQEBCwGBeoFyhQOJAYgJmgIUgWgLAQEBAQEBAQEBCCwBAgQBAYRHAoIpJ?= =?us-ascii?q?TYHDgIDAQEBAwIFAQEGAQEBAQEBBQQBhg5FgjspAYMOAQUjMzMIAw4KAgImA?= =?us-ascii?q?gJXBgGGObchgTKJRIFAgQ4qAYhfhBKBTD+EIT6EI4Mugj4iBJoWmhUoB4Jdg?= =?us-ascii?q?QYEC5gUIIJxiSSSZpErnnCBWgSCBG2DPU8mjlVuAQcIB40NQmcCBggBAQMJd?= =?us-ascii?q?AgTj3IBAQ?= Received: from 33.81-136-217.adsl-dyn.isp.belgacom.be (HELO md) ([217.136.81.33]) by relay.skynet.be with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 21 Jun 2020 13:30:04 +0200 Message-ID: <013e37e14e361f8111eb7d2483429fa7328492c1.camel@skynet.be> Subject: Re: [RFAv2] Ensure 'exec-file has changed' check has priority over 'exec-file-mismatch' check From: Philippe Waroquiers To: Pedro Alves , gdb-patches@sourceware.org Date: Sun, 21 Jun 2020 13:30:04 +0200 In-Reply-To: References: <20200604204200.21266-1-philippe.waroquiers@skynet.be> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Jun 2020 11:30:08 -0000 On Sat, 2020-06-20 at 17:25 +0100, Pedro Alves wrote: > On 6/4/20 9:42 PM, Philippe Waroquiers via Gdb-patches wrote: > > This is version 2. Compared to first version: > > rebased to last master > > removed a comment duplicated by error > > 'git add-ed' the attach3.c file I forgot. > > > > Following the implementation of exec-file-mismatch based on build-id, > > an attach to a process that runs a modified exec-file was triggering > > the exec-file-mismatch handling, giving a warning such as: > > warning: Mismatch between current exec-file /bd/home/philippe/gdb/git/build_termours/gdb/testsuite/outputs/gdb.base/attach/attach > > and automatically determined exec-file /bd/home/philippe/gdb/git/build_termours/gdb/testsuite/outputs/gdb.base/attach/attach > > exec-file-mismatch handling is currently "ask" > > as the build-ids differ when an exec-file is recompiled. > > I wonder whether the warning should mention Build IDs, like > > - warning: Mismatch between ... > + warning: Build ID mismatch between ... Effectively, it might be more precise for the user to explain how the mismatch was detected. And if ever we add other ways to detect a mismatch, we then better give different warnings. Now, maybe many users will not know what is a build ID, and the more cryptic message might confuse them. If mentioning build ID is deemed better, I can do the change. > ... > So let's go with what you have. Some comments on the testcase below. > But otherwise, with those addressed, please go ahead and push. Thanks for the review, pushed after addressing the comments. Philippe