From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id D8B75385BF86 for ; Sun, 22 Mar 2020 02:47:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D8B75385BF86 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 171F11E5F7; Sat, 21 Mar 2020 22:47:39 -0400 (EDT) Subject: Re: [PATCH 2/7] [gdb/testsuite] structured rename of jit test files To: Tom Tromey , Mihails Strasuns Cc: gdb-patches@sourceware.org References: <20200218124339.11270-1-mihails.strasuns@intel.com> <20200218124339.11270-3-mihails.strasuns@intel.com> <871rqqs242.fsf@tromey.com> From: Simon Marchi Message-ID: <013699e3-9f9f-b312-e0d1-c42b34d19a9d@simark.ca> Date: Sat, 21 Mar 2020 22:47:38 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <871rqqs242.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US-large Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-17.1 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Mar 2020 02:47:41 -0000 On 2020-02-19 4:23 p.m., Tom Tromey wrote: >>>>>> "Mihails" == Mihails Strasuns writes: > > Mihails> Reorganizes how JIT related test files to be more clear what are related > Mihails> to JIT reader system tests and what use JIT from ELF objfiles. Those two > Mihails> approaches are quite different in GDB implementation and require very > Mihails> different test setup. Keeping distinction clear at the file name level > Mihails> makes it easier to maintain the testsuite. > > Mihails> gdb/testsuite/ChangeLog: > > Mihails> 2020-02-18 Mihails Strasuns > > Mihails> * gdb.base: rename all jit related test and source files > > Ok. Thanks. > > Tom > LGTM from me too, that's a good idea, thanks. Simon