From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20167 invoked by alias); 1 May 2009 09:24:12 -0000 Received: (qmail 20154 invoked by uid 22791); 1 May 2009 09:24:11 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.153) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 01 May 2009 09:24:05 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.2/jtpda-5.5pre1) with ESMTP id n419NecF068366 ; Fri, 1 May 2009 11:23:40 +0200 (CEST) Received: from mailserver.u-strasbg.fr (ms1.u-strasbg.fr [IPv6:2001:660:2402:d::10]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id n419Ne7I002716 ; Fri, 1 May 2009 11:23:40 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) Received: from d620muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id n419NdXm047141 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Fri, 1 May 2009 11:23:40 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) From: "Pierre Muller" To: "'Joel Brobecker'" Cc: References: <001801c9c397$0e35ba90$2aa12fb0$@u-strasbg.fr> <20090423184213.GE7552@adacore.com> In-Reply-To: <20090423184213.GE7552@adacore.com> Subject: RE: [RFC] Send new ARI warnings to gdb_testers mailing list Date: Fri, 01 May 2009 09:24:00 -0000 Message-ID: <013401c9ca3e$852e58c0$8f8b0a40$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00011.txt.bz2 Thanks for the remarks, Joel, > However, the way it is implemented right now means that we'll also get > an email when we fix things. I think that would be too much. What do > others think? What about the following patch: it does copy the old ari.source.bug to ari.source.old then it removes the line number field from each of the two files (in order to avoid seeing only line number changes due to code insertion or deletion), and compares the two resulting files. If the generated diff contains a '>' sign, it means that a new warning has been generated. The only drawback is that the line number also does not appear on the generated email... If someone with good awk knowledge can tell me out to substitute each line of the diff (without the line number) by the corresponding line of the files with line numbers, it would make the email better. Pierre Muller Pascal language support maintainer for GDB ... still only fluent in pascal language, getting used to C, but still ignorant in awk :( $ cvs diff -u update-web-ari Index: update-web-ari =================================================================== RCS file: /cvs/gdbadmin/ss/update-web-ari,v retrieving revision 1.141 diff -u -r1.141 update-web-ari --- update-web-ari 6 Apr 2009 21:27:02 -0000 1.141 +++ update-web-ari 1 May 2009 09:19:47 -0000 @@ -157,10 +157,21 @@ if ${check_source_p} && test -d "${srcdir}" then + cp -f ${wwwdir}/ari.source.bug ${wwwdir}/ari.source.old echo "`date`: Checking source code" 1>&2 ( cd "${srcdir}" && /bin/sh $HOME/ss/gdb_find.sh "${project}" | \ xargs /bin/sh $HOME/ss/gdb_ari.sh -Werror -Wall --print-idx ) > ${wwwdir}/ari.source.bug + difffile=${wwwdir}/ari.source.diff + sed -e "s/\([^:]*\):\([^:]*\):\(.*\)/\1:0:\3/" ${wwwdir}/ari.source.old > ${wwwdir}/ari.source.old-pruned + sed -e "s/\([^:]*\):\([^:]*\):\(.*\)/\1:0:\3/" ${wwwdir}/ari.source.bug > ${wwwdir}/ari.source.bug-pruned + diff ${wwwdir}/ari.source.old-pruned ${wwwdir}/ari.source.bug-pruned > ${difffile}-in + sed -n -e "/^>.*/p" ${difffile}-in > ${difffile} + if [ -s ${difffile} ]; then + # Send an email to gdb-testers@sourceware.org + mutt -s "ARI warning list change `date`" -i ${difffile}-in \ + gdb-testers@sourceware.org + fi fi