Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: John S. Kallal <jskallal@home.com>
To: Andrew Cagney <ac131313@cygnus.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Add remote P packet handling to GDBSERVER
Date: Wed, 25 Jul 2001 16:14:00 -0000	[thread overview]
Message-ID: <01072519180100.21656@CyberMax> (raw)
In-Reply-To: <3B4BDA51.5000902@cygnus.com>

I am back from my a very vital trip.  However, my medical condition is 
(again) becoming a problem.  I may be back in the hospital for additional
weeks any day.   

On Wednesday 11 July 2001 00:47, Andrew Cagney wrote:
> >  The following patch add 'P' packet handling to GDBSERVER
> > 	and does some code clean-up.  This patch replaces my
> > 	GDBSERVER patch of April 26 at:
> >
> > http://sources.redhat.com/ml/gdb-patches/2001-04/msg00256.html
>
> John, as you note, this contains two changes:
>
> 	o	cleanups
> 	o	addition of the `P' packet
>
> could you please split out the cleanup and submit that (first) separately
> (See also notes below on ChangeLog entries).  Trying to break patches
> down to separate independant changes is really important.  There are

I will break this into three patches.  
  -First patch, code file reformate with indent v2.2.6  with default setting. 
  -Second code cleanups.  
  -Last patch, addition of 'P' packet to gdbserver code.  

Each patch to depend on the prior patch and each patch reformated with 
default setting of indent v2.2.6.  If the default 'C' coding style is the 
current default of GNU indent, I think that you have a lot of source code 
reformatting to do within the gdb source files.

The code cleanup patch is a modified version of the un-approved patch in 
message http://sources.redhat.com/ml/gdb-patches/2001-04/msg00256.html .
So yes the code cleanups change was sent as a separate patch!  When the
code clean patch was ignored, I just included it with my next patch in that 
area of gdbserver code. 



      parent reply	other threads:[~2001-07-25 16:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-05-15 18:21 John S. Kallal
2001-06-27 21:10 ` Andrew Cagney
     [not found] ` <3B4BDA51.5000902@cygnus.com>
2001-07-25 16:14   ` John S. Kallal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=01072519180100.21656@CyberMax \
    --to=jskallal@home.com \
    --cc=ac131313@cygnus.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox