From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14431 invoked by alias); 8 Sep 2003 06:13:47 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 14406 invoked from network); 8 Sep 2003 06:13:45 -0000 Received: from unknown (HELO mail03.idc.renesas.com) (202.234.163.13) by sources.redhat.com with SMTP; 8 Sep 2003 06:13:45 -0000 Received: from mail03.idc.renesas.com ([127.0.0.1]) by mail03.idc.renesas.com with ESMTP id h886Df4r009267 for ; Mon, 8 Sep 2003 15:13:42 +0900 (JST) Received: from guardian02.idc.renesas.com ([172.20.8.133]) by mail03.idc.renesas.com with ESMTP id h886DeWA009260; Mon, 8 Sep 2003 15:13:40 +0900 (JST) Received: (from root@localhost) by guardian02.idc.renesas.com with id h886DemR028556; Mon, 8 Sep 2003 15:13:40 +0900 (JST) Received: from unknown [172.20.8.70] by guardian02.idc.renesas.com with SMTP id RAA28555 ; Mon, 8 Sep 2003 15:13:40 +0900 Received: from mta03.idc.renesas.com (localhost [127.0.0.1]) by mta03.idc.renesas.com with ESMTP id h886DcVJ009081; Mon, 8 Sep 2003 15:13:38 +0900 (JST) Received: from rnsmtp01.hoku_r.renesas.com ([10.145.246.51]) by mta03.idc.renesas.com with ESMTP id h886DbRJ009078; Mon, 8 Sep 2003 15:13:37 +0900 (JST) Received: from mrkaisv.hoku.renesas.com ([10.145.105.245]) by rnsmtp01.hoku_r.renesas.com (8.9.3/3.7W) with ESMTP id PAA04559; Mon, 8 Sep 2003 15:13:37 +0900 (JST) Received: from KEI (unknown [10.145.105.81]) by mrkaisv.hoku.renesas.com (Postfix) with SMTP id 5B957798501; Mon, 8 Sep 2003 15:13:37 +0900 (JST) Message-ID: <010401c375d0$96c42470$5169910a@KEI> From: "Kei Sakamoto" To: "Andrew Cagney" Cc: References: <02e201c35a5e$883a8cb0$5169910a@KEI> <20030817210347.GF11300@nevyn.them.org> <01af01c3679d$25650650$5169910a@KEI> <012d01c37359$e3f98510$5169910a@KEI> <3F589BD7.5080506@redhat.com> Subject: Re: [patch] New m32r remote target, m32rsdi Date: Mon, 08 Sep 2003 06:13:00 -0000 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1165 X-SW-Source: 2003-09/txt/msg00107.txt.bz2 From: "Andrew Cagney" To: "Kei Sakamoto" Cc: Sent: Friday, September 05, 2003 11:21 PM Subject: Re: [patch] New m32r remote target, m32rsdi > > Hello, > > > > I posted the following two weeks ago, but there is no reaction > > so far. > > > > Its patch adds a new remote protocol to m32r architecture and > > does not influence any other functions. So I think it's safe > > to add. > > Dig dig, ah I see Daniel wrote: > > > I don't feel qualified to review a new remote target, so you'll have to > > ask the remote maintainer. However, there's definitely a problem with > > the new code. It's full of pieces like: > > > > if (TARGET_BYTE_ORDER == BFD_ENDIAN_BIG) > > *((unsigned long *) (buf + 1)) = pc_addr; > > else > > *((unsigned long *) (buf + 1)) = pc_addr - 1; > > > > This sends host-endian data over the wire to the target. Run it on a > > big-endian host and bad things will happen. > > I guess that means me (but I'm only listed for remote.c :-). I'll look > over the revision. Thank you for reviewing my patch! > > I'm going to commit it next weak. Please let me know if there > > is any problem. > > That wouldn't be a good idea. I see. I'll commit it after your approval. Kei Sakamoto