From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2975 invoked by alias); 5 Aug 2007 22:08:37 -0000 Received: (qmail 2827 invoked by uid 22791); 5 Aug 2007 22:08:37 -0000 X-Spam-Check-By: sourceware.org Received: from a.mail.sonic.net (HELO a.mail.sonic.net) (64.142.16.245) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 05 Aug 2007 22:08:34 +0000 Received: from snyder (209-204-172-156.dsl.dynamic.sonic.net [209.204.172.156]) by a.mail.sonic.net (8.13.8.Beta0-Sonic/8.13.7) with SMTP id l75M8WKA032035; Sun, 5 Aug 2007 15:08:32 -0700 Message-ID: <010301c7d7ac$55749940$677ba8c0@sonic.net> Reply-To: "Michael Snyder" From: "Michael Snyder" To: "Mark Kettenis" Cc: References: <9892.12.7.175.2.1186278669.squirrel@webmail.sonic.net> <200708051852.l75Iq0Du032483@brahms.sibelius.xs4all.nl> Subject: Re: [PATCH] c-exp.y, memory leak Date: Sun, 05 Aug 2007 22:08:00 -0000 X-Mailer: Microsoft Outlook Express 6.00.2800.1437 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-08/txt/msg00111.txt.bz2 > > Date: Sat, 4 Aug 2007 18:51:09 -0700 (PDT) > > From: msnyder@sonic.net > > > > 2007-08-04 Michael Snyder > > > > * c-exp.y (parse_number): Memory leak. > > Shouldn't this use xfree()? Ah, right, that's what I meant to say. ;-) > > > Index: c-exp.y > > =================================================================== > > RCS file: /cvs/src/src/gdb/c-exp.y,v > > retrieving revision 1.38 > > diff -p -r1.38 c-exp.y > > *** c-exp.y 12 Jun 2007 15:33:03 -0000 1.38 > > --- c-exp.y 5 Aug 2007 01:49:51 -0000 > > *************** parse_number (p, len, parsed_float, puti > > *** 1096,1104 **** > > putithere->typed_val_float.type = > > builtin_type (current_gdbarch)->builtin_long_double; > > else > > ! return ERROR; > > } > > > > return FLOAT; > > } > > > > --- 1096,1108 ---- > > putithere->typed_val_float.type = > > builtin_type (current_gdbarch)->builtin_long_double; > > else > > ! { > > ! free (s); > > ! return ERROR; > > ! } > > } > > > > + free (s); > > return FLOAT; > > } >